products, not files

torgosPizza's picture
Offline
Bug FinderEarly adopter... addicted to alphas.Getting busy with the Ubercode.
Joined: 08/14/2007
Juice: 4110
products, not files

Mog -

That is a nice way of seeing the filename in the My Files table, but the main problem is that the products or SKUs are NOT what's listed in the file_product table when a file product is purchased.

When you purchase a file product, a row is inserted listing the user id and the fileproduct id (fpid). Instead, I'm suggesting that, instead of associating the uid with the fpid, associate the uid with the actual Ubercart product id (nid). Then the arguments in the module go through each product, and not necessarily find each filename associated with that product as this could take up quite a few processor cycles. We have 4000+ customers with around 90 files available for download.

I could probably dig into the code, and even create a duplicate module if I have to, but I think it's something that could be considered either an option or a refactoring. I think going by product instead of file id is the better, more flexible way to do it.

Not to come down on CpILL's awesome work thus far. It's a fantastic module and I think it can be made the ultimate for downloadable products (with Drupal's and UC's help of course).

--
Help directly fund development: Donate via PayPal!

File product By: torgosPizza (54 replies) Fri, 08/10/2007 - 10:05