Most implementations I've seen of hook_form_alter() are just changing a single form. Of course, they're just testing a single $form_id, and not several like the product forms. I'm not too concerned about the performance because all of the node type info is cached in memory, and I trust in_array() to be efficient.