good job on the rules and the upcoming file products.

Here are my 2 cents:

first, I don't really like the way that the my files works now in drupal, seems more of a user storage thing than a file download.

The process that I think is needed is:
any one can purchase a file product: anonymous and logged in users.
once the file is purchased it is copied out of the directory (under the root) into a dir over the root.
a mail is sent to the user with a link to download the files.
this link should expire after X amount of time and/or Y number of completed downloads.
there should be an ability for the admin to set these up, preferably different for each product + defaults.
the links can be displayed in a some sort of node like the my files in order to double up on the email link.
once a product is purchased by an anonymous user, the user should/should not be automatically registered with email/name/random/inputed field as user name and random pass.

it should be important to organize the files, maybe according to categories in the directory.
there should be some support for multiple formats to choose from - mp3/wav/wmv.

some kind of support for images as file products maybe with watermark.

come to think of it...if it could be possible to keep the format handling/sample the goods out of the core module, and create something like the shipping methods so other modules can plug into that and handle each format according to the module.

That's what I got...I really think that if this will be done, and really done right and fully it will make ubercart the must have sollution for digital e-commerce sites.

Idan