Thanks and answers

Posts: 108
Joined: 10/31/2007
Getting busy with the Ubercode.

Hi Ryan.

Thanks for taking your time to review my proposal. I know that the product grid is not for everyone but obviously the simple line by line table neither Eye-wink

It looks to me that the line by line model is good for long lists without picture while the grid is better for a more contained and organized look of the catalog oriented to mainly displaying the pictures, that's why I thought it could be interesting to have both systems to open to a wider range of users without hacks Smiling

>> it seems like the display may be optimized for a particular theme or set of CSS rules?

I don't understand exactly what you mean. Probably depends on many CSS rules around that catalog display table. I've added the new uc_catalog.css file replacing the previous one with some new visual adjustments, but more things could be adjusted.

>> and clicable is a typo of clickable

Wops, true, too fast coding for a non-native english speaker.

>> Not checking the box for the link display didn't seem to work to make "Catalog" not a link

I thought I had solved that. I've had a quick look at the code and I don't see the mistake. I see that the if statement for deciding if the block title is clicable or not works. It lools is not saving the variable from the admin page. Extrange because the code is so simple that I can't see what's wrong. I'll try to solve it.

>> the main catalog browsing seems to have been changed so it's only showing 2 columns at

uhmm, true line

684 > if(variable_get('uc_catalog_grid_display', false)) {

should be changed to

684 > if(variable_get('uc_catalog_grid_display_width', false)) {

since it's not looking at the proper varible. I was setting 3 on both grids and I didn't perceived the difference.

Well, thanks for you feedback. It needs more work.

uc_catalog.module modified to display products on a grid By: jorditr (56 replies) Wed, 10/31/2007 - 11:52