Ubercart

I'm not sure this the correct place to put this but.

I've installed the module and found that there's a small bug.

After I assign a sku to a file. I'm forwarded to this address:

http://arbel-designs.com/drupal/drupal-5.1/?q=/drupal/drupal-5.1/%3Fq%3D...

and I get a file not found, I suppose this doesn't exist.

I'm not a coder so i'm not really sure what to do about this...doesn't really hurt me that much because it appears to set the file first.

But thought you would like to know.

Idan

I'd like to have two options associated with a product - download file and ship CD ROM. I heard the word "attribute" used in another thread so not sure if "option" is the correct phraseology.

Do you think that your contrib could accommodate this kind of functionality at some point? I'd like for each option to have its own SKU.

thank you...

Ahh! That's what's great about CpILL's module. It's based on SKU, so you can use the product attribute system to change the SKU when a customer selects the download option. Then when they've checked out, it will be treated either as a CD or as a download based on what they chose.

CpILL,

Nice work as always. Found and fixed another bug. In the "My Files" table, the file size was showing up as 0.00 KB. That's because you were only looking for the file size based on the $file->filename and not looking for the uc_file_product path first. Here's the old code:

Around line 282:

And here's the fixed (working) code:

Might be a better idea to put the variable_get part of that into the uc_file_product_byte_size function, and pass the filepath instead of the filesize. Either way should work.

Do you think it'd be possible to have the database store purchased Products, and not Files? In my company's case, the ability to add "additional" files to a Product is almost a holy grail for us. I would much rather be able to add a new file to a product, and have everyone who's purchased that product gain access to the new file - without having to add the product to their order. That could be a time consuming process.

For me this would be extremely helpful and I can give you a real life scenario. We sell DVD commentaries - usually one for NTSC (region 1) and one for PAL (everywhere else). Sometimes movies have different edits, so Region 2 (UK) PAL might be different from Region 4 PAL (New Zealand, South America and others). Sometimes we don't come out with the Region 4 immediately; and a lot of times people from there won't know that we don't offer this version until AFTER they've bought the file.

A fantastic thing it would be if, later on we announce "Region 4 files have been added to the product" and those people this is relevant to, look in their "My Files" menu - and discover that the new file has automagically appeared, and is available for download.

What do you think? Possible? Too much work? Since this is something I could really use I am willing to devote time and energy into helping develop it.

(Note to self: The newly-added file would need to have a "fresh" limit for downloads and IP addresses).

Another suggestion / wish would be to likewise, instead of "My Files" - can we say "My Downloadable products" or something which then displays the products by SKU? The products can then link to a detail page with the downloads, or even better, could be an AJAX drop-down. I ask this because our number of downloads right now is somewhere in the 80s - approx 1.3 gigs of downloadable content, in around 40 different products. You can see where just one "My Files" page wouldn't be sufficient for very long, assuming a customer purchases every one of our items ... which is usually the case.

My need is similar to that described by torgosPizza. I want to sell a product for download. Customers buy the product, then go to MyFiles to download it. If at some point in the future we choose to update that product (it's software), we would like the new version to 'show up' on the MyFiles page of all current owners of the product. Is there an easy way to do this now without adding a new product and creating orders for all existing customers of the product? Any suggestions?

Thanks,

Roople
www.roopletheme.com

To get filename unstead of SKU in "My files" :
line 283 insert :

line 284 change to :

Hope it helps
Mog

Mog -

That is a nice way of seeing the filename in the My Files table, but the main problem is that the products or SKUs are NOT what's listed in the file_product table when a file product is purchased.

When you purchase a file product, a row is inserted listing the user id and the fileproduct id (fpid). Instead, I'm suggesting that, instead of associating the uid with the fpid, associate the uid with the actual Ubercart product id (nid). Then the arguments in the module go through each product, and not necessarily find each filename associated with that product as this could take up quite a few processor cycles. We have 4000+ customers with around 90 files available for download.

I could probably dig into the code, and even create a duplicate module if I have to, but I think it's something that could be considered either an option or a refactoring. I think going by product instead of file id is the better, more flexible way to do it.

Not to come down on CpILL's awesome work thus far. It's a fantastic module and I think it can be made the ultimate for downloadable products (with Drupal's and UC's help of course).

The reason I used SKU was because when you have products with attributes associating with it and you want a different file product associated with every different combination of the attributes (i.e. Operating System, Compression format etc) or even just one of the attributes. You can't do this with the product ID. If you give the product a SKU you can do a reverse lookup. The current way is more flexible that node ID.

Besides, you do see the file name in a column under 'My files', don't you? Or do you want a descriptive name to display as well?

Your comments about using the SKU makes sense. I think we can keep that working the same exact way, I'm just wondering if finding the associated files dynamically would be better than the current process, which is "User purchases a product, that product's filename is stored in the table with their customer ID."

I do see the file name, what I'm more interested in is showing a list of "purchased products" and then when that Product name is clicked, for example, it then expands (AJAX-style) to show the files currently associated with that product.

The main issue is, suppose I want to add another product to that SKU, or update a product (possibly even changing the filename in the process). Since the database stores the file product's physical filename in the uc_file_product_customers table, if the information in the file product's SKU -> associated files table changes, it would need to seek out and change all of the records in the customers table as well. (Find all changed filenames, change them accordingly, etc.)

What would be ideal for me (and this is something I can work on, or could also potentially offer a bounty for you to work in tandem on it) is a system that automatically updates a user's "My files" area when a product is changed in their purchased products. Whether it uses SKU or product ID or node ID, doesn't matter as much as the product itself is updated. That (along with the anti-leeching feature I've discussed before) would be my custom code contribution, and a possible bounty to sweeten the deal of course.

Sorry for being so verbose. There is a lot of info to cover.

Ah, I see what you mean. By 'uc_file_product_customers' table I'm assuming your talking about uc_file_product_users table, in which case your wrong in that the file name and other details are in the uc_file_products table so if you change edit that record you can change the SKU/filename etc and it will update whats in the users 'My files', you can add more files to the SKU but your right in that these new files won't appear in existing file purchases.

The real fix for this is actually a deeper Ubercart data model problem: the SKUs are not treaded as real IDs but are actually the 'real' products on sale. The current 'product' (or whats in uc_products) is actually a metaphor, its a description of one or more SKUs. You don't buy this virtual product but instead an SKU.

The functionality your talking about may or may not be require by everyone. Alternatively you could just zip the many files into one archive and then update the file product entry to point to the new file, which would effectively change it for all people who have purchased it, perhaps have an extension module to list all the files in the ZIP archive if you wanted to show them.

It would be good to have a reference to the NID of the product in the uc_file_products table but then you might right into trouble if the SKU wasn't unique to one product...

Ah! Sorry for my confusing the table names. (Yesterday was a long day.) I see what you're saying, though. I guess it would be more clear to say that instead of referencing the fpid in the users table, referencing the SKU - because the SKU could stay the same, but the products could change underneath it.

You're right in the sense that not everyone will need the functionality ... but I do I'm willing to offer a bounty (an amount TBD) if you or anyone else is interested in helping me develop the functionality we need. I am taking it on myself at the moment, or at least trying to, but still being wet behind the ears with UC and Drupal makes things a bit more difficult. Learning curves are a pain.

Yes, perhaps your right about referencing the SKU instead of the fpid, or perhaps turn it into a many-to-many relationship? I have to work on the inventory and importing modules at the moment so won't have time for a couple of weeks I'm afraid.

Cool! Well if it's something you think would be a viable change in your module code, I can (on a new copy of it) try to make the system I'm thinking of work.

It would also mean less rows in the users table, because instead of recording every individual file the user has purchased, we're just tracking the Model (SKU). So even if more files are added to the SKU, everything updates automatically since it's an independent relationship.

I can attempt the change and let you know how things work out.

jup, sounds god to me. i say go for it!

Hi all,

I'm getting the same error as the first post on here: "Page not found" after assigning a file to a SKU. Can anyone help me figure out what the issue is? Basically it keeps putting the drupal directory in the url twice, so there is no page to go to. Is there somewhere I can fix this? Thank you.

looks like a problem with the clean URLs enabled. I thought this was fixed? Which version of the module are you using?

1.4... should I upgrade to 1.5?

Okay, so I upgraded the module to version 1.5, but I'm still getting the same problem. I'm not sure what this is. the url that ubercart tries to access is: 'http://www.mysite.com/drupal-5.2//drupal-5.2/%252Fadmin/store/file_products.

The front page of my site actually redirects to the drupal site - could this be the problem? If it is, do you know where I can fix it? As far as I can tell, the issue lies solely in the repetition of the drupal-5.2/. If you can help me, I'd me very much appreciative. Thanks for your support!

I think the answer might be in your .htaccess file. Try changing:

to

Okay, I tried that but it still doesn't work. I'm not sure why, but it continues to insert the extra drupal-5.2 folder in the url. Everything else on the site seems to be working, so I'm completely baffled on this one. The thing is, it worked BEFORE we made the redirect, so I agree that it probably has something to do with that.

I appreciate all your help and suggestions. Can you offer any more?

Thanks!

Still no dice.. any ideas? I'm baffled as to why I'm getting an extra drupal folder in the url. Thanks!

Greetings all,

Just installed this module and got it to work as advertised (with a little help from this thread).

I was wondering if it might be possible to limit the times a user can download the file they have purchased, or have it expire in a certain length of time. For the time being, it looks like once a user purchases the file product, they have the ability to download it forever. In theory, the customer can then just give their login to everyone resulting in everyone getting the product for free.

If that is not possible at the moment, alternatively, is there a way an admin can remove files from a customers 'my files' directory?

Please let me know when you get a chance!

TIA,
txcrew

My need is similar - I would like to file to be downloaded only once. quickfile.module implements such a method that upon completing the download, the download count is decreased, until it becomes 0.

Another issue is anonymous download. I would like once a file purchase was made, that a link will be sent to the user in email, and the user will be able to download the file without logging in (again, see quickfile.module).

I am a coder, but have never looked into coding into ubercart. How deep of a change would that be? How do you estimate the complexity?

I think it would be easy to count the number of downlaods and check it against some limit set in the config screen.

The issue is that there is no interface for adding the file to the user again if they mess up while downloading. Also requires you to support the users.

Anonymous download will be tricky as the module completely depends on the user being logged in.

I think it would be easy to count the number of downlaods and check it against some limit set in the config screen.

OK. Thanks. If I get to add this to the code, I'll post it here.

Anonymous download will be tricky as the module completely depends on the user being logged in.

I kinda guessed that..
I do think there is a strong case for it, as many sites don't want to mess with users and passwords, and just want to sell a file and maybe another thing (e.g. a book PDF and a printed book). Having the link being sent in email to the users is a great convenience and a click-saver..

The issues with the anonymous download are:

- Increased support: people are going to lose the email/not get it, get disconnected half-way though downloading, try and pretend they got half way and try it again etc etc. This will require support staff, which if the site is large is not trivial. This leads to:
- Interface resend the email and perhaps track which emails have recived what

Which leads me to question your business process since you must track:

- Customer info to make the financial transaction
- Email address against which files they have purchased

so you have the same info as a registered customer (and more) so why aren't you forcing registration which gives you:

- Marketing statistics
- product performance by demographic
- increased security against fraud
- community networked
- customer satisfaction as they can come back and download if they lose file. Do they buy one download opportunity or the right to access to the information?
- etc

These would seem to be a good case _for_ the customer registration in the case of file download. Whats the case against?

- Extra click: then extend the module to auto download from the "thank you" page at the end of the transaction, but what if there is more than one file at a time?

Hi

After pressing the submit button upon check out i get the following error.

Fatal error: Call to undefined function: uc_get_order_status_id() in /home/jessie/public_html/modules/uc_file_product/uc_file_product.module on line 407

any ideas????

thanks, matt

I had this same issue that Ryan was able to help me with.

Open up uc_file_product.module and find the Ubercart hooks section. Look for the function called "uc_file_product_order($op, $arg1, $status)" (line 378) .. Change this:

to this:

This is mainly for CPiLL, but I've completed the code that bases the Purchased files off of the model (SKU) instead of fpid, as well as a little function that checks against IP addresses (to prevent leeching). I wanted to know if this is something you could use, since I'm not sure how you plan on working with this going forward. It's a substantial amount of code and I would hate to have to search-and-replace all of my functions every time we update the File Product (but I will if I have to - or I can just write my own module that's based on yours).

Also, to the Uberdudes, with regard to putting Downloadable File Products into core, I suppose it's a matter of how you'd best approach the concept of a Purchased File History. The code I have changed in CPiLL's module allows you to change the files associated with a certain product, thereby allowing updates across the user system (in case you add an additional file to the product package, the user's don't have to purchase it again).

CPiLL had said this could cause issues with purchasing different models of product, but I'm not sure how much of a pain it would be. I understand that my needs are a bit specialized and I wouldn't want to move forward with something that was less than flexible. I can post my code and functions here (or attach an updated .module file) so you guys can take a look. Everything I've written is pretty thoroughly commented. Let me know.

Hi, thanks for the pointer

I opened the uc_file_product.module

Located the Ãœbercart Hooks section on line 373 and the located the uc_file_product_order($op, $arg1, $status)on line 401, I then changed:

"if ($status == uc_get_order_status_id('post_payment'))on line 407"

too:

"if (uc_order_status_data($status, 'state') == 'completed')"

and it comes back with a fatal error listed below

Fatal error: Call to undefined function: uc_order_status_data() in /home/fmonsys/public_html/modules/uc_file_product/uc_file_product.module on line 407.

Any ideas

You need to update your version of Ubercart to Alpha 7e for that to get fixed.

Hi Ryan, If I upgrade to alfa7e will this effect all my products and settings in the shop????

Thanks, Matt

Hey torgosPizza, I'm quite happy to incorporate the change into the code. In fact I'm quite happy to let you take over this module as I developed it for a client that went belly-up before I even got to use it so my interest in it is waining. PM Ryan and ask if we can switch ownership of this contribution, or perhaps start another and get Ryan to kill this one.

What say you?

That sounds like a fine idea. Keep in mind I'll probably pick your brain now and then for help. So far I have the IP checking system working, but I'll be adding an option in the admin for that.

I'll send Ryan a PM (or if you're reading this, Uberdude, feel free to post your thoughts here).

Erik aka tP

Yep, saw the comments. Here's an idea... Shawn is actually set to start putting electronic products into core, referencing CpILL's contribution and other works like the e-commerce file module. The best thing to do would be to hook up with him for brainstorming and testing. A comprehensive core feature list would be great... I'd say start up a thread for file downloads in the Development forum with your thoughts and I'll bring it to Shawn's attention.

For now, I'll leave this contrib as CpILL's.

I fixed the order status issue, and reuploaded the contrib file (minus any previous SVN information). Please feel free to update this module, and let me know if there are still any issues.

FYI I am testing this myself and the fix Ryan had suggested earlier on (for order statuses) worked fine, so if yours breaks, make sure you are running Alpha 7e.

I can't find where to download this module...

How do I download this new version 1.7.1

I updated the ZIP file at the beginning of this thread.

Sorry but i can't find any zip files to click on! I must be blind.

Sorry about that! I had uploaded the file but failed to list it. It's fixed now!

http://www.ubercart.org/files/uc_file_product-1.7.1.zip

Hi,

I had update from Drupal to 5.2 and installed a fresh Ãœbercart alpha-7e.
With File product module enabled, I always have this error at when submitting order , i.e. http://.../cart/checkout/complete

When disabled, my ubercart works perfectly, with File product module enabled, I always have this error. Any idea why?

Fatal error: Call to undefined function: uc_get_order_status_id() in /home2/portabl/public_html/modules/uc_file_product/uc_file_product.module on line 407

Never mind, found the culprit.

Somehow, I installed File products 1.6 and it cause the problem. Upgraded to 1.7.1 and seems to work alright.

BTW, you forget to put the folder name (uc_file_product) inside the zip file.

At some point in the not-too-distant future I need to have a serious look at integrating Amazon S3 storage for file products - I'm wondering whether you accept commissions and how much would such an undertaking cost?

many thanks

Ole

Ole,

I can't take on a task as integrating S3 storage at the moment, since I know nothing about it, except for having heard about it. However you might be interested in the Media Mover module, available at the link below, which supports S3. I'm not sure what it would take to integrate it with Ubercart, however.

http://drupal.org/node/185119

First off - thanks to all making Ubercart and this module possible!

I've added the module, uploaded the file, created a product, assigned it the SKU that I created.
All good.

I can purchase it - no problem - and "My Files" shows up in the left navigation as it should. But the file isn't listed.

I'm guessing it has something to do with the fact that when I go to update the order - I get an error - for example updating to "completed" - I get this:

warning: Invalid argument supplied for foreach() in pathToMyDrupalInstall/sites/all/modules/ubercart/uc_file_product-1.7.4/uc_file_product.module on line 350.

Any ideas what might be the problem?

Thanks!

Strange, I can take a look. Thought I had all of those bugs sorted out - but I'll check into it in a little bit here.

You might also try updating to the latest bazaar code of Ubercart - the Uberdudes have integrated some of the features of this File Product module with some awesome features of their own. You'll need to disable / uninstall File Product and then, after upgrading, activate the File Downloads module (uc_file).

Since their module is much tighter, being in core and all, I imagine this Contrib will slowly get phased out, if it hasn't been already.

Thanks!
I'll give that a try.
I didn't realize that this feature was going in the core.

Best,
p

Hello everyone, I would appreciate your help with this issue:
After placing an order and completing the payment with paypal, we get this error:

Fatal error: Call to undefined function uc_order_status_data() in (website)/modules/uc_file_product/uc_file_product.module on line 401

We're using Ubercart 5.x-1.0-alpha7b with file product 1.7.4

It's urgent of course,
Thanks in advance for your help.