Ubercart

thx for this contribution, would be really helpful for me. when i first tried to install it, i got the following error:
parse error, unexpected T_OBJECT_OPERATOR in /var/www/web8/html/modules/ubercart/contrib/uc_taxes_price/uc_taxes_price.module on line 143

i looked at the line and changed
$type = node_get_types('type', $node)->type;
to
$type = node_get_types('type', $node->type);
maybe just a typo?

now i don't geterrors anymore, but am also not able to get the shop to display the prices with the tax applied. would be great if you could take a look into this, i'm sure thats no big thing
ah yeah, i set "add vat price to product price"-permission for any role. thank you very much

...sebi

k, sry hat was stupid, pls ignore my last post... i looked up the api and saw that node_get_types expects an input in form of
node_get_types($op, $node, $reset)
anyways, i got it to work by adding an additional step to determine the "type's type"
the whole function now looks like this in my installation and seems to work for me:

I will look through my package for errors and will repost a full new package very soon.

Thank you sebi, it seems it works for me too.
---
Edit: No, on checkout page the tax is not included!
@zmove: Thank you very much. It would be really nice get this feature working.

"the tax is removed to show the product prices without tax because discount and other stuff have to be calculated on without tax prices."

Well, that's true, but could it be calculated in the background and just display br price (or both) at the cart?

If user wants to see details, he/she can check all discounts and whatever at checkout + from the invoice.

What do you think?

Best regards,

Zsigmond

@green:

this is normal behaviour because of discounts being added on the checkout page. i suggest you

1. turn off the "shopping cart"-block for "cart/checkout" and "cart/checkout/*" in drupal's block configuration
2. go to "store administration->configuration->checkout settings->edit->checkout panes" and disable "cart contents".
3. if you translate your shop, you can just overwrite "Subtotal" with "Subtotal (net)" in your language...

a little hacky, i know, but it satisfies my needs
have a good time

...sebi

Hi there, and thank you for your answer.

I will post today a new little version that correct some problems.

For the price excluding vat on the checkout page, the problem is that Ubercart don't provide hook to alter the subtotal, and the subtotal is calculated by adding the product price * quantity in the cart.

So, to alter the subtotal I'm obliged to alter the cart, that's why I return to excluding price in the checkout page.

As it said below (and this is the way I proceed), the best way ATM is to disable the cart block in the checkout page, and change the title to the cart pane to specify that prices are excluding VAT.

I will improve that when Ubercart will provide these functionnalities because it's a think I don't really like too.

Edit : New version updated

Hi zmove, thank you for you patch! But if i upload uc_taxes_price.module i get the same error again: (on all pages)
Parse error: parse error, unexpected T_OBJECT_OPERATOR in /var/www/web2/html/sites/all/modules/ubercart/contrib/uc_taxes_price/uc_taxes_price.module on line 165

and there is:

Strange, this is not a code error,

writing the instruction below is exactly the same think that the folowing instruction

But it's written in only one line... what version of PHP do you use ? I have PHP5, maybe this shortcut is not compatible with previous version of PHP...

I correct this shortcut to correct this error, download the 1.2.1 version

this could be the reason, i'm using php 4.3.10-22.

maybe this is the reason, i'm using php 4.3.10-18 and also 1.2.1 does not work.

Strange, I tested it on a php4 install and it works. It is a clean ubercart installation ?

Did you give the right access to see product with tax in the access control of drupal ?

Hi,

I don't think that's a solution for me
Net and/or Br (= Net + TAX) price should be shown...

Hi, first of all thanks for your work.

no let's go for some problem,

If 'uc_attribute_option_price_format' is set to 'total' your form_alter (uc_taxes_price_form_alter) works, it creates the $form['attributes'] with taxes, but it doesn't override the _uc_attribute_alter_form, so the attribut price is still without vat ...

in case of 'adjustment' it's the same, and i think you forgot to set vat, it'll be something like that :

$display_price = ($option->price != 0 ? ', '. ($option->price > 0 ? '+' : '') . uc_currency_format($option->price + ($option->price *  _uc_product_taxes_calculate($node)),2) : '');

Then i got a strange problem with your module when setting 2 attribut for a product, the second attribut will be add twice to the price ... but i think it could come from the problem with the hook_form_alter.

regards
Mog

Hi,

It begin to be a long time I worked on that module, and I don't exactly all the code.

For your first problem, try to put a higher weight to my module than the core attribute module in the system table.

My store works with 'total' uc_attribute_option_price_format, and it works, but I may have to change the weight as I said above.

for the second problem, I think it could have the same origin because the core attribute function make a += to calculate price, and in my module, I initialize variable to avoid this problem.

If you still have these problems after updating the module weight in the system table, give me feedback again.

Great, now it works, thanks a lot, i didn't know the trick of system table to overide hook, i feel less stupid now !

It still have problem with multiple attribute, but i find where it come from :
line 122,
$item->price += $op_prices;

was not in the foreach, so it takes only the last option price.

And i still get my proposition to get option price with vat in case of adjustment :

line 68 insert,

regards
Mog

Ok thank you for your patch, I don't have multi attributes product and as I'm lazy, I didn't test them. I will try your code and release a new package if it works well.

Hi,
thanks zmove for your contribution, works well with my client's store.

I have couple suggestions for this module:

1) The product price should be able to have the choice if it's added including or excluding taxes. (example image attached)

In business-to-business shops the VAT exclusion is ok, but when dealing with business-to-customer, the VAT/taxes are not that critical to know. I't actually a real pain to first decide what the customer-price is and then calculate the tax manually. But the tax separation should still be shown in the checkout panes.

2) If the product is added with tax, then the taxes should be calculated EVERYWHERE, even the checkout review-pane. I had to override some functions in order to get it work...

But great job so far! I'd be glad to help in testing & debugging if needed.

Hi,

Thanks for your feedback.

At the moment, I don't need the functionnality to add product price including tax, and I think I will not need for a long time. I develop store for french customer and in france, prices are calculated without tax.

But this is a good idea to make the module more extensible, and I think I will add it in my TODO list.

But my priority at the moment is to work on userpoint integration with ubercart and some others functionnalities and I will not have time to do it in short term, so if you need it quickly, I will enjoy to help you to improve the module and add it in official release if the code satisfy my quality criteria.

May I'm just a stupid beginner, but I don't know how to include this function at all.
I put this module to "modules/ubercard/contrib/uc_taxes_price/uc_taxes_price.module" but nothing happend and I can't see any options in access control or elsewhere about. How can I activate this function ? I'm using ubercard beta 5...
I would be very happy if anybode can help me, cause this is the last issue I have with my shop. I need prices shown including VAT.

Thanks for any help
Jürgen

Ok, I AM just a stupid beginner
I found out, that the info-files was missing in latest release. Now I can see and activate the module and the options in access control.
But if I add a product to the cart a blank page appears when I'm not logged in.

....

g
Jürgen

I reup tha 1.2.1 with the .info file, on my ubercart installation, it works with beta 5...

But if I add a product to the cart a blank page appears when I'm not logged in.

hi Jügen blank pages are often the sign of PHP running out Memory.. or any other PHP issues have you checked your error logs maybe they have some Information that could help you / us to solve your Problem.

Hi,

Now with last ubercart release you have new block "special offers" and "best sellers", but it seems to use views handler to display product field.
uc_product.module line 1173
function uc_views_handler_price
and so it doesn't take care of uc_taxes change to display price and i don't find how to hook this views hook (?) without modifying uc_product.module

if anyone has an idea ...

regards
Mog

I had the same problem with a special offer view I created...

To show product price including tax, I themed my view, and in the view.tpl.php file, for the price field, I added the tax to the product for the good roles.

To get the tax you can use _uc_product_taxes_calculate() function (see in the module). After that, it's pretty easy to make the simple calculation to add the tax to product price.

This contrib isn't working into a beta6 version. Prices still the same...

hmmm, did you set the role that have to see product with vat included ?

Yes I've two roles for backoffice and common registered users in frontoffice.
I've seen in the last release that privs are for NOT showing VAT prices, so I've checked only for backoffice roles. My contrib version is latest till now (1.2.1)

Just tried installing this useful-looking module, but didn't find any of my displayed prices changing. After realising that I was logged in with the super user account (uid = 1) (doh!) I then logged out but found that anonymous users *still* saw ex-VAT prices.

I am not using any node types of "product", but rather a set of Ubercart classes, so I think this modifcation needs to be made in this case (works fine for me now anyway):

I have basically just changed the first part of the function. Hope it makes sense and helps someone else.

Regards,

- Paul

Hi,

It appear that recent changes in ubercart beta 6 breaks this module, I don't have time ATM to see what to change in my module to make it work on the latest beta 7.

I will be able to work on it in 1 month (I have a big project that take all my time for 1 month),

After that, I will make my module compatible with the latest ubercart release (1.0 ? ).

So, be patient or post a patch ^^'

Just round to 1 and not 2 to avoid .01 and .99 ¢ prices...

This module breaks horribly with uc_product_kit. The only solution I could find is to modify uc_product so that it simply displays prices with VAT directly. I think the best way to get this feature for Ubercart is to simply build it into the core.

Some functions, like views tables with products, don't even have any hooks available to allow a developer to modify the prices in his own module.

I've spent this morning implementing this module. I found a few issues with it,

1. Seemed to get very confused with price adjustments. In correctly calculating new prices.
2. Checkout was confusing, going from seeing prices with vat, to prices without.

So i've hacked about with it, and added a few bits, quick break down as follows (patch from 1.2.1 and full copy attached).

I changed.

1. Comment in payment pane from "based on current French VAT, round up/down to the nearest cent , applied on total price", to a more general "VAT is round up/down to the nearest real amount then applied on total price". Could probably be worded better, but i wanted to keep away from currency specific terms (cents).
2. Changed the uc_taxes_price_form_alter module to pre-calculate the price adjustment, fixing the poor handling of price adjustments
3. edited the _uc_product_taxes_calculate function, removing a redundant call (node_get_types)
4. Added a theme function, phptemplate_cart_review_table - to allow for vat on the checkout review

Still a few issues like the cart block showing prices ex-vat when on the checkout, but i think we will work around this. There is also a bit of a killer one, which is this module needs to have a weight greater than the main uc_taxes module, else its form_alter changes get overwritten by that module. To fix this, simply increase the modules weight in the system table. I did it by hand, but someone should/could submit a patch for it to update as part of the module install.

Enjoy.

Interested to hear feedback.

Drayen

--
acmconsulting.eu

Thank you for your improvement guy.

I don't have time to test it, but I will thrust the communtity, if the reply about your patch are good I will make it core.

@Drayen: Thank you for your work, the phptemplate_ thing was a nice and useful lesson for me! BTW we could solve the cart block the same.

I see more issues, as - at least in Europe we should until the Subtotal/Total and in order summaries always display taxes:

1. Invoices are easy to solve by a customer.eu.itpl.php
2. "Shipping calculation" on /checkout and "Calculate shipping cost" on /review I am still not able to influence
3. Order page (at least for the customer) the product summaries should be also incl. VAT
4. European tax calculation (on per-item base) brought up by humanoid. I don't see a chance to override this, but as a core hack it is three times a small change in uc_taxes_workflow.inc
   So I think this we could provide as regular updates until the feature freeze is over.

- Has someone a clue how to modify the product price (through a module) in uc_order_order_pane.inc in function uc_order_pane_products($op, $arg1) / case 'customer' without changing the subtotal?
- Any ideas how to modify the two mentioned shipping costs?
Any help would be greatly appreciated as this topic slowly drives me crazy...

Best regards,
Al

Hi. I'd like to sponsor the development of this contrib. Is someone interested? Please PM me.

We urgently need this feature. In short:
- enter sell prices without tax
- have 2 different VAT rates (10 and 19) per product, ability to set it for each product
- display and sell products with VAT
- assistance to get it working right

Thank you.

@borgo:
I have partially implemented this module as a patch for Ubercart 'core' to make it work reliable on all fields. The module as available here currently does not (and, unfortunately, cannot) adjust prices in views (e.g. listings of products).

Is this module valid for someone using RC4 ?

And whats the best version of the module?

Hi,

Yes, it doesn't work for view. You have to theme your view field to call the function that add tax to the price to make it work. I think with a little code, the module could add a price with tax as a new view field. I'm don't know development for view, maybe somebody can confirm this ?

For the RC4 compatibility, I think with the different patches it could be done, not sure I'm still on the beta 5 ^^

I added the content of uc_taxes_price1.2.1.zip to modules and I don´t see an extra module in /admin/build/modules with the name "Value Added Tax price alter"

I also don´t see a .install file...

What should I do exactly with the 2 files from the zip.

Hi,

The module have to be in the contrib directory of ubercart.

For the .install file, this module don't need one because it don't alter the database.

Hi thanks for updating this module but
I have a question how do I update the weight
of the module?

thanks

To change the module's weight, you have to alter your database a little. Your site's modules and themes are stored in the system table. Make the weight column bigger and it will be loaded later in all the hooks it implements.

uc_attribute must be enabled to run this sucker.

http://www.ubercart.org/forum/support/5947/called_undefined_error

If showing prices with VAT is important to you, please add you 0.02 euros to http://www.ubercart.org/forum/ideas_and_suggestions/6565/better_tax_supp...

Hi,

i have a problem with the userpermissions. The module works if modify the flowing code.

What is the reason?

It does no effect if I check the permissioncheckboxes on the Accesscontrollsettings of drupal.

Great idea this module!
But unfortunately I'm getting some errors and warnings.

When adding a product to cart:
Fatal error: Call to undefined function _uc_cart_product_get_options() in /usr/home/-----/modules/uc_taxes_price/uc_taxes_price.module on line 111

When viewing a product
* user warning: Table '-----.uc_product_attributes' doesn't exist query: SELECT * FROM uc_product_attributes WHERE nid = 12 ORDER BY ordering in /usr/home/-----/includes/database.mysql.inc on line 174.

Edit: Errors only when not logged on (so when VAT is added).

Enabling the Attribute module soved the issues above!
Thanks for this module!

Hi zmove, can you please make the module uc_attribute to be a requirement for this contrib? In line 48 you write "SELECT * FROM {uc_product_attributes}". But this table only exists when the module mentioned ubercart module is installed. If uc_attribute is not installed the user gets a warning message.

ikaya

I've just installed drupal 5.12, ubercart 1.6 and addtaxtoproduct 1.2.1

This module does not appear to have any effect on prices with this setup.

Ahh I see! The prices are not shown inclusive of tax IIF you are logged in with the su (user/1). Is there a way to avoid this?