Ubercart

Looks pretty good! One thing I noticed and would like to bring up, not sure if you have the time now, but .. to integrate with Workflow-ng, or at least to put a function in your module that updates the order status when the balance and cert amount negate each other.

I bought a product for 3.99 with a 3.99 certificate, and when I completed the order, the status was left at "Pending." It'd help if we could make that "Complete" perhaps.

Also when looking at the admin view of an order, the Total is not displaying correctly.

Subtotal: $3.99
Gift Certificates: -$3.99
Total: $3.99

Still testing but so far it looks awesome. Nice work!

TorgosPizza,

Thanks, I will look into this. I have not yet familiarized myself much with the workflow-ng module; I was actually just looking into it today.

Cheers!

Couple other things - it doesn't seem to be deducting the amount of the certificate. I paid for that 3.99 item as mentioned above, and the only certificate I had was for 3.99. When I went to buy another item, it still told me I had 3.99 available in gift certs.

Also, since this is a non-shippable item, and I have checked the box to tell the cart that this is so, the Delivery pane shouldn't be visible - but I have a Delivery pane when I try to purchase a new certificate for someone.

And since it is technically not shippable, it tells me I need to select a shipping option before I can continue.

Just a few minor bugs, hope you can get 'em worked out! Would love to start using this

TorgosPizza,

Your first comment about the certificate not being "used up" is a concern. It definitely works with my version of the cart. Please test again and if you are sure this is happening, then I will test here with your version of the cart.

Regarding you later comment, the module should not be affecting anything to do with shippability. If you have a product that is non-shippable, then adding the attributes to "make it a certificate" could not affect this.

Cheers,
Darron

No, this is when I'm attempting to purchase a gift certificate for someone. This is with the latest version of the module (downloaded from this page). I will double-check and test to make sure it's not a fluke.

how do you handle if somebody is placing more than one amount into the cart, like email and textarea, then?

Hi,

I know this module was only tested with Alpha 7e so this is just an FYI.

When I user this module with Alpha 8.

I get the following error:

mysql_real_escape_string() expects parameter 1 to be string, object given in /mnt/w0402/d20/s41/b0265cfb/www/sitev2/includes/database.mysql.inc on line 400.

It occurs after the payment has been processed.

madsqrl,

We will be testing with alpha 8 soon. I don't know offhand why you are getting this error. Are you sure that this module is the cause of the error? If anybody else is testing with alpha 8 could you leave a comment letting us know whether you encounter problems or not.

It appears to be the situation.

When I disable the module I do not get that error on purchasing everything works. When it is enabled I get that error.

I get (4) instances of the error message:

mysql_real_escape_string() expects parameter 1 to be string, object given in /mnt/w0402/d20/s41/b0265cfb/www/sitev2/includes/database.mysql.inc on line 400.

I am purchasing using a real PayPal provider with IPN enabled. The error happens after the IPN is processed successfully and at which point the gift certificate should be granted.

Btw issues aside this is a VERY cool module and a great idea!

madsqrl,
Thanks for more details. So the certificate is not granted at this point? I am going to try the module with alpha 8 tomorrow and see if I get the same problem. I will let you know and we can sort this out. If you have the devel module installed you can let me know the sql queries sent to the DB.

Cheers,
Darron

EDIT: if you don't have the devel module installed, don't bother until I look into things further, get back to you soon

The certificate is never granted, I checked the certificate database table and it is empty.

Please let me know your results and if I can help you debug further.

I can install the devel module if necessary.

OK,

I will test to see what is going on. Don't spend time installing the devel module until I check it out.

Cheers

Wanted to say this is a great module...I'll be having a shot over the next few days...

madsqrl,

I tried out the module with alpha 8 and I did get the same error you were getting. Here are the technicalities for anybody interested. There was a change to the argument passed to hook_order when $op is 'update'. $arg1 used to be an order id, now it is the whole order object. If you put the following code at the beginning of the 'update' case, it should fix things:

if (!is_string($arg1)) {
$arg1 = $arg1->order_id;
}

I will update the .module file soon, so if you find it easier, just get the new file. Please let me know if this fixes your problem.

Cheers!

EDIT: the file has been updated

Thanks for the update.

I added the above lines of code to my local version.

The previous error is gone now but I am seeing some odd behavior.

In the case where the recipient email address is for a registered user I get two gift certificate records created one for a $0 dollar amount and one for the amount of the product. The gift certificate does appear to work in terms of reducing order total and the value is deducted from the certificate.

In the case where recipient email address is NOT for a registered user then I get two duplicate gift certificate records created for the amount of the product. BUT no email is sent to the user's email address that was given.

Thoughts?

BTW, I dont see an email for the registered user either informing him about the gift certificate.

Email functionality is definitely working on the site, as other Drupal modules including Ubercart use it successfully.

In the case where as administration I directly (without purchase) create/grant a gift certificate, only one certificate database record is created but no emails are sent.

Also it does look like new user accounts are being created for the the non-registered users so it looks like we have email issue and an issue with duplicate record generation on purchase.

I have not experienced any problems with sending emails. B.t.w., when an admin creates a gift certificate, it is not set to automatically send an email. I can add a setting to allow for an email to be sent in this case as well.

When a certificate is purchased by a user, it either sends an email to an existing user, or creates a new account and sends an email with the acct info / certificate info. Also, this has been set up and tested for a site that does not have anonymous purchases.

EDIT: I just tested (with alpha 8 ) the case where recipient email address is NOT for a registered user. It emailed correctly. I'm thinking your email got blocked by a spam filter, did you check the spam box?

Yep it was the the SPAM filter for not seeing the emails.

I think it would be good option to allow Admin issued certificates to have the option of sending an email also generation of a certificate code.

Still seeing the duplicate database record issue. Also the order ID is null in the certificate database table even in the case of purchases which may be a bug.

Thankx much this is a cool module!

madsqrl,

Thanks. No, this is not a bug. Also the gift certificate rows you see in the database that are $0 are "used up". Say someone has a certificate of value $100 and they make a purchase of $10, the certificate value is updated to $90. So certificates are used up until their value is $0. I think everything is working fine on your install.

I will be adding in the option you mentioned (With a seperate configurable email for this case). Thanks for helping with the testing!

I hate to disagree but I think something weird is going on here still:

This is not a case of used up certificates, for example for a new order I get two certificate entries:

certificate_id name value user_id order_id purchaser_id cert_code
9 Gift Certificate 2.00 7 NULL 3 9-M4BSjb9aRVus
8 Gift Certificate 2.00 7 NULL 3 8-oHQLE5nGTlmL

I think the issue may be that for different order states the order transitions through, you are generating multiple certificates in your order update case?

Also interesting condition I have seen with user emails. Sometimes the user email isnt sent until the order is in the completed state. But a user has be created (but never accessed) in Drupal. This leads to the wrong email being sent because a user does exist even though the user has never been notified or used the account.

Thoughts?

UPDATE:

I changed my local version to only issue new certificates on the payment received order update case and it is definitely much better behaved. I also added a check to see if the user account was ever accessed in determining which email type to issue.

Hmm,

If this is happening, then there must have been some other changes to hook_order. I will look into this.

EDIT: It looks like hook_order was called twice for your setup wth $op 'update'. As we mentioned at the bottom of the included README, this could be an issue for certain setups. Also, as it says "We will be adding in a setting to only issue certificates on certain specified statuses.".

I hope everything is working for your setup now.

Yep. When you add the setting to issue certificates only on certain specified statuses that should address the issues related to what I patched locally.

Thanks again.

madsqrl,

You're welcome, thank you for your input. I will post here when the changes are finished.

Hi there,

thanks again...

I was wondering if there was a way to set the date that the email/account was issued, or delay the issuing. This would allow users to buy, say birthday presents, setting the date that the email was sent out. Also, if the email is to be accompanied by a gift card, it will take a few days to ship, but if the gift card arrives after the email, the email would ruin the surprise.

Can anyone see a way of adding this functionality?

thanks

thomas

Thomas,

This sounds like an interesting feature to add. I think we need a new field to the cert table, a new setting (delay time), and the email sent with hook cron. I am a little busy at the moment to add this right away. Would be glad to integrate this into the module now if you or anybody else gets the chance to do the work.

Cheers

Hi TCS,

so happy to get stuck in and learn how to do the coding...and will do. I was wondering if anyone had any good suggestions as to where to start to learn how to do the things you've suggested. Are there any particularly good tutorials...would you recommend one of the Drupal books...or where do I start.

I'll work it out somehow, but tips would be great.

thanks

I recommend Pro Drupal Development. It's the most recent (last time I checked) and has great examples and easy-to-follow narration.

@ TCS - testing the latest code on our test box, everything seems to work great! I can import our old certs and it seems to recognize everything as it should. Kinda wish we had the certificate entry code on the checkout page, but that's okay - I think attaching it to a user is cool!

But, suppose an admin wants to send a certificate to a user not on the system. Seems you can only do that if you are purchasing a certificate, but not administratively sending one. Any thoughts on that? Or am I missing something?

Otherwise - great work! Will be implementing it soon

muirland,

Thats great. I think the suggestion of "pro drupal development" is good. There is really no other resource that compares. I will be posting soon the new files with the changes I mentioned. Thanks for all your useful input!

Cheers

torgosPizza,
Thats good to hear. Good point about the admin. I will make the changes to allow for non-registered users to be issued certs from an admin.

Cheers

Hi I am getting the error: warning: Invalid argument supplied for foreach() in /home/loopske/public_html/modules/ubercart/contrib/uc_gift_certificate/uc_gift_certificate.module on line 816. I know this is a PHP4 error so i upgraded to php5 uninstalled the module and reinstalled and for some reason it it is stil giving me the foreach () error. Does anyone know why this is? Thanks

I looked at the code line from your error message and it is not immediately apparent what the problem is. I will be updating the file tomorrow. If you still have errors after testing the new file, we can take it from there

I got the same error on php 5

zmove,

you could try putting the following before the foreach statement on 816:

if (!$form["attributes"]) {
return;
}

I will upload a new tar file and include this. The new files have other fixes mentioned above. This might result in the "message area" of a product to be a textfield as opposed to a textarea. If so, you could try changing the "weight" of the gift certificate module. Do let me know what you had to do to get it working.

Cheers

TCS,

I tested the gift certs again, and I had a question. When the order status is updated, does it reissue the certificate?

I "purchased" a certificate for a "friend" who did not have an account, for $20. Paid for it by check / test gateway.

The account was created, and it sent an email with those details, along with the gift certificate information.

Since the order was placed using the test gateway, the admin had to manually change the status to "completed."

Upon doing this another email was sent, 3 minutes later (the time it took for me to login as admin and change the order status, it seems).

When I logged in as the "friend's" account, added an item to my cart, and checked out, it told me I have $40 worth of gift certificates - twice the amount that was actually purchased.

This could be a problem especially for workflow integration, where the order status might need to get updated a couple times (for shipping purposes especially).

TorgosPizza,

The latest version has a setting in the admin now that would allow you to only issue a certificate when the status changes to "completed", or what ever status you choose. I made the following edit in the post above:

Note: If you are having any problems with duplicate certificates (or no certificates) being created, change the last setting in admin/settings/gift_certificates, so they are only created for chosen "order status".

I hope this setting will allow you to configure things correctly so multiple certificates are not sent.

let me know.

Cheers,

Darron

Thanks, thought I had the most recent version - guess not Will check this out! Thanks!

I have downloaded the latest code, and the gift certificates do not seem to be updating after a successful completed purchase using them. Checked the database, my $10 gift cert that I used to successfully complete a $2.99 zero-total purchase with, still shows a 10.00 value in uc_gift_certificates table.

Also in the invoice (emailed and through Order History), the token [order-payment-method] is not being replaced correctly.

Finally, and this is minor, the Gift Certificates line item comes after the Subtotal in the Order Detail screen. Since it's a subtraction, it should probably come after the Subtotal.

torgosPizza,

I have not had any problems with the gift certificates not updating the way you described. I have been testing with alpha 8, are you using the latest bazaar? not sure if this is the problem. Do you have the side block enabled to see the gift cert amount that is credited to you? If so, after your 2.99 purchase, it still says 10.00?

It would be good if others could leave a comment letting me know if they are experiencing this (and what version of the cart they are using). I will test here again to make sure the tar file I uploaded is good.

I found the problem. It seems that the certificate is only updated when the Status moves to "Completed." My test site had order completed Workflow config set to Payment Received. Testing again, but all seems to work now. Thanks!

Although I did see your mention of the sidebar in your README file, but I don't see the config option for that anywhere...

torgosPizza,

Thats good to hear. The block can be enabled at admin/build/block. It is called "gift certificate" I believe.

Cheers

Hello, first off all, good idea, and defenitly needed! thx

I'm testing on alpha8 and experience some problems:
1. Both unregistred: With a unregistred user buying a gift cert using bank transfer as payment (admin has to set complete) the message for the one who should receive the gift cert will never arrive (or sent out)
2. Buyer registered: same problem, there is no gift cert in the store admin -> gift cert
3. Both registrered: same problem, ...

it seems like that there is no cert entered or sent out when payment methods involving "admins setting changing" are used...

Just had an incident where the certificate did not work. They had a $20 certificate and when they checked out and tried to use the Zero Total option (since the cert covered the entire 18.95 order), this is the message they got:

Your final order total is 3.5527136788005E-15, not $0.
Please go back and select a different method of
payment.

Your order is not complete. Please review the details
of your order and click Submit Order if all the
information is correct. You may use the Back button to
make changes to your order if necessary.

Payment Method
Subtotal: $18.95
Gift Certificates: -$18.95
Total: $0.00
Paying by: Zero Total

I had to process their order manually. Everything looked fine (I've used certificates on multiple occasions to purchase new releases .. so for instance I have a $500 certificate I have used to buy a 3.99 track with just for testing).

Any ideas?

It's the same PHP rounding bug... the zero total method should use the method of checking values -.01 < x < .01 for a zero total instead of x == 0. Or it could use number_format() to two decimal places... I wonder if I should be doing that instead, too.

This rounding bug will be the death of me

Thanks for the response, Ryan. I'll change the code and will wait to see if more issues pop up.

does the gift certificate "have" to be used when there is money remaining on it. is it possible to allow the user to decide if they want to use it or not on a per order basis?

Currently yes, the amount is automatically deducted at checkout; but I think ideally (and this is how our old system ran) you could "choose" to pay with your gift certificate just as you would choose PayPal or Credit card, etc.

Even more ideally, I think, would be a text field for a code, which would then free up the "users to certificates" relationship. Maybe that's not an ideal situation, but I can see why some shops would not want to restrict it to users who exist in a database (like a free promotion period where a bunch of certificates are printed and distributed to potential customers).

Haven't seen TCS on here in a while and I'm not sure what his plans are for this module. (Or if something like it is being considered for inclusion in Core?)

I just started monkeying around with Ubercart last week and today was the first time I looked at the gift certificate module. Everything seems to be going pretty smoothly except when I opt to use a gift certificate on checkout, it shows me the correct Total, but it seems to be sending the Subtotal (before gift certificate applied) to Paypal. It also seems to do this for the latest Coupon module I've been testing, so maybe this isn't exactly related to this module. I was just hoping someone might have an idea of where to check

Yeah this is not so much a bug, as it seems you need to setup your PayPal settings to "send the entire order as a single line item" in your Payment Methods config.

That should fix it. (I'd like to find a more permanent fix that involves being able to send the entire order line-by-line to PayPal but I don't have much time to devote at the moment ... hopefully TCS can look into it when he has a moment!)

Yup, that worked a dream. Thanks much!

Installed and successfully tested. I love the way you've done away with gift certificate codes! Thank you!