Hi zmove - hmm, haven't been able to get it to work yet. When I apply a coupon in checkout, it just sits there trying to apply and nothing happens. Still troubleshooting to see whats up. I also got a script error when I created a coupon in Firefox - box popped up asking if I want to stop script that was running continuously. The coupon did get created though. This does look very promising though. Will report back on more if I can get it functioning. Perhaps I didn't completely uninstall the first module, but thought I had.

-Aaron

Maybe try to clean your previous module.

As I said, I change some things in the database and I didn't had time to make an update and test in the .install file.

So this module is not compatible with the previous one. You have to disable it and uninstall it (remove tables in the database).

After install, I didn't find the admin options that would allow me to set up a coupon.

.... 10 min later .....

Oops, I found the coupon admin under Customers admin.

Hello, thank you for the coupon system. We have tested it today and it is working nearly perfect! One small thing: I can't see the cupon deduction and the name of the cupon on the invoice or on any other message from the system.

update: the cupon is shown at the checkout and applied but not shown in the conformation window.

Strange...

Some small questions :

• Did you install the module on a clean ubercart install (no update of the previous coupon)
• Did you theme your confirmation page or your invoice
• Did you tried to change the weight of the coupon you applied ?
• Do you have an online sandbox where I can reproduce the problem ? (you can send it me by PM)

- Haven't used the coupon system before.. clean install
- Haven't themed the confirmation page
- Yes, have changed the weight to try, but nothing changed
- Not really, will send you.

------------
I have a second installation of an older version of my entire system (there are less modules active) and it was working out of the box. I'm now trying to reproduce.

------------
Copied everything from the server to the local machine and everything was working.
------------
Tried it on a second server. What I found is very easy

the module is not compatible with php4 and needs php5!

great work updating the coupon module, before I install it over my current Coupons module, do I need to run the Drupal update script afterwards?

now some questions/suggestions:

Is it possible to make a coupon code valid only for one item? Or free shipping? That way we can have promos like "enter code XXXX to receive this product for free".

Also, since there's already an expiration date for coupons, any ways to make a "starting date"?

I installed coupon 1.3 and tried to create a coupon. When I clicked save, I was taken back to the list of coupons, which was still blank, and I got an error notice that said "Sorry coupon could not be added. Try again"

I have tried 6 times. Does anyone know what's wrong?

to 2shortstories :

For coupon to apply on one product, I want to add that soon. I think I will make a catalog browse with ubrowser. That's why I asked some documentation to Ryan on the forum.

For the starting date, it could be added pretty easily, but it's not my priority at the moment.

to somatics :

Some people seems to have problems on PHP4 install. Do you run your website on PHP4 ? I'm looking for somebody to test and debug the module on PHP4.

I'm running PHP 5.2.4.

Thanks for the update. I had the old plugin installed and removed it to install this version. I've tried uninstalling and reinstalling a few times, but to no avail. Any ideas?

Make sure the coupon table created in the database are removed after uninstalling the module.

If yes, make sure you have PHP5, PHP4 installation, for unknown reasons seems to have problems.

checked on php4 and it is not working.

I found that the uc_coupon table is not being created because my MySQL (I have version 4.0.27) is throwing an error like "You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near character set utf8 ".

The uc_coupon.install file has a db query that creates the uc_coupon table. In that query are a few lines where have "character set utf8".

You can create the table manually following what's in the query or remove all the "character set utf8 " instances and run the query and it will work fine.

I removed the text and ran query. The table created fine and it works now.

UTF8 may not be enabled by default with some versions of mysql (ie multibyte tables). So you'd need to turn that on at the server level before tables can be created supporting UTF8.

I would love to see the ability to limit the coupon to specific product classes. As it is, I have created a new gift certificate class (for the gc module), and I don't want the discount to apply to these products.

I could get this to work with the "coupon on one product" functionality you describe above (as long as you allow multiple products, not just one) but limiting it to the product class would be ideal for me.

I'm working on 1.5 that allow to apply discount only on specified products.

edit : the 1.5 version will contain product restriction. You will be able to select products and attributes for which apply a discount. A product class restriction is not planned ATM because I don't need this functionnality at the moment and my boss didn't give unlimited time to work on this module.

It will be tweaky, but you will be able to select all products of your class one by one (could be long, but it will work).

Howdy,

When I added a product condition to my first coupon, I was getting PHP errors both on the page that lists the coupons and at the product listing page related to the 'attributes' array. I deleted the product condition, installed the attributes module, re-added the product, and both the errors went away.

Thus, I believe the attributes module should be a required module for this, but it is not, not as of version 1.5.

Cheers,

Shiraz

Ok, I will add the attribute dependency for the next release. Thank you for your report.

I am using beta3 and uc_coupon 1.5. My site is also running on PHP4.2.11. It correctly calculates the coupon discount on the checkout page. However, it does not apply it either on the Review Cart page nor is it transmitted to Paypal payments. The payment is requested for the original amount BEFORE applying the coupon.

For the review page, check if the coupon you defined have the same weitght than another line item.

For the paypal problem, I don't use it, I don't have paypal account try to see in others modules how variables are passed to paypal to apply the discount.

The coupon does not have the same weight as another line item. The checkout page correctly calculates and shows the coupon discount. The review order page does NOT show the coupon discount. It disappears. I am using Ubercart revision 791, Drupal 5.6, and Coupon 1.5. I also am using flat rate shipping.

I have also tried specifying payment by Paypal and other. Doesn't matter. the coupon discount is correctly calculated and applied on the checkout page and disappears on the review order page.

I tried another website I am developing which is currently using Ubercart revision 748, Drupal 5.5, and coupon 1.5. Also using flatrate shipping. Same result.

Thanks for creating this module I really need it. The only problem is I'm getting an error when I test it out. It responds with undefinedundefined = undefined under the get coupon button. Any ideas?

to seedseller & josie says:

I don't know what could be the cause of your problems. Could you create me a sandbox where I could reproduce the bug ?

pm me the link if it's possible.

I don't know what that is. The site isn't currently being advertised until Friday the 1st. Here is the link.
http://www.3clothingco.com

Hi,

A sandbox is a copy of your website with a temporary admin account in which I could reproduce the bug. with just a customer account and without knowing the coupon code, I can't help you...

The issue turns out to be a small omission:

On line 655 of uc_coupon.module the & was missing from the $arg1 parameter.
function uc_checkout_pane_coupon($op, &$arg1, $arg2) {

Just edit your own module and make this change to have the coupons work.
I had the exact same issue, and decided to investigate and figure out the problem.

The $arg1 was being modified in the function, but as it was not being passed by reference, the value never gets back to the calling function.

Great module!

Cheers,
Gord.

Wonderful!!!

I was trying to get this high enough on my list to check it out. In version 1.5, my editor tells me that the change is on line 1029. Works well with beta five EXCEPT that there is a rounding error.

Applying a 10% coupon to a product priced at $129.95 correctly gives me a $13.00 discount. When I go to the review page, the discount incorrectly shows a $12.99 discount. It is only a penny, but for some customers it could be a deal breaker.

Greetings,

Everything with this module works great, except for one critical problem.

Every time I try to add a restriction to a coupon and hit submit the screen goes white and I get this error:

Fatal error: [] operator not supported for strings in /home/site/public_html/sites/all/modules/uc_coupon/uc_coupon.module on line 341

What can I do to fix this?

TIA,
txcrew

For the next month, I will not have time to maintain this module, so, I would appreciate that you point me problems and try to post the solution, I will continue to update the module if I point that it's a real issue.

I will try to post the 1.6 during the march month.

First off, my question: How does this contribution differ from the Gift Certificate Module?

Now my feature request: Is it possible for you to implment something in the notification area where the admin of the site is notified if someone makes a new coupon, etc.? The person who I am working for wanted to know if there was a feature to let him know if new coupons were created or given out to users, since he is going to possibly be handing store administration off to another user/worker.

Thanks!

regarding the line 341 question..I fixed this by changing:

TO

* Modified 03/21/08

user warning: Unknown column 'max_user_uses' in 'field list' query: INSERT INTO uc_coupons (cid, name, code, value, type, status, valid_until, max_uses, max_user_uses, users, roles, minimum_order, weight) VALUES ('1', 'Promotional Code', 'Promo2008', '10', 'price', '1', '1213938000', '0', '1', '', '', '10', '0') in [path]\includes\database.mysql.inc on line 172.

I've updated to the latest. I'm thinking about just adding the field myself. Thoughts? This would be a great module - I feel that it should be included with UC's core (or something like it.... that works)

The code below is the table creation script from coupon installation--
Perhaps see what may be missing from your database and add it in.
(May be when update script was run, it did not add the necessary new fields (I don't know what version you had before- so just in case.)

You can also delete the table and run the following script.

The "gift certificate module" that I used have an ablity to specify who (by email) can use the gift certificate (and also who it is from). Visitor will have ability to buy the "gift certificate". Also it seemed to only allow the certificate to be used *once*.

Coupon have more flexiblity - and you can also define your own "coupon code", specify products to be used, number of times used (or unlimited), etc...

Correct. Gift Certificates are for a specified amount for a specified user. Coupons can be used by multiple users a select number of times (or whatever configuration you like) and the amount can vary based on whether you are doing a percentage or dollar value.

FYI-

When installing this for the first time, you may need to modify the script (I had to ...)

uc_coupon.install's function uc_coupon_install() to be:

`{uc_coupons_products}` - the single quote around this caused a problem in my install.

I seem to be having problems with the product restriction function. Mainly that mine shows up blank! I am using uc_coupon_1.5 and Ubercart 5.10 beta7. The only different thing i can think about my site is that its in a subdirectory. Ie its not installed into www.prodseminars.com, its www.prodseminars.com/courses . However this has never been a problem before. I also just started getting this error:

warning: Invalid argument supplied for foreach() in /public_html/courses/includes/form.inc on line 949.

Any ideas? Im racking my brains here. Thanks !

Hi,

I work on beta 6 and the module works, It seems the beta 7 break something in the module.

I don't have the beta 7 and I don't plan to install it, It breaks too much things (VAT, coupon etc...) I will wait for the first release of UC working on drupal 6 and I will make an huge upgrade of my website at this moment.

Zmove, Drupal 6? That's a long way for me and I'm sure most of the Ubercart community. I have a live site using Ubercart and D5 and I'd love to get coupons working for the next version of our website, which will most likely also be on D5 (unless all of the dependencies get updated in the next few months).

It's strange that updates between two beta versions would break that much stuff? Do you have a dev server you can test the new builds on? Perhaps the bugs you are talking about got fixed (or will get fixed) in latest bazaar code?

Im kind of at my wits end about this, and I need to get it up and working for a client by the weekend. Has anyone had any problems going from Uber 7 to 6? Any other possible solutions? Thank you everyone for your help!

Hmm If I can't wait for a D6 version I will wait at least the 1.0 release to be sure if I make changes to the module, it will be for a pretty long time.

I finished the project for my client that needed the coupon module, ATM, I have a lot of work but none of them are commerce website, that's don't justify I work on it so and ATM I don't have enough free time to do it after the work.

So the next time I will be able to improve the module is when the 1.0 release of UC or when D6 will have enough module to be used in a production environment.

Thank you, dropping the table and re-adding it worked

I got this error when attempting to edit an existing coupon to work for just one item in the store.

This is line 172 in /home/rofl/public_html/includes/database.mysql.inc

I've installed your module to my website. But, when trying to add new coupon, I always get the following errors:

What should I do to fix this problem?

FYI, I have uninstalled the previous version of this module and delete the table from database (I can only find the table that related to this module in the "System" Table) before installing the current version.

Thanks a bunch.
Dedy.

Sounds like you are using PHP version less than 4.3.

http://us.php.net/mb_substr_count

mb_substr_count

(PHP 4 >= 4.3.0, PHP 5)

mb_substr_count — Count the number of substring occurrences

I think that a modification should be done on uc_coupon_add_form function

Under $form['general']['code'] the length should be restricted:
'#maxlength' => 14,

Without this restriction, you can create coupon codes bigger than the checkout form accepts.
The database field of the uc_coupons table should be reduced to 14 too, but this is a more delicate change.

Hello,
I do not think coupons are being applied properly with Ubercart 1.0-rc2. More information about my Drupal/Ubercart install is here.

Thank You!

For torgosPizza,

I've checked my php and found that my php version is php 5.

What should I do with those codes? Should I add them to some table in my database?

Thanks.
Dedy.

@BlindWolf,

Confirmed: coupons not being applied/carried over when going from Checkout to Review Order page. On Checkout page it shows the discount but going forward, no. I am using 1.0-rc2 with uc_coupon_2.

I would be willing to help sponsor the finalization/fix of this EXCELLENT module (the improvements are great). We're a bootstrap startup, low on cash, and need it for prominent blog sites that want exclusive coupons for them to promote us. I'm willing to help if a few others can go in with me to defray the cost and get this sooner than later. Let me know, BlindWolf, or anyone else willing to get this going NOW (I can do this only if others can help). Send me private msg, or in comments(?). Thanks, team.

Hi guys,
Yes, I believe the person I am setting this up for would be willing to help. I can see what he wants to do with this. He does have an on-site programmer, but he's sorta overloaded as it is. All I can do is throw cash at the issue. How much is needed?

garym contact me in PV for sponsoring, I will talk to my boss and stay him informed.

Thanks for responding zmove. We (and I'm assuming that means the whole Ubercart community as well) appreciate the fact that you got back to us in a timely fashion. Let us know how we can help.

Around line 1029 is the start of this function.

Change it to read like so:

Adding the ampersand is what is needed as the code is unable to modify the $arg1 to set the coupon code.

Cheers,
Gord.

Our on-site programmer said to add $products = array[]; on line 335. We needed to do this as we were getting an error when adding a coupon with all attributes to a product when one of the attributes for that product was a text field.

I dunno if this will help anyone, but it helped us.

By the way, when you get the error it does make the coupon successfully, but it just won't show the main coupons page correctly.

Hi,

First off ..... thanks for this awesome module. All works fine for me after a bit of tweaking. However, can someone point me in the right direction?

When i check my products, the summary page shows the correct price but when i click on a specific product i get the price flashing up for a half second, then it shows price undefined. I'm not getting any error messages so don't know where to look!

Any help much appreciated!

www.test.perfect-match.se/products

Cheers

J

I've seen the same thing with prices. It has nothing to do with the coupon code. For me, it was that I had defined some attributes in uc_attribute, but didn't enable any of the attributes for the product.

Hope this helps.

Seedseller,

Thanks for the tip .... have disabled the ajax attributes module and yes, everything works now .....
However, i get the following error message although shipping/coupons and checkout all function correctly.

Know anything about this? ( Like what should be in uc_coupons_products???)

Thanks

* user warning: Table 'mooringstar.uc_coupons_products' doesn't exist query: SELECT * FROM uc_coupons_products WHERE cid = 1 in /home/mjrcc/domains/test.perfect-match.se/public_html/includes/database.mysql.inc on line 172.
* user warning: Table 'mooringstar.uc_coupons_products' doesn't exist query: SELECT * FROM uc_coupons_products WHERE cid = 1 in /home/mjrcc/domains/test.perfect-match.se/public_html/includes/database.mysql.inc on line 172.
* user warning: Duplicate entry '0' for key 1 query: INSERT INTO uc_coupons_orders (cid, oid, code, value) VALUES (1, 8, 'GBG001', 99) in /home/mjrcc/domains/test.perfect-match.se/public_html/includes/database.mysql.inc on line 172.

So what happens if the coupon actually allows for a 'free' product. Shouldn't it allow the purchase without sending a payment?

Can someone attach a recent version that contains the changes described in this thread? Thanks for any help you can provide.

The uc_coupon module page on Drupal.org has the latest versions of this module.

It's really hard, in my opinion, to follow threads like this to understand what the heck is broken or needs fixing. If you want to help fix this module it is best to post your issues in the uc_coupon issue queue on drupal.org. I'm starting to copy/paste things from here to there so they can be fixed in a structured manner and appreciate anyone else's help with that.

Greggles Drupal Articles

It would be really great to get this module merged into the original coupon module and have all issues tracked and cvs maintained through drupal.org. I am willing to put through patches to get this process done.

http://drupal.org/project/uc_coupon

Hi Blake, I took a look at your uc_coupon, applied all the patches, compared to d.org and it seems to work great!

I've also created the ability to negate products from inclusion of coupons.

Check out the uc_coupon page on drupal.org to get the patch:
http://drupal.org/node/252875

Yes, I have the same question: So what happens if the coupon actually allows for a 'free' product. Shouldn't it allow the purchase without sending a payment?

I want to be able to offer a 100% discount to comp my product. But the downloads and role assigns come on "complete" order. How might I work around this?

Dan

OK: I'll reply to myself here. I found that I can use the "other" payment method and then configure Workflow-ng to send me an email when the order is 0.00. The "free" coupon discounts 100%. So then I just have to go in and change the order status to "complete" and the download is available.

Dan

I've posted a free order contrib that uses some JS to switch to a free order payment method when the order total reaches $0. It only works in RC 2 or higher, though.

Have the module installed. Can not locate the 'how to' in regard to the below.

"Add product restriction, you can now apply a discount only on specific products."

No Product Restriction: Help

I seem to be having problems with the product restriction function. Mainly that mine shows up blank! I am using uc_coupon_1.5 and Ubercart 5.10 beta7. The only different thing i can think about my site is that its in a subdirectory. Ie its not installed into www.prodseminars.com, its www.prodseminars.com/courses . However this has never been a problem before. I also just started getting this error:

warning: Invalid argument supplied for foreach() in /public_html/courses/includes/form.inc on line 949.

Any ideas? Im racking my brains here. Thanks !

mach5_kel the error is caused because you don't have the catalog module enabled. the ubrowser needs the taxonomy generated by the catalog module

Did you enabled the attribute module ? If no, I think it's required.

Yes, attribute is installed. Thanks for the check.

If you would, tell me what is the path to find the location in which product restrictions can be checked off or enabled.

Looked at the instruction posted in the coupon module and there is no mention of where this item would be located. Having that information there along with the path to activate coupons would be a nice plus!

Thanks,

Jim

Hey everyone,

Sorry about continuing this thread but, I'm wondering how I would add a line(s) of code to this module in order for it to callback to the original subtotal and make the coupon take the discount take from the original subtotal before anything else adjusted the price.

See this thread for more information http://www.ubercart.org/forum/support/4710/discounts_and_line_items

Any ideas??

TIA,

txcrew

Just tried both versions (uc_coupon_1.5.zip (above) and uc_coupon-5.x-1.5.tar (from drupal.org)) and wanted to say that the one on drupal.org is the old one. The one you need to use is uc_coupon_1.5.zip.

It's pretty darn confusing to have contributions listed like this and I vote strongly for this to change. I believe contributions should be posted on drupal.org from the start so we can use the invaluable issue queue.

I think this module supersedes the one on drupal.org (please correct me if I'm wrong) so I think that this module should replace the one on drupal.org.

Thoughts?

Hi,

I'm sorry that these 2 versions confuse some people, at the time I improved this module I contacted the author to know if we could put efforts together, I never had responses, that's why I begin on my own. And, to not confuse people, I renamed the module name (Improved discount coupon VS discount coupon), changed versions 1.5 (at this time the module was in 1.1 if I remember well) and posted in ubercart instead on drupal (in addition CVS account is annoying for me that don't understand CVS at all ^^).

I contacted the author when I finished this module, no reply, and I saw, later, that he did an 1.5 version completly different of mine...

ATM, the module fit my need and I worked on another projects. Now, my main project is to upgrade the shop I for which I developped this module for D6, so, maybe I will need to update this module for D6, don't know yet. But if I do it, I will take a completly other name to not confuse people.

Hi Z,

Is their any chance you could help us with the below:

Hi guys,

We've now installed the latest Coupon Module provided by Zmove. On first inspection it's exactly what we need for group buys on our website. You can now base coupon codes on individual products. This means we can start a group buy with say a 15% discount, customers can come onto the site, add the coupon, get the discount and proceed to payment. This is where the problem starts.

With the example below we have added the item, gone to checkout without apply the coupon code, this is the price:

Order total preview:
Subtotal: £7.62
VAT: £1.33 (17.5%)
Order total: £8.95

We now enter the coupon code which gives a £1.00 discount, we click "get coupon" and the discount is applied, the site updates the total:

Order total preview:
Subtotal: £7.62
TTLANYARDGB: -£1.00
Subtotal excluding taxes: £6.62
VAT: £1.16
Order total: £7.78

As you can see that is correct, with the old coupon it based the VAT on the original total but now at this stage in checkout the price is correct and the VAT is also correct. But when you click review order it's goes back to the old problem:

Coupon discount: TTLANYARDGB: -£1.00
Subtotal: £7.62
Subtotal excluding taxes: £6.62
VAT: £1.33
Total: £7.95
Paying by: PayPal

As you can see it's now based the VAT on the original total and not the discounted total (VAT is £1.33 but should be £1.16). If you press back, re-enter the code and review order it updates it to the correct amount but we can't tell customers to do this. In basic it's taking the wrong VAT amounts.

Then if you click submit order you are taken to paypal where again it messes up. This is the total from Paypal:

Toy Tuning Lanyard/Keychain
Item Number TOY-TTL-002
Item total: £7.62
Sales tax: £1.16
Total: £8.78 GBP

As you can now see the paypal total is another problem. It hasn't applied the discount (-£1.00) but has then based the VAT on the discounted total. If look at the bolded numbers you should be able to see what is happening. It's so nearly there yet so far away!

If anyone can make any recommendations then please let us know. We've been trying to get this to work for over 3 months now and if we can't get it to work we will revert to the old way and manually collect payments. Group buys via the website would save us hours and hours of work. We really thought it was fixed now but after reviewing the order and checkout this is not the case.

Many thanks for your time.

Toby

Hi Toby,
did you have a chance to figure this out? I have similar problem and would really need some solution.
Thanks a lot!

There is a bug that affects both the original coupon module and this one (zmove's improved coupon module). See this thread for more details:

http://www.ubercart.org/forum/support/6239/customer_can_complete_checkou...

It removes shipping and tax from the order when an invalid coupon code is entered. The order can still be completed.... that's bad.

Attached is a patch for zmove's version.