4 replies [Last post]
rak
rak's picture
Offline
Internationalizationizer
Joined: 11/07/2007
Juice: 310
Was this information Helpful?

This is the output of the l10n marker error checker:

- Invalid marker content in ubercart/uc_reports/uc_reports.module:32 * t("The following are total orders, products, sales, and average order totals for each store customer. Clicking on the header links will toggle a descending or ascending order for that column. Clicking on a customer's name will take you to a detailed list of orders that customer has made. Clicking on a customers username will take you to their account page.$order_statuses")

- Invalid marker content in ubercart/uc_reports/uc_reports.module:34 * t('The following are all products listed in the store, their amount sold, how many times it has been viewed*, revenue they have produced, and gross they have earned. If you do not see the number of views you must enable the %module_name module on the module administration page.'.$order_statuses,array('!module_url'=>url('admin/build/modules'),'%module_name'=>'statistics'))

- Invalid marker content in ubercart/uc_reports/uc_reports.module:36 * t("These are the sales for the last two days, average sales for the month, and the projected sales for the rest of the month. Further down the list you will see other sales statistics.$order_statuses")

- Invalid marker content in ubercart/uc_reports/uc_reports.module:39 * t("This is the monthly break down of sales for the year !year_number. Clicking on each link will take you to a list of orders during that month for the year.$order_statuses",array('!year_number'=>$year))

- Invalid marker content in ubercart/uc_roles/uc_roles.module:310 * t($comment,array('%role_name'=>_get_role_name($role->rid)))

--
RAk

spuky's picture
Offline
Joined: 01/31/2008
Juice: 80
Re: beta6 marker errors

Just to make that clear this are Places In the code where the Author of the code meant to make the Strings translateable but didn't that good of a Job.

So you may wan't to rewiew those Lines.. most of them should be easyly fixable..

And thanks for careing for all the international Ubercart users.

Lyle's picture
Offline
AdministratoreLiTe!
Joined: 08/07/2007
Juice: 6846
Re: beta6 marker errors

Just so everybody knows, when you use t(), the string you give it must be a single string literal. No PHP variables, no concatenation (the . operator), and no escaped quotes (\' or \"). That last one is particularly bad because I often use contractions, or have to quote something in the string. Line breaks are OK, but only when they're used in HTML where they will be ignored. A newline in the <title> tag isn't pretty. Cool

rak
rak's picture
Offline
Internationalizationizer
Joined: 11/07/2007
Juice: 310
suggestion

Isn't there some kind of text parser to find these mistakes? It'd be useful to check before releasing, otherwise every release will need a 'fix' Eye-wink
--
RAk

Ryan's picture
Offline
Joined: 08/07/2007
Juice: 15438
Re: suggestion

Yep, I found out about the Coder module in all its glory through the Drupalcon. We'll be using it on all our code from here on out. Smiling