RC4 - Old Bug back on shipping option select

Posts: 79
Joined: 10/29/2007
Bug Finder

I just installed Rc4, and now when I pick a shipping quote the totals at the bottom have the quote from the prior selection. So if UPS is default, then it comes up on bottom in review, but if I click the usps button, the rate still shows UPS, then when I pick cust pu, it then shows the usps quote. I think this was fixed a couple of months ago, but it has resurfaced.

Jim

Posts: 3744
Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

I don't even remember this as being an old bug. Sticking out tongue Is it possible you've got JS cached in your browser that's screwing up?

Posts: 79
Joined: 10/29/2007
Bug Finder

It's working fine in Firefox, but not in iE7

Here's the new site, it's in test mode, but you can try for yourself if you like
www.vlfit.com

Posts: 79
Joined: 10/29/2007
Bug Finder

Here is a link to the old thread when this was happening

http://www.ubercart.org/forum/bug_reports/1711/have_click_shipping_metho...

Posts: 3744
Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

Awesome, thanks for digging that up. We duplicated the problem on the Livetest in IE7 and will hopefully have a fix soon.

Posts: 1850
Joined: 08/07/2007
AdministratoreLiTe!

I am stumped. The only thing I can think of is that IE's JavaScript implementation is really screwed up when recognizing events. Thank God for Firebug, to let me know what Firefox thinks is going on.

I think someone is going to have to call in a real jQuery guru on this one.

Posts: 949
Joined: 08/14/2007
Bug FinderEarly adopter... addicted to alphas.Getting busy with the Ubercode.

How about John Resig, the creator of jQuery?

http://twitter.com/jeresig

(Turns out he's a RiffTrax fan.) Smiling

--

"Pain don't hurt." - Dalton

Mike Nelson's RiffTrax! www.rifftrax.com

Posts: 79
Joined: 10/29/2007
Bug Finder

Any progress on this one yet. I noticed that when I installed the authorize_CIM module, I had the screen tell me that I needed to pick a shipping option, but I know that the default USPS option was selected via the radio button, and I'm wondering if this is related to this issue.

Posts: 1850
Joined: 08/07/2007
AdministratoreLiTe!

It turns out that I was right. IE doesn't fire onChange when you click on radio buttons, but waits until you take focus elsewhere. After wresting with uc_shipping.js, I was surprised to learn that I could just replace the change() with click(). I was concerned that it wouldn't fire the event if someone used the keyboard to select the shipping option. My concerns were unfounded, and onClick works even better than onChange for dealing with radio buttons.

Revision 1075 has the fix.

Posts: 79
Joined: 10/29/2007
Bug Finder

Lyle, I jsut Bazzard the latest code the the click event got fixed, but USPS is not showing up on my shipping pane now, and it's selected everywhere it should be. Any ideas?

Posts: 1850
Joined: 08/07/2007
AdministratoreLiTe!

I guess double check your settings. I haven't changed anything with USPS lately.

Posts: 79
Joined: 10/29/2007
Bug Finder

I don't need a fix, but I thought I'd let you know that when I rolled my site back to RC4, the USPS came right back to the pane.