Ubercart

The voodoo code from the reports.module file, from the uc_reports_sales_year callback function:

for ($i = 1; $i <= 12; $i++) {
// Calculate the start and end timestamps for the month in local time.
$month_start = gmmktime(0, 0, 0, $i, 1, $year) - $timezone_offset;
$month_end = gmmktime(23, 59, 59, $i + 1, 0, $year) - $timezone_offset;

// Get the sales report for the month.
$month_sales = _uc_reports_get_sales($month_start, 'month');

// Calculate the average order total for the month.
if ($month_sales['total'] != 0) {
$month_average = round($month_sales['income'] / $month_sales['total'], 2);
}
else {
$month_average = 0;
}

// Add the month's row to the report table.
$rows[] = array(
l(gmdate('M Y', $month_start), 'admin/store/orders/search/results/0/0/0/0/0/0/'. $month_start .'/'. $month_end),
$month_sales['total'],
uc_currency_format($month_sales['income']),
uc_currency_format($month_average),
);

// Add the data to the CSV export.
$csv_rows[] = array(
gmdate('M Y', $month_start),
$month_sales['total'],
uc_currency_format($month_sales['income']),
uc_currency_format($month_average),
);
}

===================
I suspect the glitch comes about from these lines:

$month_start = gmmktime(0, 0, 0, $i, 1, $year) - $timezone_offset;
$month_end = gmmktime(23, 59, 59, $i + 1, 0, $year) - $timezone_offset;

the 2nd line seems to reference a day 0 on the next monh (which could be month 13 when the $month_start is in December..) so what does gmmktime do with a 0 day and a 13th month, would be the question here.. =)

Would the 13th month show the first month of the next year..?

Since the time zone not being set DID cause things to display in the next month, is there a better way we can call those functions so things don't jump a whole month if the time zone isn't set? =)

-Myke