-No Name- on orders if using delivery address as primary address

14 replies [Last post]

Wed, 09/19/2007 - 07:41

kulvik

Offline

Joined: 08/14/2007

Juice: 336

Hi everyone

One of my customers always send their invoices together with the actual product shipment. Therefore they don't want to use the Invoice address (only the shipping address). That works fine, except that the order lists on /admin/store/orders/view show "-No Name-" instead of the customer name (see screenshot), so they have to click on each order to see the name of the customer. Just a small thing, but it would be nice if this could be fixed

Obviously, the choice made on the /admin/store/settings/store/edit/display should be reflected everywhere in the store. Also on the order lists.

Thanks!

______________
Best regards,
Thomas Kulvik
Ny Media AS
www.nymedia.no

Preview	Attachment	Size
	screen_order.png	24.91 KB

Wed, 09/19/2007 - 09:16

#1 View page

Lyle

Offline

Joined: 08/07/2007

Juice: 6846

Re: -No Name- on orders if using delivery address as primary add

When I switched my test site over to display the shipping address, I only saw "-No Name-" on a couple orders that didn't have shipping addresses. How has your customer set up the shipping address and billing address checkout panes? From what I can tell it looks like it's working the way it should.

Thu, 09/20/2007 - 01:10

#2 View page

kulvik

Offline

Joined: 08/14/2007

Juice: 336

Re: Re: -No Name- on orders if using delivery address as primary

I have deactivated the billing-pane in checkout as they only want to use the deliveryaddress. I have also set deliveryaddress as the main address for orders. When deliveryaddress is set as primary it should use it as primary throughout the entire store. Also on order lists in store admin and so forth

______________
Best regards,
Thomas Kulvik
Ny Media AS
www.nymedia.no

Wed, 09/19/2007 - 12:49

#3 View page

wojtha

Offline

Joined: 09/12/2007

Juice: 39

I have had similar problem ...

In my case I need shipping adress only and -No Name- at all of my orders irritated me little bit .

At first I though that it this can be set by Primary customer address switch (variable uc_customer_list_address). Unfortunately this setting is used only in uc_order_token_values and then in the store module but not in the uc_order_admin which generates Orders view.

I think that this settings can be applied even in the uc_order_admin, it's only small change in the SQL query. Alternatively shipping_name can be used if billing_name is empty. What do you think Lyle/Ryan?

---
Anyway thanks for your work guys, I like your approach and the flexibility of the ÃƒÅ“bercart!

--
Vojtěch Kusý
Lead Developer
AtomicAnt Ltd.

Wed, 09/19/2007 - 13:22

#4 View page

Lyle

Offline

Joined: 08/07/2007

Juice: 6846

Re: I have had similar problem ...

But it is used in uc_order_admin(). Line 819 of uc_order.module alpha 7c.

Wed, 09/19/2007 - 13:55

#5 View page

wojtha

Offline

Joined: 09/12/2007

Juice: 39

Re: Re: I have had similar problem ...

Cool, I see. That's exactly what I was thinking about I have been using alpha7b ...

I didn't expect so big progress. 7b -> 7c +200kB of code... nice

--
Vojtěch Kusý
Lead Developer
AtomicAnt Ltd.

Thu, 09/20/2007 - 00:24

#6 View page

raddy

Offline

Joined: 08/31/2007

Juice: 127

Hi Lyle Me too experiencing

Hi Lyle

Me too experiencing similar problem.
I don't need to enable Shipping and Billing Panes,
Cos we are not selling any shippable products.
Instead showing No-Name When Shipping and Billing Panes disabled, can you gimme code snippet to inherit drupal user account name?

Thu, 09/20/2007 - 11:33

#7 View page

Lyle

Offline

Joined: 08/07/2007

Juice: 6846

Re: Hi Lyle Me too experiencing

kulvik, I don't know why it's not getting the name from the shipping address. It works on our sites.

raddy, I think that's a good idea to use the account name when neither shipping or billing address is available. To do that, add this line before line 835 of uc_order.module:

<?php
  $user = user_load($order->uid);
?>

And then on line 839, change t('-No Name-') to $user->name.

That should probably only be done when both address panes are disabled. I'd rather see that the customer didn't enter a name on their order, so I know to ask them for it.

Thu, 09/20/2007 - 14:33

#8 View page

kulvik

Offline

Joined: 08/14/2007

Juice: 336

Re: Re: Hi Lyle Me too experiencing

I'll try to do some debugging later tonight to see if I can figure it out

By the way: Will the changes you wrote about in your previous post be implemented in the dev version? If so, i'll download the latest svn version instead of editing the files.

______________
Best regards,
Thomas Kulvik
Ny Media AS
www.nymedia.no

Thu, 09/20/2007 - 14:37

#9 View page

Lyle

Offline

Joined: 08/07/2007

Juice: 6846

Re: Re: Re: Hi Lyle Me too experiencing

Not for a while. This is something I want to run by Ryan first since he maintains the order module.

Thu, 09/20/2007 - 16:11

#10 View page

kulvik

Offline

Joined: 08/14/2007

Juice: 336

Re: Re: Re: Re: Hi Lyle Me too experiencing

Ok, I see.I'll just put the changes in there manually until then

______________
Best regards,
Thomas Kulvik
Ny Media AS
www.nymedia.no

Mon, 09/24/2007 - 16:49

#11 View page

Ryan

Offline

Joined: 08/07/2007

Juice: 15438

Re: Re: Re: Re: Re: Hi Lyle Me too experiencing

Ok, I flagged this thread in my "Bugs that turned up during Drupalcon" list, but I'm not following totally. The setting to make the billing address the primary address seems to be working just fine on the Livetest. Then there was the idea to use the user name instead of -No name-. I'll probably make it "User: ", but then there's the issue of admin created orders that aren't attached to user accounts. I guess in that case it should just say "User: none". Instead of a full user load, I'm just going to do a simple select query... Thoughts? Is there even a bug in the current implementation?

Mon, 09/24/2007 - 17:36

#12 View page

kulvik

Offline

Joined: 08/14/2007

Juice: 336

Re: Re: Re: Re: Re: Re: Hi Lyle Me too experiencing

Well, I don't really follow on the user name stuff. I would just like this to happen:

If you choose to use the delivery address as the primary address in store settings, then that address should be used everywhere in ÃƒÂ¼bercart (all lists in admin section and so on..). Right now it tries to use the shipping address even when delivery address is set as main address and shipping info pane is deactivated from checkout. So no wonder that it sais "-No name-", because the shipping address isn't actually used and therefore have no actual value on the orders.

______________
Best regards,
Thomas Kulvik
Ny Media AS
www.nymedia.no

Tue, 09/25/2007 - 09:32

#13 View page

Lyle

Offline

Joined: 08/07/2007

Juice: 6846

Re: Re: Re: Re: Re: Re: Re: Hi Lyle Me too experiencing

So...maybe you should set the billing address to be the main one if you're not collecting the shipping address?

Basically, I don't understand how ÃƒÅ“bercart isn't honoring the settings for addresses.

Tue, 09/25/2007 - 15:59

#14 View page

kulvik

Offline

Joined: 08/14/2007

Juice: 336

Re: Re: Re: Re: Re: Re: Re: Re: Hi Lyle Me too experiencing

Ah, crap. I probably wrote the words shipping and billing so many times that I finally got crazy and messed up my description.

This is what's happening: I choose shipping address as the main address in ÃƒÂ¼bercart. I deactivate billing information pane in checkout. So the billing address is never set.

On all admin pages it uses the billing address no matter what I set as the main address. So that generates a lot of "-No Name-" stuff in my order lists

______________
Best regards,
Thomas Kulvik
Ny Media AS
www.nymedia.no

	User login
	Log in using OpenID: What is OpenID? Username or e-mail: * Password: * Remember me Log in using OpenID Cancel OpenID login Create new account Request new password

Ubercart

Navigation

User login