Ubercart

I found thiis bug in Ubercart 1.x, it could be in 2.x as well.

Description
When creating product adjustments, the combination of attributes are written to the database in a serialized form using the ordering field from both the uc_product_attributes table and the uc_attributes table in the uc_product_adjustments_form_submit() function. When attempting to retrieve the unique model number for a specific product adjustment in the _uc_attribute_alter_form() function, only the uc_product_attributes table is used ignoring the uc_attributes table. This can cause the serialized combination of attributes to be different if the default order for attributes is different than the product specific order of attributes which results in a failed attempt to look up a specific product model based on product adjustments.

The attached patch alters the SELECT statement in the _uc_attribute_alter_form() function to include the ordering field from the uc_attribute table when ordering product attributes.