Home » Forums » Ubercart » Development
3 replies [Last post]
Mon, 05/18/2009 - 12:21
regx@drupal.org
regx@drupal.org's picture
Offline
Joined: 10/30/2007
Juice: 98
Was this information Helpful?

Hello, I was just wondering if someone could review http://www.ubercart.org/contrib/10983 for me.
This is a patch that removes the payment options form from checkout if the order total is <= 0.

I know that there used to be a zero amount payment option, but didn't see a module for version 2.

This patch also adds the option to display product teasers in the product table and grid view. I am not sure why this option wasn't included as it seems like a common request.

I haven't done a lot of ubercart development and am not that familiar with the API, so I just wanted to get an opinion.
Thanks in advance, and thanks for all of your hard work on ubercart. I Love it!

Top
Mon, 05/18/2009 - 15:00
#1 View page
Ryan
Ryan's picture
Offline
Joined: 08/07/2007
Juice: 15438
Re: zero amount order

Briefly checked it out, and I will hint that you should check out http://drupal.org/patch/create on how to roll patches for Drupal modules. I don't quite recognize the format of your patch. Also, the UC Free Order module does need to be updated for 6, but it's not going away. I think its approach is necessary, b/c your patch doesn't take into account line items... what if the products were free but there was $5 shipping? There wouldn't be any way to pay for it. Smiling

I'll get my act together and try to update UC Free Order today or tomorrow... have a few modules that need updates.

Thanks for diving in, by the way! If you can re-roll your patch according to the standards I linked to, then it would actually make a very reasonable/valuable new feature. Cool

Top
Fri, 06/05/2009 - 07:40
#2 View page
regx
regx's picture
Offline
Joined: 06/05/2009
Juice: 2
Sorry about the patch

Sorry, I keep everything under SVN and following the instructions updates all of the CVS dir contents. So normally I just do a cvs diff modulename.
With all contributed modules in sites/default/modules it makes more sense to me to keep all of my patches in that dir so I can see what contributed modules I have patched.

I have made a lot of other changes since the last patch, so you can ignore most of this new patch. Mostly just stuff like fixing the tapir category listings and adding divs.

You are right about the line items. The client I created this for only has $0.00 downloads files so there will never be shipping. That said, I didn't realize that I wasn't taking line items into account because I didn't need to. So thanks for looking this over, your feedback is exactly what I was looking for since I am not nearly as familiar with this module as you are.

AttachmentSize
ubercart_product_teaser_and_0_amount.patch 30.89 KB
Top
Mon, 06/22/2009 - 18:46
#3 View page
victoria_b
victoria_b's picture
Offline
Joined: 03/28/2009
Juice: 30
Awesome

Ryan + regx,

Brilliant timing - I soooo needed this functionality. Great module and corrects one of those small issues that now just improves Ubercart's usability and flexibility!

Thanks

Top