Home » Forums » Ubercart » Development

DB-Inserts: quoting of fieldnames requested

Submitted by ragazzo on Thu, 01/17/2008 - 08:00
ragazzo

Posts: 12
 Joined: 01/17/2008

Hello guys!
I am currently working on a module that adds VAT-ID functionality to übercart. So I have added a field "VATID" to the uc_orders table.
Now I have realized that uc_order.module doesn't explicitely quote fieldnames when inserting data (line 2489):

db_query("INSERT INTO {uc_orders} VALUES (%d, %d, '%s', 0, '%s', '', '', '', "
."'', '', '', '', 0, '', 0, '', '', '', '', '', '', '', 0, 0, 0, '', "
."%d, %d)", $order->order_id, $uid, $order->order_status, $email, time(), time());

so i get an error (row count doesn't match...) after modifying table structure.

Perhaps it is not desired to alter existing table structures. Otherwise I would recommend to simply quote the fieldnames in the query.

INSERT INTO {uc_orders} (field1, field2, ...) VALUES (%d, %d, '%s', 0, ...)

regards
permalink #1 Thu, 01/17/2008 - 09:54
Ryan

Posts: 5367
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

Hmm... maybe both should happen. Puzzled

The general practice is to not alter the core table structure, so I haven't bothered to put field names in the inserts. I'm a little curious... can the data you're trying to store be put into the $order->data array? Or will you need to do selects/order bys on the column?

permalink #2 Fri, 01/18/2008 - 05:42
ragazzo

Posts: 12
 Joined: 01/17/2008

Hello Ryan!

A short explanation on EU-VAT-ID-system: If my customer is a company and thus has got a valid VAT ID, this number (e.g. ATU12345678) has to be annotated on every invoice. Hence this ID somehow sticks to the order/adress data and should be stored in the same record (to my opinion...).

The VAT ID has an influence on the calculation of VAT (->workflow_ng) and must be printed on various documents. There is no need to do selects/order-bys on that column. If it could easily retrieved from the $order->data array (newbee - not sure what this array does and where it can be accessed) this would doubtlessly be fine!

permalink #3 Fri, 01/18/2008 - 10:33
Ryan

Posts: 5367
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

Yep, it can be easily saved/loaded to that array, and Ubercart takes care of the saving/loading. In other words, if at one point I do this:

<?php
  $order->data['vat_id'] = 'ATU12345678';
?>

And the order gets saved, on subsequent loads, I can pull up that value with:
<?php
  $vat_id = $order->data['vat_id'];
?>

The tricky part will be collecting this from the customer at checkout and displaying it on order screens. For that you need to use the checkout/order pane APIs. You might look into the lead tracker contribution for example code.

permalink #4 Sun, 02/17/2008 - 17:20
ragazzo

Posts: 12
 Joined: 01/17/2008

Ryan, where do I assign these $order->data['vat_id'] values? I have tried to do it within my Implementation of hook_token_values() but my newly inserted values never show up when i do a print_r($order).
Which would be the perfect hook/function to write my data (retrieved from DB) to the array (object?).

permalink #5 Mon, 02/18/2008 - 12:25
Ryan

Posts: 5367
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

You should look into hook_order().

permalink #6 Tue, 02/19/2008 - 06:57
ragazzo

Posts: 12
 Joined: 01/17/2008

Ryan, you can't imagine how important your answers on my beginners'-questions are for me. Unfortunately they aren't as obvious to me as to an exerienced drupalist, but with each of your statements the whole system is getting clearer to me, and my enthusiasm grows. Thank you very much for your excellent work!

permalink #7 Tue, 02/19/2008 - 10:23
Ryan

Posts: 5367
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

No problem, man. There's a lot here to take in... the project has grown quite large over the last year. Sticking out tongue

Let's just say that your profile pic inspires me, too. Eye-wink I can't wait to have hair that long! (Although mine will probably be a poofy mess with curls/waves.)