 |
UbercartOne cart to rule them all... |
|
| Donate | Affiliates | Sponsors | ||
Fee based on payment method choice
Submitted by qrios on Tue, 08/21/2007 - 09:24
Hi, I have a project, where the shop owner wants to charge his clients a fee, based on their payment method choice. for example, paying by Paypal costs 4 euro, paying on delivery 10 euro. Is there an easy way of doing this in Ubercart? (or a less easy way) Thanks, Kees
It would also be nice to be able to add a discount depending upon payment method (i.e. 3% off of the total for paying with Cash or Cashier's check). Jeff Hey Guys. I'll give it a try this evening, cause I need this too. Give me a couple of hours. Stay tuned. Hi Michel, I hope I not crossed your attempts. I did get it to work, but indeed, I had to hack a core .js file. The situation is simple. The radiobuttons for paymentmethod choice in checkout, already have a "onclick" js event. They do not have a unique ID nor name (bug?) so DHTML is not posible (I think). Thats why I had to change the js function "function get_payment_details". Changes: /**Maybe there is a way to make this more like themable/hookable?? q_details var returns one value containing two concatinated strings separated by ||. I didn't see another way. The module is'nt ready yet, if it is, I will post here. Kees Hi Kees, I think I don't really understand what your function is doing I found a way to manipulate the uc_payment.module in such a way that you can add a value (e.g +4€, -3%) to every payment method. This Value is also shown as line-item in the checkout review. I think it should work. I'm actually not in the office. So I think I will post it ca. in 3 hours. greetings from germany Did I wrote 3 hours? I meant 3 minutes Here is the modified uc_payment.module. You can find the added code by searching the string "#mic". Just replace the old file and test it. Go in the store administration to "payment settings" -> "payment methods" and add some values for the different methods. Then it should work.. Check out the code, maybe you can use it for your module. I'm working with ubercart just since a couple of days, so this code is just alpha, alpha, alpha... Be carefully with it. add to function uc_payment_order: <?phpIt's to add the costs as a line item. (see picture) add to uc_payment_methods_form <?phpIt extends the form where the payment methods are listed. (See picture) Check also the attached file to see the changes in the theme_uc_payment_methods_form add to uc_checkout_pane_payment <?phpIt's to show the text behind the payment method. see picture) So, I need your feedback now.
Hi Mic and others, Sorry for late reply. I don't have time now to dig into your code. It's not ready, but functioning. For now it is a fixed fee, and uses a setting "variable_get('uc_'.$method_id.'_fee', 0)", for example uc_paypal_ec_fee where the fee value is stored. The admin form to adjust the fee is missing! I'm sure I can use your code to extend this module or the other way around. I'll get back on this! Kees
Awesome work everyone! I'll consider putting this into core, as it's been requested almost as long as we've been making releases. I don't want to add too much complexity, though... what does everyone else think? My thoughts: Yes, please, in core would be just fine I realy like the "one page checkout" Ubercart provides. But digging into this matter I can't help to think that it would be a lot easier to have more steps like :cart>Shipping>paymentmethod>adress+checkout. It would make things like this a lot easier.. but he, the easy way isn't always the best. Note: I'm a bit concerned about the Javascript reliance of the method I used. I would love to make it work, I don't have time for it the next two weeks though... Kees Hey Ryan. It would be cool if you can add it. In the script I wrote I add the Line with the cost of payment like this <?phpThat works. But when I view the order (after submiting) as Admin, I can't change the values (like, i.e, the shipping cost). Do you know what I mean? Can you give me some help? Just a hint which functions I shpuld use... thanks. In order to edit it, you can probably just change 'Cost of Payment' to 'generic'. That second argument should be the ID of a line item type that is editable, and my hunch here is that isn't happening. Since it's all internal, you should be able to get by with a generic line item. Otherwise you'll need to use hook_line_item() to add in a line item type to mimic the generic definition: <?phpHey, cool it seems to work with <?phpand some other changes. I can send you an updated version in the next days if you want? Yeah, send it to me when you get a chance and I'll try to test it out/add it in. It may take me a few days to get that done, though. Still trying to catch up. Could you post your version here please? In the module I posted, I use a session var to remember the chosen payment method Thanks, Kees You can load the order based on the session variable cart_order. It will have the chosen payment method stored in it by then. Hi Michel, Ryan, rest of you, I did complete my module sort of, with a lot of help from Mitchels code. (So I found time after all It's a standalone module (no PHP hacks) to make it work in the checkout page (not only in order review) you have to hack uc_payment.js according to included readme file. The module supports adding and multiplying, per enabled payment method. If you need f.e. 3% discount, simply multiply by 0.97 . Admin settings available in the payment method section under 'Method Fee settings'. I need your feedback on this please. Regards, Kees
Hi Kees. That's good. greetings Hi Michael, sorry for misspelling your name. You're right, I didn't test past the 'order review' page, I think I see where I went wrong, wait a sec... Thanks, Kees Hi. I found the mistake. Mic Here is the improved file. I did it a bit lighter. But there is one (big!) problem. If you change the method fee settings (the values), every order is updated. That's something that shouldn't happened. Any ideas?
Please try again. Attached is new mod.
Oops, crossposted yours. Gonna try! Hi Michael, I looked through your code, your change is basicly the same as mine if I'm correct, I had old code in hook _order, refering to a non existent sessionvar. Please look at my module, it has a few improvements and moved a bit more structure. Regarding the problem of updating all orders, I really don't have a solution to it, thanks for pointing it out. Regards, Kees
I'll check it this night. The problem with the updating of all orders: This is a problem of the most modules (Shipping Cost etc). That's why I asked this: http://www.ubercart.org/forum/development/504/stored_true_hook_line_item We will see. Mic Latest mod.
Hi Kees. I checked this yesterday. Maybe you want to fix that. Otherwise we can take mine. It works correctly I think. greetings Are you sure you have the latest? It works fine here... strange. (7b) Kees Anyway, I created the contribution here: http://www.ubercart.org/contrib/748 Feel free to make adjustments or provide feedback. Thanks, Kees I tested the current uc_methodfee0p6 version with UC alpha 8, and it seems to be somehow working. Anyway, I couldn't get the uc_payment.js hack working. I have Credit Card, COD and Method Fee payment methods enabled. At checkout, when it comes to the 'Payment Method', only one method can be selected. It is supposed, as configured under 'Method Fee settings' at 'Payment Methods', that a certain price must be applied when COD is selected ('The fee value for payment method: cod: ...). If I choose COD at checkout, I get the correct fee at the review order screen, however -if I select Method Fee-, no payment method at the review order screen seems to have been applied. Has anyone tested this contribution with the current Übercart's version? Thanks =) The discriptiont text says something like 'don't display this as a payment method', please uncheck Method Fee as a payment method. I should review the module, it shouldn't be available as a payment method. Since no one seemed to need this module (except you now), I did not care much about it. Regards, Kees I posted some code for testing at... Can't we combine efforts here? Yeah, that would be cool. I'm running into some problems that you might have already dealt with and taken care of, like how to represent these discounts/fees during the checkout process. I downloaded your contrib, but I wanted to try to implement something that was simpler to use on the admin side. Instead of creating a new module, I hacked up the existing payment module but tried to keep things straight forward enough that it might be added into core eventually. If you get a chance could you take a look at what I did? I think we should be able to look at different aspects of our code and come up with a nice solution for this issue. OK, lets do that. Have you looked at 'mine', and do you have suggestions on what to combine? Ryan has taken some of the code that I wrote, meant to be added to core, and put together a nice contrib module that adds payment method fees/discounts. If anyone wants to test it out and post any issues/suggestions you can find it at http://www.ubercart.org/contrib/2184
|
|
. What is the correct way to detect this when I'm in "hook_line_item"?(in the review order page)
)
Joined: 08/13/2007