5 replies [Last post]
zmove's picture
Offline
Bug FinderEarly adopter... addicted to alphas.Getting busy with the Ubercode.Internationalizationizer
Joined: 08/13/2007
Juice: 1192
Was this information Helpful?

Hi there,

I notified an Ubercart behavior that is a little annoying when you begin to have a lot of orders every day in your store.

When a customer go to the checkout page, there is a temporary order that is created with the incomplete status. This is a very good idea that ubercart implement that, it allow to see what customer tried to order but didn't finish and it's possible to send them a mail to try to help them to order.

the problem is that when a customer make an error on that checkout page (for example forget to fill one required field), another order object is created and so, when the order is complete, don't remove the previous incomplete order.

So, the problem I have is that I have a lot of incomplete order whereas the customer complete the order, I often have, for a customer an incomplete order of #order_id and a complete order of #order_id + 1. So, for each incomplete order, I have to check if a complete order exist and, if yes, remove the duplate incomplete order.

I think it's not usefull to keep that incomplete orders, incomplete order only should be "true" incomplete orders, so customer that really stop order process.

What's your opinion about that ?

Ryan's picture
Offline
Joined: 08/07/2007
Juice: 15438
Re: Incomplete order not updated when customer make error on che

I definitely agree that it shouldn't be working like this. I'm curious if it's been fixed lately, though. I changed the way validation was working w/ orders in the betas somewhere, and looking at the code it seems like once a cart order has been set it won't duplicate. Are you running the latest beta code, and if it's not possible to update at this stage can you compare your versions of uc_cart_checkout_form_validate() and uc_cart_checkout_form_submit()?

zmove's picture
Offline
Bug FinderEarly adopter... addicted to alphas.Getting busy with the Ubercode.Internationalizationizer
Joined: 08/13/2007
Juice: 1192
Re: Re: Incomplete order not updated when customer make error on

I'm running on the beta 5 and the 2 functions I have are the same than in the baazar repository

Ryan's picture
Offline
Joined: 08/07/2007
Juice: 15438
Re: Re: Re: Incomplete order not updated when customer make erro

Well, I guess I'll do some further investigation then. Eye-wink

Ryan's picture
Offline
Joined: 08/07/2007
Juice: 15438
Re: Re: Re: Re: Incomplete order not updated when customer make

I did some extensive testing and never reproduced this bug. Without leaving or completing checkout, I left different required fields empty or proceeded to review and came back and tried again. It never duplicated an order.

One possible source of your problem is people may be abandoning the cart... like if an error shows up they may actually leave the checkout page then come back through to checkout. In this case, their previous cart order would be abandoned.

chadcrew's picture
Offline
Bug FinderGetting busy with the Ubercode.
Joined: 12/28/2007
Juice: 195
Re: Re: Re: Re: Re: Incomplete order not updated when customer m

Also, if you're using the Secure Pages module, make sure that all your cart paths secure. Otherwise the Secure Pages module will cause a redirect that nullifies the referrer_uri, causing ubercart to create a new order.