10 replies [Last post]
frankstallone's picture
Offline
Uber DonorEarly adopter... addicted to alphas.Not Kulvik
Joined: 08/08/2007
Juice: 211
Was this information Helpful?

This may be a design question that is not of dire importance however maybe someone has some insight on what is going on here. Oldskool Industries Catalog page moves it's text below the background color in Firefox but not in Internet Explorer. I have tested and tried a few things however I have come up unsuccessful. Now I have no updated to the newest version of Ubercart, I am running Alpha 7C and Drupal 5.2. I just realized there is now Drupal 5.3 as well and I am going to test some upgrade options tomorrow on a sister system for this site.

Anyone have any ideas? Is this possibly something in the design that was fixed in Alpha 7E?

Lyle's picture
Offline
AdministratoreLiTe!
Joined: 08/07/2007
Juice: 6846
Re: Firefox / IE difference on the Catalog page

It's got something to do with the line-height property on the <span> containing the links to the subcategories. I think I've got it cranked down too small for the font size, so the text is spilling over. IE and Firefox are unsurprisingly treating this case differently.

I'll play around with it and see if i can do something better.

frankstallone's picture
Offline
Uber DonorEarly adopter... addicted to alphas.Not Kulvik
Joined: 08/08/2007
Juice: 211
Re: Re: Firefox / IE difference on the Catalog page

Hmm thats interesting as I too have attempted to override the line-height of the categories there without success so far. I think if I add images to each of those it does the same thing in FF.

frankstallone's picture
Offline
Uber DonorEarly adopter... addicted to alphas.Not Kulvik
Joined: 08/08/2007
Juice: 211
Keep me posted...

Let me know if you make any discoveries today; I will be updating Drupal, Token and Ubercart on oldskools page. We'll see how well that goes! =D

WesleyTx's picture
Offline
Bug Finder
Joined: 09/14/2007
Juice: 89
Re: Keep me posted...

Try looking in the HTML instead. There's an empty div inside each table cell. Remove those and I bet your problem's solved. Smiling

Edit: Never mind. Firebug fooled me.

WesleyTx's picture
Offline
Bug Finder
Joined: 09/14/2007
Juice: 89
Re: Re: Keep me posted...

OK, think I've got it now. In uc_catalog.css, line 58:

td.category span {
font-size:x-small;
line-height:0.2;
}

Try overriding that element's line-height. (Which should also have a unit, incidentally.)

Lyle's picture
Offline
AdministratoreLiTe!
Joined: 08/07/2007
Juice: 6846
Re: Re: Re: Keep me posted...

I've fiddled with the line-height a bit, and I came up with 1.3em. How well does that work for a default value?

frankstallone's picture
Offline
Uber DonorEarly adopter... addicted to alphas.Not Kulvik
Joined: 08/08/2007
Juice: 211
Perfect!

Lyle,

1.3em is an absolutely perfect solution. Glad you guys really nailed this issue!

frankstallone's picture
Offline
Uber DonorEarly adopter... addicted to alphas.Not Kulvik
Joined: 08/08/2007
Juice: 211
rubbing my eyes

So I upgraded Oldskool to Beta 4 (or 3 the jury is still out on this) and it appears the IE/Firefox Catalog box issue came back. Did the new code not get passed along to the new Betas? Or is this an issue with my programming/design (I'll take credit if it is although in IE the page renders fine)?

EDIT: I upgraded the site to Drupal 5.7 and Ubercart Beta 4 (or 3).

Lyle's picture
Offline
AdministratoreLiTe!
Joined: 08/07/2007
Juice: 6846
Re: rubbing my eyes

Must have slipped my mind or something. It's still 0.2. I'll make sure that gets committed this time.

frankstallone's picture
Offline
Uber DonorEarly adopter... addicted to alphas.Not Kulvik
Joined: 08/08/2007
Juice: 211
Re: Re: rubbing my eyes

Thanks Lyle I appreciate your checking it out. =)