 |
UbercartOne cart to rule them all... |
|
| Donate | Affiliates | Sponsors | ||
State/Zone field is required when Not applicable.
Submitted by ricecooker on Fri, 01/04/2008 - 02:55
OK, this could be another bug or something. When a user When they click Review order, its asking for Not applicable yet required? Eh :|
You can make State not required. Not the best solution but it works.. admin/store/settings/checkout/edit/fields Good point... not really sure what to say here. Do what tP recommends and I'll put it on the todo list of things to fix come beta. Yep thanks, unchecked the Required for the State/Zone. It will have to do. Well, pleasure to lend a hand in finding those small errors. Is there a reason to make the field disabled whenever there are no zones and Not Applicable shows as the only choice? I removed the code that disables the field and everything seems to move through the system ok with -1 being stored for the zone code. Attached is a diff that does that (along with take out some whitespace in the code), but my test cases are pretty limited so I'm not sure if this would create other problems.
Disabling it is really just a design decision so that customers don't see the N/A message and still click on it. I decided instead to just trick the forms API during the validation process to make that field not required for validation purposes, and it appears to work great. I added these lines after line 242 and the corresponding bit for the billing pane: <?phpThat's a nifty trick. Form validation in Drupal still confuses me fairly often, but seeing the placement of that clears a small part of it up for me. <?phpGreat stuff. I just noticed this for New Zealand, and Singapore... Where would I make these changes please? I am not too sure what zone is but I am assuming its like county in the UK. However when I select surrey(in zone) I get SRY rather then Surrey. And its on the same line as the postcode. It might be an option when UK is selected the right settings are made. BTW Ubercart... I think you guys have got something cool here. I really think it will be big! Where would I make these changes please? After line 242 in uc_cart_checkout_pane.inc, but these fixes are in the latest releases. Just to be a pest, I'll put in my bid to have that logic branch assert a textbox so user can type in a Province name of their own. My marketing director wants that feature badly enough to offer a bounty on it's head Sorry to drag up an old topic here but.... I live in South Africa so our definition of a zone would be province. The .cif is loaded for SA and the 'Zone' has been renamed to 'Province'. When the customer gets to the point where they need to fill in details for delivery address, Province/Zone is greyed out and unselectable. Only once the customer has clicked 'Review Order', they are told 'An illegal choice has been detected.' and the Province combo box is now highlighted in red and selectable. I thought that perhaps this could be an issue with the South African .cif file so i disabled it and tried out Germany's. Same result. There is another way i discovered to sort of get past this issue and thats load another .cif file but even when I do that (which I dont because I'm not ready to ship to surrounding countries as yet), the user still needs to drop down the combo box and select South Africa (although it is selected by default) to make the Province combo box selectable. If you wanna have a look yourself: http://www.stormsolutions.co.za/cctv. Guest checkout is enabled. Thanks in advance and a huge thank you to Ubercart developers for what you have done here Hmm... are you running the latest version of Ubercart? I was pretty sure I squashed this one, though it could always be related to your default store country. Check your store's address settings at /admin/store/settings/store/edit. Im actually not running the latest. Im running 5.7. Sorry I didnt mention this earlier. Thanks Ryan, No worries... actually, 5.7 is the latest Drupal version. I'm curious about your Ubercart version. We're up to 1.0 beta 7 now. If you're not on beta 7, then you may should look into updating, but just do Ubercart (and not Drupal 6 - Ubercart doesn't support this yet). aha! Ok! That makes sense! Ubercart version is 5.x-1.0-beta4. Will update Ubercart instead then Updated to beta 7. Zone combo box is still not selectable Same problem here, with United Kingdom. Zone field says "Not applicable" until I click "Review order". i haven't got this problem in beta 6. Same problem here, with United Kingdom. Zone field says "Not applicable" until I click "Review order".
Ubercart version is 1.0 beta 7 i haven't got this problem in beta 6. Exactly Interesting... did you double check your store country in the contact settings? Interesting... did you double check your store country in the contact settings?
Sure did...Country says South Africa and is selectable but Province/Zone says 'Not applicable' and is greyed out just like it is on the checkout page step by step to the problem: (with Canada + US already installed) Zone field is blank. another bug: above steps+ BUT if I disable US (not remove) update: (beta 7) Hmm... yeah, this issue was raised before of finding a better way to establish the default country. I'd like to see what would happen for Dogmatix to go submit that page even if he doesn't change anything. That may solve the problem... Haha! Fixed! I pretty much followed what egyember did and its now working just fine! I have a suspision that not all of the above steps are required to fixed the problem. Thanks guys! Your input is greatly appreciated. Glad it's working. I actually added a default store country function that I didn't get a chance to commit before leaving work. It'll be in core tomorrow morning. No one else should have this problem from now on. sorry, those steps were just to show how i got to the bug. Well, I'm committing a change as I type that should prevent this from happening in the future. If the variable that stores the default store country references a country that's no longer in the database, it will grab the first available country ID or simply return 0. thank you Ryan! we all appreciate your help. We are running Beta7 and are testing the checkout process. I have tried removing US and Canada, adding other countries but the zone is always disabled. Its like no data is getting loaded for the zone. Something get dropped in beta7? Update from our log: when attempting to import the country cif file.
|
|
Joined: 01/02/2008