 |
UbercartOne cart to rule them all... |
|
| Donate | Affiliates | Sponsors | ||
Tax problem: prices are inclusive tax
Submitted by coworks_dieter on Wed, 02/20/2008 - 11:47
Dear all, We have a problem with the Ubercart. Our client is entering his prices inclusive tax into Ubercart. At the checkout we have to exclude the tax from the product price and separate product price and taxes. After a lot of searching, downloading, trying, ... we still don't have a good solution. Is there anyone that can help us? Thx Dieter
I have the same problem. For germany it is only useful to show product prices including tax and at checkout the total amount of taxes included. I tryed to solve this with the 'add tax to product price' contribution (http://www.ubercart.org/contrib/1532) which should be generally the right solution but this code is not working with ubercard beta5. You get a blank screen when adding a product to the cart. best regards My suggestion has only sense if it goes into core, but I think there it belongs. Targets: These changes go into uc_store.module (beta5): Configuration: old (around line 1548): <?phpnew: <?phpnext three little functions I needed. <?phpThe $decimals thing to get a value 0, 1 or 2 in uc_currency_format() could be written different, but I would prefer that the program replaces 5.00 $ by 5,- $ and 5.5$ by 5[uc_currency_dec]50$. In beta5 it is line 1963, <?phpwith <?phpThis are all changes necessary to uc_store.module. The rest is to replace a couple of uc_currency_format($value);by uc_currency_format(uc_add_tax($value));By totals or subtotals I added the tax before to the items to prevent rounding issues. Based on beta5 I found 13 places to add uc_add_tax() in 4 files: - line 357 fromuc_cart_checkout_pane.inc one change: - line 37 fromuc_catalog.module one change: - line 1138 fromand finally uc_product.module 7 changes: - line 1158 fromSorry for the long post, but I think it is needed in more countries and as I think any site selling to end-users. "Sorry for the long post, but I think it is needed in more countries and as I think any site selling to end-users." Thanks for your effort, I really think these or similar modifications should go into core, since we need them in most european countries. Thanks a lot! Best regards and thx Please make that Core!!! all European users will "Say thank YOU !!! and praise you ...." Spuky Thanks a lot for your support @Jürgen: I was busy all day and need to clean up my uc_store.module a little. Will post the 5 files as soon as it is done, Al So here are the 5 patched files based on beta5 just containing the changes mentioned above. There is one changed behavior also without configuration: 5.00€ are converted to 5,-€, which I would like to get, but this is just a suggestion. You have to configure one or two values: Below is "Mode how to display tax:" so with the second you change the display behavior for product teasers, products, cart block and cart. Best regards,
  This sounds like just what I've been wanting to look at for awhile. I'm in Australia and we have GST, which is probably sort of like VAT, but not as complicated. GST is supposed to be included in the price, and then on the invoice, show the amount of GST included in the price. My problem has come when thinking about discounts. The discount needs to be applied BEFORE GST is applied. I haven't had time to take a look at your solution above, I will try it out when I get the chance, but will that work with any coupons or discounts as well? Thanks a lot for all the work on this, it has definitely been a difficult point. I tried to create a module, but there are points where I just get stuck because there are just changes I can't make through a module to get it to work. Cheers, Wow ! This looks cool I hope to have the time to implement it today or this weekend. I'll keep you informed. Thx a lot ! Greetz Dieter I am going to check that out today... gonna report back.. Spuky It is working pretty well... Since the actual tax ammount is displayed far down in the payment part it is a little irretating.. Nice work!!! I just have to repeat my wish to get that into core as soon as Possible... Is there any reason you put that into the currency format settings.. we might want to find a more Inuitive place for the setting maybe in the tax settings. Spuky The discount needs to be applied BEFORE GST is applied. I haven't had time to take a look at your solution above, I will try it out when I get the chance, but will that work with any coupons or discounts as well?
This is a good question VAT in Germany is the same so the discount question is Important for germany too. Spuky @spuky: Thank you for your report! Is there any reason you put that into the currency format settings.. No - I needed a configuration value, so I dropped it for the moment just where I have been... The place to put it should be up to Lyle or Ryan About coupons or discounts: This is a different topic. This little function uc_add_tax() (as I used it) doesn't change anything on the Übercart logic. It is just a configurable option if to display the taxes in certain places or not. The input in the edit form still expects values without VAT! For this topic (add prices incl. VAT/display prices incl. VAT on edit - but save prices without VAT) I hope to find this weekend time to write a small contribution. @Lyle: As a module IMO this would be a big thing what could be solved in core with a few lines. You could make all Europe & Australia happy if you tell me what I have to do/change that this can go into core I found another Issue with your Patch that needs to be taken care of: under the tax setings there are "Taxed Product Types" If you introduce Product Types to do diffrent tax settings for example in Germany Books are sold with 7% VAT but CD's are sold with 19%. Your function is just adding all taxes onto the price so I end up with 26% tax added to the displayed price.. I realy wan't this to go into core but It should work as expected... so we have to figure that out really well. Spuky after having to solve my 2 taxrates problem I investigated th module: http://www.ubercart.org/contrib/1532 (v1.2.1 again and it is working well for me... I investigated the code and realized that is realy checkin for Product Types... and if the tax should be added to them... but in the hook_nodapi() hook if ($node->type != 'product' && $node->type != 'bucher') { to read like this and now it is adding 7 percent on my bucher type and 19 on my products types. does anybody know how that could be changed so that the hook_nodapi would get all the nodes that are product nodes (since omparing type is not working...) that would make this contrib module far more usable... so maybe lyle or ryan could coment on that Thomas The way product types have been checked for a long time is <?phpHowever, I added a new hook to Übercart last week so you don't have to rely on that function from uc_product. (Somehow it was being called before the module was enabled, which breaks things.) The new way to do things, pending the next release, goes like this <?php  Hi, I'm on ubercart beta 5 with my "add tax to product price" module and it works perfectly. I forget to include the .info file, and maybe made another stupid error when I zip my file, so I did it again (oops) ^^. Let's try the last 1.2.1 version I posted and give me feedback. I'm not sure if this was just a problem I ran into with the 'add tax to product price' module or what, but I found that once you then went to the checkout screen, the tax was once again not in the price. So although it worked on the other screens, once it got to the checkout screen it showed the products without tax, and then added in the tax below. Is this still the case, or did I just have an earlier version? Cheers, Hi,
I'm on ubercart beta 5 with my "add tax to product price" module and it works perfectly. I forget to include the .info file, and maybe made another stupid error when I zip my file, so I did it again (oops) ^^. Let's try the last 1.2.1 version I posted and give me feedback. Hi zmove It is working great just not if you introduce Product clases but this is just one line of code.. in the the function how uc_taxes_price_nodeapi only change from if ($node->type != 'product') {to if (!in_array($node->type, module_invoke_all('product_types'))){since übercart has the possibility of product types with difrent tax and you module would just catch the native product ones... but this code will only work with beta 6 or higher since see lyle's post above... Spuky So although it worked on the other screens, once it got to the checkout screen it showed the products without tax, and then added in the tax below. Is this still the case, or did I just have an earlier version?
This is still the case and would be my only whish beside my above change that I have to the module right now. beside hooking the cart also hook the checkount pane... beside that I can say your module version 1.2.1 is also working well on beta6 so far... Spuky I think the unfortunate part is the reason why it wouldn't be working on the checkout screen is because without modifying core, it can't be done. I tried to take elements of this module and create a specialized GST module, and that is where I ran into the problem as well. I could not get it to show the product with the tax included, and just show the amount of tax included, without re-adding in the tax. I don't think there is a way to switch a line item from being calculated to being display only. Maybe I'm wrong and someone can clear this up? This whole tax thing has really been the most difficult part for me using Ubercart. I think it is a great shopping cart but just getting it to work for Australia has been difficult. I originally wrote the GST module for very simple needs, and then tried to update it to work with the current tax system, but it just breaks at the checkout screen and I can't seem to find any way to make it work. I can't say that I know Ubercart inside and out though, so maybe there is a way to do this without modifying core, but I certainly can't figure it out. At the moment I don't have a client asking for it, so I can't pay the guys to work on it, but when I get a client in needing that functionality, I'd be willing to donate some money to the cause to finally working this issue out. Cheers, Hi All, I was on holiday just for one week and I'm impressed about this thread grows. Many Thanks for your answers and help. I see that this tax issue is a general problem for many unsers. For me the version from Al (display_tax_beta5.zip) works perfect, just at the checkout-page at top the wrong price without VAT is displayed within cart-are. This may could be fixed easy. This solution of Al is really nice! Is it possible that this one goes into core? PLEASE PLEASE... Well you see, this tax-problem is a big issue for many countrys and should be included into core function as soon as possible! Thank's and best regards from cologne/germany I've found another general bug in tax calculation. Currently Ubercart calculates the Total amount with the formula [Total = (Productprice1 + Productprices2 + ... ) + Tax]. This is wrong and should be [Total = (Productprice1 + Tax1) + (Productprice2 + Tax2) + ....]. Because of this error, the total amount of ordering x products is not always x * Productprice becaus of rounding errors. See this thread for details: best regards So the real problem is that there is more than one time to round the tax amount. Übercart is actually calculating the tax per product, but it doesn't round the total amount until the end. I'm reluctant to change anything yet. If working on Übercart has taught me anything, it's that everybody does taxes differently. Yes, full agreement with what Jürgen tells, the European way is to calculate taxes per product. And if you try to support currencies like the Czech koruna, which is counted in half units, the difference is nearly on every order a couple of full currency units. In my little wild shot in the dark more up in this post I still had no idea about how workflow-ng and uc_taxes are working now. Now I already understand what I still don't understand. I think I can figure it out, just time is a little rare ATM... But I am willing to help to solve this topic. @Lyle: Could you point me into a direction what would help you? This topic is really serious for us in Europe. So the real problem is that there is more than one time to round the tax amount. Übercart is actually calculating the tax per product, but it doesn't round the total amount until the end. Yes thanks Lyle - That's the problem! But this is an general issue for every country. With current tax calc, a customer totally will pay different invoice amounts if he buy a product in an amount of 2 in one order or if he buy a product twice in two orders!! That should be fixed as soon as possible. Taxes have to be rounded per product always! The other part, how to display taxed product prices, can be done with the solution described by AL e.g. I have the patched Al display tax from beta5 to beta6. Please see enclosed file.
 In the US, the proper way to calculate tax is to apply the rate to the order total (as is currently done), NOT to each item individually. If there are different requirements in Europe, perhaps the best thing to do is modify uc_taxes to offer a menu option on the form at admin/store/settings/taxes/edit to select how the tax is applied. This will be part of display_tax_beta7 as both ways are needed. I am not a professional coder, so on another point I would need some support: workflow_ng_invoke_event('calculate_tax_'. $tax->id, $order, $tax, $account, array());Could somebody please list me just the required steps to turn this from $order base to $node? The condition to get me started would be to compare variable 'uc_store_country' with the tax country condition. Yes, I was reading the handbook pages up and down, tried to create events, conditions and whatever I founded in ubercode and yes, I don't understand it. But it seams possible, as even if I just manipulate $order it is working - except ignoring the conditions - so all taxes are applied and even checkout is not messed up. Whoever takes the time to give me a direction - a biiiig thank you in advance! This will be part of display_tax_beta7 as both ways are needed.
I am not a professional coder, so on another point I would need some support: workflow_ng_invoke_event('calculate_tax_'. $tax->id, $order, $tax, $account, array());Could somebody please list me just the required steps to turn this from $order base to $node? The condition to get me started would be to compare variable 'uc_store_country' with the tax country condition. Yes, I was reading the handbook pages up and down, tried to create events, conditions and whatever I founded in ubercode and yes, I don't understand it. But it seams possible, as even if I just manipulate $order it is working - except ignoring the conditions - so all taxes are applied and even checkout is not messed up. Whoever takes the time to give me a direction - a biiiig thank you in advance! Same same function uc_taxes_calculate($order)there should be changed the calculation of order by an iteration over all nodes within that order. But I'm also not a coder... thank you in advance! So at least I am still not conpletely alone We first should get the prices display right as this is the issue which brings us in conflict with laws. There are more places to change for tax calculation, but this is solvable. Best regards P.S.: Some helping hand with workflow_ng_invoke_event() would be still greatly appreciated Just one thing that popped up in my brain this morning... Maybe it is possible to add a tax integration with workflow on viewing product event. and the administrator would choose to add the tax to the product price, and add custom conditions as to check the user role or watever... Dear people, Thank you all for your work on this. I am a new user of Ubercart and this VAT (BTW) issue is the only reason I haven't activited my Dutch shop yet. As I am new to this, please don't kick me too hard when I ask stupid questions. I use ubercart-5.x-1.0-beta7 and I need two things: - Be able to choose a tax rate per product (19%, 6% and 0%). Can you please let me know the right combination of files I need (to download or edit)? Or will there be a complete 'patchfile' or something? Thank you for helping me out on this one! using the contrib of zmove and changing the folowing: in the the function how uc_taxes_price_nodeapi only change from if ($node->type != 'product') {to if (!in_array($node->type, module_invoke_all('product_types'))){since übercart has the possibility of product types with difrent tax and you module would just catch the native product ones... - now define 3 Product types... now you should be mostly done the only thing missing is that the cart view on the checkout page is not updated.. but others report that it is returning white pages (most times sign of low mem...) that is my solution which works on my server...(still not online german shop) I did install this version: Add tax to product price zmove Module Work in progress The tax rates I found on this page: The I have to go to: I can't figure out how to set the Product Types and asign the tax to them. I feel real stupid that I cannot find this... sorry.. admin/store/products/classes here ad a new class / produkt type... now when you edit your tax rates under : admin/store/settings/taxes you can define taxed Product classes.. yes it is not easy to figure that out.. be aware that you can't move Products between classes (at least not in the interface of course it is possible in the DB) which is a bummer when the only difference is the tax rate and you already have them in your shop .... Thanks for the Classes, found it and now I know it, this part seems pretty obvious. Just for the people who start looking for a file uc_taxes_price_nodeapi (just like I did in the beginning). The small change I have to made to: uc_taxes_price_nodeapi can be found in the module uc_taxes_price. The next step would be to add a new product. You should see the new product types (in my case 19%, 6%, and 0%). Just my small piece of help for the people who want to use this important change for Europe. Hello to all, Being an European, I'm having the above problems regarding VAT and foreign countries which I'm trying desperately to solve. This forum has helped me to shed some light over this matter and to realise that I’m not the only one with this problem. I’m using Drupal 5.3 and Übercart 5.x-1.0-beta7. So far I’ve downloaded and installed display_tax_beta6.zip. To finish the patching I need to change the function “uc_taxes_price_nodeapi” in “uc_taxes_price.module”. Well, I’ve searched the entire distribution for this file but it’s nowhere to be found… Can anyone help me with this? Thanks! Sbit Hello Sbit, first: display_tax_beta6.zip was a couple of changed files of Übercart 5.x-1.0-beta6 and it was not meant to work together with the contribution "Add tax to product price", so probably it will break things with beta7. This solution like I told would have been only the way if it would have gone to core. So upload Übercart 5.x-1.0-beta7 once more ore wait a few days, as I think rc1 is nearly out of the door. The discussion about "uc_taxes_price_nodeapi" is about the above mentioned contribution: http://www.ubercart.org/contrib/1532 Version 1.2.1 is quite old and has a couple of known bugs, but it is a starting point with the hack above. Also the attached files of http://www.ubercart.org/contrib/1532#comment-15562 contain some improvements. All of these solutions still don't address the issue of European per product tax calculation! (A rounding issue) Just that you know about. Another possibility is in a few days available as I will publish my module how to get things working for Europe. Best regards, Al Why price inclusive? Hello Al, Thanks for your prompt reply. I'll be waiting for that rc1 version of Übercart like a child waits for Xmas! Once again, thank you for your support. Over here I still am not 100% complete with the tax thing for Europe I would also love to see Santa bringing some presents early I am sure the Drupal Ubercart combination has incredible more potential than most other Online Shop script. Thank you all for making this work in near future! This would be a great for all European E-shops. Is there any news on this? Please keep us updated! I really butchered the e-commerce module to get this feature - so much so that I'm unable to upgrade the site from 4.6 and thanks to my less-than-capable coding, the cart has inconsistent billing! Really hoping that this can be rolled out soon as I want to rework the site using Ubercart! Of course, to get the attributes showing correct tax, there are three lines in uc_attribute.module with the function uc_currency_format() where the uc_add_tax() function has to be inserted. Line 725 Line 1473 line 1478 EDIT:
Maybe I looked over, but is there any solution for 'entering the prices inclusive tax'. In most countries I think shops give round prices, like €20 or €19,90. Then it ´s very handy. And I ´m also interested in the following: Somebody know how I can solve this... Thanks.
|
|
Joined: 02/20/2008