Problem with upgrade to 1.0 from 1.2

12 replies [Last post]

Mon, 07/28/2008 - 14:08

mimetic2

Offline

Joined: 08/07/2007

Juice: 478

Hi,

Recently upgraded to 1.2 from 1.0.

Went to update.php and nothing wanted to be updated (except for flatrate shipping). Anyway when i am logged in there are no errors but when im not logged in i get the following error:

Warning: array_merge() [function.array-merge]: Argument #2 is not an array in /home/ecopaper/public_html/modules/ubercart/uc_cart/uc_cart.module on line 457.

Any ideas?

EDIT: New problems found. When i tried to checkout with an email address i had previously used it just says "details will be disregarded you already have an accoutn" and wouldnt let me pass to the review order page.

Also after i changed details to a new email address, passed the review order page and then finally hit submit, i submitted the order, and then it kept me on the checkout page and put my orde rinto "incheckout" in the workflow status.

Edit#2: Tried to go to update.php and do a uc_cart update but there was no uc_cart to be found. Went to update uc_store and see if that worked. Went to update #4 and it said no queries were run.

Mon, 07/28/2008 - 15:00

#1 View page

Insurrectus

Offline

Spreading the word - Ubercart for president.

Joined: 08/22/2007

Juice: 364

Re: Problem with upgrade to 1.0 from 1.2

Same things are happening for us at hugamonkey.com, except a bunch of stuff was updated, like due to the upgrade from Alpha 8E. I had to revert back to my previous version! When I tested this upgrade it was with 1.0 and everything was working fine.

Credit card orders just create a loop like mimetic2 mentioned:

Also after i changed details to a new email address, passed the review order page and then finally hit submit, i submitted the order, and then it kept me on the checkout page and put my orde rinto "incheckout" in the workflow status.

I also had PayPal errors after successful order (see attached screenshot).

Attachment	Size
paypal-error.PNG	46.54 KB

Mon, 07/28/2008 - 15:18

#2 View page

Ryan

Offline

Joined: 08/07/2007

Juice: 15438

Re: Re: Problem with upgrade to 1.0 from 1.2

@Insurrectus: To be honest, I don't know why you're getting those problems w/ the PayPal module. It's like orders are coming through that aren't using line items at all, but there should at least be subtotal line items. In any event, I patched it to make sure we had valid arrays at those points.

@mimetic2: There was no update function to run and ideally won't be for minor updates. Manually specifying an update could lead to problems, so if there aren't any showing up it's just because we didn't need any.

Someone has already reported problems using 1.2 with LoginToboggan, and I've committed a fix that will be packaged up in the 1.3 release (I'm testing right now). I'm not sure where you're getting those other messages from... they don't even sound like core messages. Could it be a bad combination of contribs? There might be some trouble with a fix I applied to avoid using $SERER['HTTP_REFERER'], but it may have been an incomplete fix. I'm going to do some more testing.

Mon, 07/28/2008 - 15:46

#3 View page

mimetic2

Offline

Joined: 08/07/2007

Juice: 478

Hi Ryan- TOok off

Hi Ryan-

TOok off logintoboggin and then no longer had the array error, however when i went to checkout still had the same problem (goes straight to incheckout in workflow and doesnt go to order completed page just takes you to a blank checkout page).

EDIT: AAlso im not using paypal i am using the linkpoint module.

Mon, 07/28/2008 - 17:00

#4 View page

Ryan

Offline

Joined: 08/07/2007

Juice: 15438

Re: Hi Ryan- TOok off

Alrighty... think I had some movement on this with some help from thill.

It looks like an inappropriate check is in there that chokes when SSL is being used... but not when it isn't, which confuses me.

In any event, try opening uc_cart.module and remove everything between the following two lines around line 1658:

<?php
function uc_cart_checkout_review_form_submit($form_id, $form_values) {
  // Take out the order load and if block here.
  switch ($form_values['op']) {
?>

Please let me know if this solves it so I can commit. I hadn't been testing w/ SSL which is why this slipped through the cracks.

Mon, 07/28/2008 - 17:17

#5 View page

Insurrectus

Offline

Joined: 08/22/2007

Juice: 364

Re: Re: Hi Ryan- TOok off

I'll test this out this evening and let you know as soon as I can.

Mon, 07/28/2008 - 18:00

#6 View page

Ryan

Offline

Joined: 08/07/2007

Juice: 15438

Re: Re: Re: Hi Ryan- TOok off

If you could try this in conjunction with Lyle's fix here I'd appreciate it:

http://www.ubercart.org/forum/bug_reports/5748/version_12_bug_during_che...

Mon, 07/28/2008 - 18:51

#7 View page

Insurrectus

Offline

Joined: 08/22/2007

Juice: 364

Re: Re: Re: Re: Hi Ryan- TOok off

I tested both fixes and I was able to checkout. I placed Lyle's fix in the uc_store.module, replacing:

 if (substr($http_referer, 7, strlen($_SERVER['SERVER_NAME'])) != $_SERVER['SERVER_NAME']) {
    return FALSE;
  }

With

 if (parse_url($http_referer, PHP_URL_HOST) != $_SERVER['SERVER_NAME']) {
  return FALSE;
}

Lyles fix didn't seem to break anything.

Thanks for your prompt attention.

Mon, 07/28/2008 - 19:12

#8 View page

Ryan

Offline

Joined: 08/07/2007

Juice: 15438

Re: Re: Re: Re: Re: Hi Ryan- TOok off

Rock on. These are committed to Bzr, then, and we'll hopefully put 1.3 up tomorrow after some more testing.

Sat, 08/02/2008 - 13:40

#9 View page

j_ten_man

Offline

Joined: 03/07/2008

Juice: 78

Re: Re: Hi Ryan- TOok off

This actually messed up our billing process. I think that the uc_order_load() call needs to remain in here, because if not then the submit call does not work, because all of the payment methods are looking for the order, but instead get null. All of our orders were going to pending status with this.

Maybe I am missing something else, because I do not understand the order/payment process completely, but I am pretty sure that this change needs to be made.

<?php
function uc_cart_checkout_review_form_submit($form_id, $form_values) {
  $order = uc_order_load($_SESSION['cart_order']);
  // Take out the if block here.
  switch ($form_values['op']) {
?>

uc_cart.module,v 1.14.2.13

Sat, 08/02/2008 - 18:44

#10 View page

Ryan

Offline

Joined: 08/07/2007

Juice: 15438

Re: Re: Re: Hi Ryan- TOok off

You're correct... I put it back in for 1.3 as soon as I found the issue. Sorry this affected your site. Please go ahead and update, as some other issues with the patch that resulted in this error were also fixed.

Mon, 07/28/2008 - 19:59

#11 View page

thill

Offline

Joined: 01/25/2008

Juice: 815

Re: Problem with upgrade to 1.0 from 1.2

I am going to give this a thumbs up as well, tested latest bazaer after commit 1211 on three SSL sites. Completed orders on all three sites without a hitch. Thumbs up Ryan!

Tue, 07/29/2008 - 12:43

#12 View page

Insurrectus

Offline

Joined: 08/22/2007

Juice: 364

Re: Re: Problem with upgrade to 1.0 from 1.2

Ryan, when do you plan to release 1.3?

	User login
	Log in using OpenID: What is OpenID? Username or e-mail: * Password: * Remember me Log in using OpenID Cancel OpenID login Create new account Request new password

Ubercart

Navigation

User login