Home » Forums » Focus Groups » Ubercart.org

New Theme for Ubercart.org

Submitted by Ryan on Fri, 05/02/2008 - 14:57
Ryan

Posts: 6997
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

Alrighty, I've been tweaking the Pixture theme this week and am getting close to a switch from the current Ubertheme to this one. There's a little less blue, but there's a lot more content space and a sharper look. After I finish tweaking the generals about it, I'll work on a new front page and figure out what to do with the menus and such... our Navigation is getting a bit unwieldy, and judging by our Google Analytics site overlay, it's not very effective and connecting users to information. Eye-wink

So, I've given any logged in user the ability to switch their theme. If you don't mind, take a minute to switch over to Pixture and let me know what you think. If you like it, feel free to keep it on, though I know there are some rough spots in it atm.

Example feedback: I think that w/ the smaller node links I need to bring prominence to the Add new comment and reply links, especially for the forums.

I'm open to any fresh ideas on how to make the theme or the site in general a better place to congregate and promote the project!

permalink #1 Fri, 05/02/2008 - 15:34
torgosPizza

Posts: 1730
 Joined: 08/14/2007
Bug FinderEarly adopter... addicted to alphas.Getting busy with the Ubercode.

I like it a lot. I'll keep it on for now, and as I get deeper into it, let you know if I have any issues.

--

Wanna help send me to DrupalCon Paris? Or do you just like my work? Donate via PayPal!

permalink #2 Fri, 05/02/2008 - 18:54
Ryan

Posts: 6997
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

Thanks, tP. I'm getting more and more excited about it as I tweak it and bring the pieces together. I just installed Panels 2 and am working out a similar front page... this time hopefully a little more helpful for newbies and old-timers. You can check it out now, as I've set it as the site-wide front page. This won't affect the old theme, because it was using an override in the theme. Sticking out tongue

I'll be adding in some quick links like we had before, but not near as many and hopefully to more helpful pages. I suppose I'll also need to give the community page a facelift, so I'm open to any ideas.

Can't wait to get home and check out the colors on my CRT. Eye-wink

permalink #3 Mon, 05/05/2008 - 13:42
silverwing

Posts: 8
 Joined: 11/05/2007

OMG! Ubercart.org is all grown up!

Seriously, you now have a 'mature' theme that will reflect better on the product.

The forums as you know need a bit of work. (I don't think the blue works - but I'm using a monitor that's a bit broken [I don't see reds on it] so that may just be me. Adding icons to the "add new comment" "login" "quote" etc links would be nice (I believe that humans like to click pictures.)

I love the 'aquaish' header, too!

~silverwing

__________________________________
Land of Midnight online serial | Misguided Thoughts

--

__________________________________
Land of Midnight online serial | Misguided Thoughts

permalink #4 Mon, 05/05/2008 - 13:58
tonysb
Posts: 2
 Joined: 05/05/2008

I like the older one better. It was much more fitting the current Web 2.0 trends and showed Ubercart as a really cool product. The new theme (Pixture) looks a bit dated.

permalink #5 Mon, 05/05/2008 - 14:13
jsudesign

Posts: 91
 Joined: 01/17/2008

I agree, sorry guys. Is there a way we can choose our own theme in our account?

--

www.e-techcomputers.com

permalink #6 Mon, 05/05/2008 - 14:27
Ryan

Posts: 6997
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

Not sure about leaving both themes up... the old one overrode the front page manually, so there was really no way to customize it without directly editing HTML in the theme. That = no bueno. Also, other on-site configuration stuff (like blocks and some Views) would make it illogical to attempt to maintain two separate themes on a site.

permalink #7 Mon, 05/05/2008 - 14:53
tharemedy
Posts: 12
 Joined: 04/23/2008

I think the new theme looks tight.

permalink #8 Mon, 05/05/2008 - 16:03
thezombie@drupal.org
Posts: 1
 Joined: 08/19/2007

Overall the theme looks fine. One bug however, in Safari 3 the words in the main navigation have no space underneath them to separate them from the bottom line. Please see screen shot.

AttachmentSize
ubercart_safari_nav_bug.jpg24.67 KB
permalink #9 Mon, 05/05/2008 - 16:09
cYu

Posts: 349
 Joined: 11/19/2007
Bug FinderGetting busy with the Ubercode.

I'm a fan of the fresh look. I think at first glance this theme makes Ubercart.org look like a Drupal site, where the old theme was a little less obvious...but I don't consider that a bad thing. The homepage is going to be key, so I guess that will end up getting the majority of the tinkering. One idea I had that I'd find useful there is to see a logged in User's recent activity based on their Track page.

A lil' bug I noticed was at the top of the 'Installing Ubercart' pages. The top line of (for Ubercart beta & Drupal 5.x) is getting cut off for me in Firefox.

permalink #10 Mon, 05/05/2008 - 17:06
Ryan

Posts: 6997
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

Thanks for the bug reports.

@thesafari: I don't think I have the capacity to test locally in Safari, but if you can let me know what style tweak fixes it for you I'd be happy to implement it.

permalink #11 Mon, 05/05/2008 - 18:28
doomed@drupal.org
Posts: 144
 Joined: 04/05/2008
Bug Finder

Hey Ryan and all.

I dont like it. But i'll explain why to make this criticism of mine a little bit constructive.

As someone else wrote before (cant see who without clicking back on my browser - really hate that Sticking out tongue) the new template makes Ubercart look ... Uberdated.

And it's not the template's fault, because Pixture is nice. Just check this screenshot: http://drupal.org/node/250059

As you see on the screenshot using default "drupal colors", they dont contrast blue with more blue, they put blue against black. And then they have blue tonalities for the menus, etc.

On our case, we have orange on top, orange on the menu bar, more orange on the side menus, some brown on the links, and more orange on the footer. This is like a bad Tang commercial! Sticking out tongue

Blue is like the sea, the sky, coolness and stuff.
Orange and brown is like.. you know..

I'm not saying to ditch the orange color, just make it work against a good color, like gray or purple. Purple could work, maybe, if played well.

Blue is also fine. Actually, the Orange/Blue combo is on the Ubercart logo.

Give this baby some web 2.0 edge!

permalink #12 Tue, 05/06/2008 - 02:17
zmove
Posts: 558
 Joined: 08/13/2007
Bug FinderEarly adopter... addicted to alphas.Getting busy with the Ubercode.Internationalizationizer

I like both design, but I prefer the old one a little more. This one looks like the drupal.org site a little too much, the previous one was more original.

But you have to note a design with the usability too, so I need some time to have a real opinion about it ^^

permalink #13 Tue, 05/06/2008 - 03:49
Johnny van de Laar
Posts: 26
 Joined: 12/18/2007
Bug Finder

are there any plans of using the project module for the contributions. with the project module issues etc for a contribution would be much more structured

i've used the project module for an intranet site and it works pretty good imho

--

Byelex Multimedia B.V.

permalink #14 Tue, 05/06/2008 - 07:23
tom-d

Posts: 47
 Joined: 11/21/2007
Bug Finder

Thanks for the theme update Ryan, I like this theme a lot more then the last one. I only have one question, Do you have a non stretched logo? if not I can create a vector version of your logo to fix this and future problems.

permalink #15 Tue, 05/06/2008 - 09:37
Ryan

Posts: 6997
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

@tom-d: I've got a vector logo, but it is kinda blurry... I'd love it if you could sharpen that up somehow. PM me your e-mail address, and I can send you the file.

Regarding the Web 2.0 look... I'm actually not a big fan of it. I guess that's coming through in the design change. Eye-wink But I'm also not a designer, so I'm dependent on the best efforts of others and tweak as necessary. I'm actually using the blue Pixture theme on my blog, and I'm not sure it looks as sharp as that screenshot. I can pass around the modified version of Pixture I'm using if someone wants to give the primary links row color some love or toy around with other combinations. I prefer the black row w/ the blue theme, but it just didn't look right with the orange. Sticking out tongue

My main beefs w/ the 2.0 look are font size and wasted space. We simply couldn't get any info on the screen. For example, looking at the front page now vs. before, there's actually useful information "above the fold." Before in 1024x768 resolution, we had the logo, some unhelpful quick links (I say unhelpful b/c less than 1% of our visitors used them based on the Google Site Overlay), and the top halves of the news/forum blocks. Now there's actually a description of the project on the front page (a must) and room for a little more info and possible space for sponsor links or something.

So... still a work in progress, and keep those comments coming. Cool

permalink #16 Tue, 05/06/2008 - 10:36
tonysb
Posts: 2
 Joined: 05/05/2008

good points, but web 2.0 doesn't have to be useless or necessarily in the largest font sizes.... if you look at the CakePHP layout (http://www.cakephp.org/) except for the font size it seems to have more info above the fold than the old theme?

I mean, if there's no alternative available, usability seems to come first, but if the design doesn't look catchy, people might dismiss Ubercart as an older system like osCommerce and pass on trying it. All I am saying is that ideally a good marketing image should go hand in hand with good usability, but in case they don't, they should be handled like trade-offs. That means balanced, not one for the other.

But Pixture is good and with some more flashiness to it it should work.

PS: One more good web 2.0 theme - Drupal.org itself.

permalink #17 Tue, 05/06/2008 - 11:34
silverwing

Posts: 8
 Joined: 11/05/2007

I think it's important to remember that this is a business site and its purpose is to get information to people as efficiently as possible - even if it means it wont look ubercool.

People are here to learn about Ubercart, not to marvel in the sites css stylesheet.

~silverwing
__________________________________
Land of Midnight online serial | Misguided Thoughts

--

__________________________________
Land of Midnight online serial | Misguided Thoughts

permalink #18 Wed, 05/07/2008 - 00:49
mimetic2
Posts: 153
 Joined: 08/07/2007

I think the old one looked much nicer. That being said, this one has a much simpler UI.

permalink #19 Wed, 05/07/2008 - 04:47
Tanjerine

Posts: 85
 Joined: 08/31/2007
Bug FinderInternationalizationizerNot KulvikThe other woman.

oh wow! i not around for a few weeks and a new überlook greets me. Ü now, i've always said i love orange. so no question that i like the colors. but we seriously need to do something about the blue forums. it doesn't go. Sad and come to think of it, neither do the sharp forum corners -- they don't go with the nice rounded corners of the right nav.

but orange makes me happy. so im biased about the overall look. Smiling

--

i plurk.

permalink #20 Wed, 05/07/2008 - 09:06
Ryan

Posts: 6997
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

Good call on the blocky forums. I'd be happy to give them a facelift if someone has some CSS mojo to lend to the effort. Smiling

permalink #21 Thu, 05/08/2008 - 10:43
z3b

Posts: 20
 Joined: 08/15/2007

Looks really cool, just dislike the fuzziness of the UC logo in the top left corner. Keep up the good work.

--

http://www.studio-qb.com

permalink #22 Thu, 05/08/2008 - 10:47
Ryan

Posts: 6997
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

Thanks, z3b. Funny you should mention it... tom-d here from Polybonk sent me a sharp version that I'll go ahead and test/add in now. Thanks for the reminder. Eye-wink

EDIT: Added it in... but I guess that means everyone has to refresh to see it. Sad

EDIT 2: Maybe not... I added a query string. Let me know if it doesn't show by itself.

permalink #23 Thu, 05/08/2008 - 11:28
z3b

Posts: 20
 Joined: 08/15/2007

Looking way better, and your query seemed to do the trick, ie: didn't have to clear the cache to see the new version.

--

http://www.studio-qb.com

permalink #24 Fri, 05/09/2008 - 12:17
Abilnet

Posts: 272
 Joined: 12/28/2007
Uber DonorBug Finder

Congrats for the face lift! However, font size could be bigger? ...or is it just me suffering with eyes Eye-wink

permalink #25 Sat, 05/10/2008 - 16:57
henns20

Posts: 11
 Joined: 10/11/2007

hows panels 2 intergration with this theme working out?

I mention this because i had some issues with the sidebars getting pushed off the page on smaller screensizes.

permalink #26 Fri, 05/09/2008 - 16:29
psynaptic

Posts: 339
 Joined: 08/28/2007
Early adopter... addicted to alphas.Not KulvikTheminator

Hi Ryan, I'll have a go at improving the theme if you'd like.

--

Drupal Contrib API
Freestyle Systems

permalink #27 Wed, 05/14/2008 - 15:39
futurist

Posts: 57
 Joined: 08/08/2007

Font size in "Latest News" and "Recent Forum Activity" should be larger, like in the previous version. I do agree the icons on the previous home were not too useful and using valuable room, but other than that I think the previous design did a better job at conveying the Über-identity.

permalink #28 Thu, 05/15/2008 - 11:02
kaizen

Posts: 85
 Joined: 08/08/2007
Uber DonorEarly adopter... addicted to alphas.Not Kulvik

Wow, I didn't even know where I was when I came here for the first time again. I like the face lift and since you asked for opinions you get a few and you might as well get mine!

I think the fonts and everything look nice, I am on 1600x1200 (by choice) and the home page looks like it needs more content (right side bar just overcomes too much making the page imbalanced) however every other page that has enough content proves that this face lift is successful.

I am on 1600x1200 and I do not mind the font size; if you don't like it download Firefox3 Beta5, come to the page, hold down Control and press ++. Firefox will remember that size upgrade on your next visit until you change it, and you will never know the difference.

Ubercart > *

BTW - Makes the forums look great!

permalink #29 Thu, 05/15/2008 - 11:25
Ryan

Posts: 6997
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

Thanks for the feedback, kaizen. Smiling I'll try to remember to bump my monitor to a higher resolution when I get to fleshing out the front page... I can't imagine how empty it must look to you. Sticking out tongue (I'm using 1024 x 768 atm... I know, stone age.)

And I agree... the sharper appearance of the forums is imo one of the best changes. I've only noticed one problem with them in FF2 where the bottom border doesn't always appear around a post, but I haven't had the time to debug it yet.

permalink #30 Mon, 05/19/2008 - 15:07
seattle_magician
Posts: 25
 Joined: 02/29/2008
Bug Finder

Has anyone seen what the site looks like in IE7? The nav is all messsed up. It's all shifted to the bottom, and the donate link is almost invisible, as it seem to be obscured by another object?

Have a look at the attached PNG if you want to see. I'd say that at least that donate link would be important to fix. I'm viewing in Internet Explorer 7.0.5730.13

Let me know if you want some help fixing?

-Jacob

AttachmentSize
ubercart_pixture.png175.62 KB
--

Drupal Web Development & Design || Fast Web Hosting || Seattle Magician

permalink #31 Mon, 05/19/2008 - 20:11
psynaptic

Posts: 339
 Joined: 08/28/2007
Early adopter... addicted to alphas.Not KulvikTheminator

I have a PC and a Mac side-by-side so I can work on sites with Safari, IE6, IE7, Firefox, Opera and others. I'll happily fix these issues with the current theme. I'm still seeing the issue in Safari with the primary navigation text links being out of alignment with the nav bar.

--

Drupal Contrib API
Freestyle Systems

permalink #32 Mon, 05/19/2008 - 22:32
Ryan

Posts: 6997
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

rich, if you can tell me what CSS to add/change, I'd love it. Laughing out loud I have no way to debug the theme for Safari, and I don't even know what tools to use for IE to do the debugging (nor do I know if there's anything free available).

Thank you!

permalink #33 Tue, 05/20/2008 - 08:37
psynaptic

Posts: 339
 Joined: 08/28/2007
Early adopter... addicted to alphas.Not KulvikTheminator

There are a number of problems I see with this theme:

- Using tables for layout.
- Invalid XHTML 1.0 Strict and CSS 2.1.
- Same CSS rules imported twice due to implementation of Color module.
- Alpha transparency of PNG logo in IE6 shows as white background.

Method:

I needed to find a way to work on this theme without having the luxury of a proper local installation. I found the Firefox Save Complete plugin:

https://addons.mozilla.org/en-US/firefox/addon/4723

This allowed me to download the pages I needed to work on (the homepage and a forum page) as a HTML file with all imported stylesheets. It was then just a case of dropping them in my local htdocs and working out the issues.

I have the Web Developer Tool for IE7 installed but I don't find it much use compared to Firebug so I tend to debug IE by trial and error. I use Firebug to quickly see the CSS rules that are being applied to an element and then use experience, trail and error and lots of refreshing to find the most elegant solution. I have synergy2 installed as server on my Macbook Pro and client on my PC so I use a single mouse and keyboard to control both computers, the mouse jumps between Mac and PC so this makes debugging in IE much easier.

Problem:

The main cause of problems with the layout (apart from the use of tables) is that padding is being added to the table cells rather than the elements within the cells. The table cells have explicit width/height values so using padding on these elements was effectively increasing the size of the box and messing up the display in IE and Safari.

Solution:

Add this to the bottom of style.css:

/* various fixes by psynaptic */
#home .panel-col-last  {
  width: 49%; /* fixes panel on front page in IE6/7 */
}

#home .panel-col-last .more-link {
  padding-right: 2.4em; /* moves more link back to original position */
}

#header #site_name,
#site_search,
#logo {
  padding: 0; /* remove padding from table cells */
}

div#search {
  margin: 10px 20px 0 0; /* reposition search box */
}

#menu-2, #menu {
  line-height: 1.6em; /* fix chopped off text in IE6/7 */
}

#logo a {
  display: block;
  padding: 10px 0 0 10px; /* reposition logo */
}

#site_name h1 {
  padding: 12px 0 0 5px; /* reposition site name */
}

#home .item-list ul li,
#home .item-list ul li {
font-size: 1em; /* set font size for list items in homepage panel to 12px */
}

.forum-comment .links {
float: none; /* fix border bottom bug in forums */
}

@henns20: The first selector #home .panel-col-last targets the right of the two columns in the panel on the homepage. The rule decreases the value of the width property to 49%. This is a common issue with Internet Explorer where content gets pushed down due to not enough room being available for the full width of all elements on the page. It usually happens when using borders or padding and this is a common way to fix your panels issues.

futurist requested a larger font-size for the panels lists on the homepage so I changed them back to 1em (12px), seems to look better to me.

There are two stylesheets added by the theme that are identical apart from ~80 lines:

- sites/all/themes/pixture/style.css
- files/color/pixture-b9f28df3/style.css

Apart from making the theme harder to debug it also adds needless bandwidth usage and slightly increased download times for new visitors to the site. There are ~1300 redundant lines of CSS due to this. Turning on CSS aggregation would help if you don't have time to fix it properly.

I added a fix for the border bottom issue mentioned by Ryan further up this thread.

All-in-all I think it fixes all the issues mentioned in this thread without changing the positioning of anything in Firefox (I tend to use Firefox as a baseline).

--

Drupal Contrib API
Freestyle Systems

permalink #34 Tue, 05/20/2008 - 10:52
seattle_magician
Posts: 25
 Joined: 02/29/2008
Bug Finder

Nice work rich! That's pretty much the same process I use. Firebug is a front end web developers dream come true. Eye-wink

-Jacob

--

Drupal Web Development & Design || Fast Web Hosting || Seattle Magician

permalink #35 Tue, 05/20/2008 - 11:08
Ryan

Posts: 6997
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

Thank you so much for your help, rich. The explanation was enlightening, too. synergy2 sounds particularly intriguing... but I guess mostly because I never would've imagined it's possible, not because I can actually use it. Smiling

I did notice that now sometimes comment links are missing the line unless I disable the new rule you created... but it seems to be less, and you can't win them all.

I, too, don't understand the decision to use some crazy table/div hybrid HTML for the theme... it can certainly be improved on.

Also, while the links are no longer cut off, they are valigned to the bottom of the cell. Should I just chalk that up as expected as well? The links are fully legible and clickable now, so it's not a huge deal.

Thanks again! I'll go cook up an appropriate user badge for you. Eye-wink

permalink #36 Tue, 05/20/2008 - 11:38
psynaptic

Posts: 339
 Joined: 08/28/2007
Early adopter... addicted to alphas.Not KulvikTheminator
Quote:

synergy2 sounds particularly intriguing... but I guess mostly because I never would've imagined it's possible, not because I can actually use it.

It's got some pretty decent wow factor when I show it to my techie friends but it's one of the most useful applications I've ever used. Saves buying hardware to do the same job too!

Quote:

I did notice that now sometimes comment links are missing the line unless I disable the new rule you created... but it seems to be less, and you can't win them all.

I'll be able to fix this too, but the CSS aggregation is turned on and I can't check anything. It looks like my new rules are coming before the ones in the second stylesheet for Color module. Could you turn off CSS aggregation and I'll try again?

Quote:

I, too, don't understand the decision to use some crazy table/div hybrid HTML for the theme... it can certainly be improved on.

I was going to offer to create a new theme originally, but some people seem to like this one so it's probably best to just make this one better. Maybe I can do the theme for iteration 3?

Quote:

Also, while the links are no longer cut off, they are valigned to the bottom of the cell. Should I just chalk that up as expected as well? The links are fully legible and clickable now, so it's not a huge deal.

What browser are you seeing this in? It was working perfectly for me before, maybe something to do with the order of rules (i.e. other stylesheet coming after in the source).

--

Drupal Contrib API
Freestyle Systems

permalink #37 Tue, 05/20/2008 - 12:04
psynaptic

Posts: 339
 Joined: 08/28/2007
Early adopter... addicted to alphas.Not KulvikTheminator

This is what I see in the compressed CSS file:

#home .panel-col-last{width:49%;}
#home .panel-col-last .more-link{padding-right:2.4em;}
#header #site_name,#site_search,#logo{padding:0;}
div#search{margin:10px 20px 0 0;}
#menu-2,#menu{line-height:1.6em;}
#site_name h1{padding:12px 0 0 5px;}
#home .item-list ul li,
#home .item-list ul li{font-size:1em;}
body .forum-comment .links{float:none;}

It looks like my comment with IE6/7 is not liked by the aggregator since I don't see the rule:

#logo a {
  display: block;
  padding: 10px 0 0 10px; /* reposition logo */
}

I can confirm that my rules are being placed before the other stylesheet I mentioned in my comment above. You have got a couple of options here but the simplest would be to add a new stylesheet after the Color module one in template.php.

If you can leave CSS aggregation off until after we've made sure everything is working perfectly that would be best.

--

Drupal Contrib API
Freestyle Systems

permalink #38 Tue, 05/20/2008 - 13:42
Ryan

Posts: 6997
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

Went ahead and turned off caching for now, and I certainly appreciate the offer to give it a go for iteration 3. I'll be more than happy to take you up on it. Smiling

Also, I was seeing the links valigned to the bottom in IE7 on Win XP.

I commented out your link when testing b/c your style for the logo pushed it down to far - it seems like it was conflicting with another logo style that I'd already added in to the logo td cell itself.

permalink #39 Tue, 05/20/2008 - 17:12
psynaptic

Posts: 339
 Joined: 08/28/2007
Early adopter... addicted to alphas.Not KulvikTheminator

Yep, those rules will conflict because in the source it says:

<style type="text/css" media="all">@import "/sites/all/themes/pixture/style.css";</style>
<style type="text/css" media="all">@import "/files/color/pixture-b9f28df3/style.css";</style>

These 2 CSS files have almost identical content, without knowing the theme I would assume one is the default and the other is created using the Color module. The proper solution to this would be to fix the theme by only using the colour values in the second stylesheet thus not overriding any rules put into style.css. I could be wrong because I haven't looked into the theme files to know for sure.

If you want a quick fix for now while I/you submit a patch to the theme's issue queue you could add another stylesheet to template.php after the second one above.

Sorry for the short reply, I'm currently out of the office.

--

Drupal Contrib API
Freestyle Systems

permalink #40 Tue, 05/20/2008 - 18:45
psynaptic

Posts: 339
 Joined: 08/28/2007
Early adopter... addicted to alphas.Not KulvikTheminator

I just returned home and immediately checked the Pixture theme. It seems from the README.txt that you might need to visit the theme settings page and resave the settings:

Due to the mechanism of recoloring by the color module, your changes to the style sheet (style.css) in the theme directory does not take effect until you save the theme setting from the theme setting page. It would be easy to change the color scheme to the default scheme (= Girly Pink) and work on the style sheet changes. If you do so, the changes you are going to make to the style sheet would take effect immediately when you reload the current page from the web browser.

--

Drupal Contrib API
Freestyle Systems

permalink #41 Tue, 05/20/2008 - 21:34
Ryan

Posts: 6997
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

Uncommented the rule and re-saved the theme settings. Thanks for the reminder. Smiling

permalink #42 Wed, 05/21/2008 - 04:53
psynaptic

Posts: 339
 Joined: 08/28/2007
Early adopter... addicted to alphas.Not KulvikTheminator
Quote:

I did notice that now sometimes comment links are missing the line unless I disable the new rule you created... but it seems to be less, and you can't win them all.,

This seems to be fixed now. Can you still see this happening anywhere?

Quote:

Also, while the links are no longer cut off, they are valigned to the bottom of the cell. Should I just chalk that up as expected as well? The links are fully legible and clickable now, so it's not a huge deal.

This was definitely due to the theme settings needing resaving. It looks more consistent across browsers but I still feel they need a slight tweak.

There is another little issue I can see: When making the width of the browser window less than 845px, the table cell in which the Donate to Ubercart link resides breaks the display of the main navigation. See screenshot.

The problem might have been solved by giving the Donate to Ubercart cell an explicit width value, however, this causes the search input and submit button get broken onto 2 lines (this actually happens anyway if you resize the browser window to even smaller). This conveniently highlights a problem with using tables for layout; table cells are forced into vertical alignment so changes to the width of one cell will cause changes to all others in that column.

It's not a major issue but if I was building the theme myself I would make sure it was fixed. Other than changing the structure of the table (i.e. breaking the header out into 2 tables rather than 1), or dumping the tables altogether, you don't have that many options.

I've tested the front page in as many browsers as I could get my hands on and it seems fine (not broken any longer). See attached screenshots.

If there are any other issues you find and would like me to fix just let me know.

AttachmentSize
camino_mac.png203.18 KB
safari_mac.png202.13 KB
opera_mac.png204.4 KB
firefox_mac.png202.57 KB
safari_win.JPG120.56 KB
opera_win.JPG123.93 KB
firefox_win.JPG130.06 KB
ie7.JPG124.22 KB
ie6.JPG135.6 KB
theme_nav.png80.33 KB
--

Drupal Contrib API
Freestyle Systems

permalink #43 Wed, 05/21/2008 - 22:55
kaizen

Posts: 85
 Joined: 08/08/2007
Uber DonorEarly adopter... addicted to alphas.Not Kulvik

Rich - You are amazing, I am wondering how you managed to put so much time into this but I can not complain, if I had the time I would have done the same. I haven't used tables for layout design in some time and if I read your comments correctly it seems the theme uses tables for layout; I may also be thinking of something else but I think the W3C stated that tables were no longer to be used for layout designs. Thank god. =)

All in all the site looks great, at work I test my coding in IE6, Safari*, Firefox 2 and Firefox 3 RC1. I too use primarily Firefox for my browsing needs, Firefox 3 RC1 as a portable app for the time being in case it gives me issues, but its nice having both because FF3 has add-ons that do not work yet.

I started* Safari because I run a PC at work with WinXP and I noticed that Safari renders differently on OSX than it does on WinXP; I found this out a few months ago and all the while thought they were the same until I jumped on a mac book pro one day and noticed one of my sites was horribly broken in Safari.

I am digressing a bit I noticed but again Rich great work bravo for your meticulous display of information and your detailed explanations. I even learned a thing or two. =D

permalink #44 Tue, 05/27/2008 - 23:35
henns20

Posts: 11
 Joined: 10/11/2007

Wow Rich - one word ---"thorough"

As far as the panels 2 and altering the widths....yep i do that often on other themes...but when i used that technique on this pixture theme it was pushing the sidebars off still....i thought it had something to do with the tables layout. In any case...although this theme is nice because of the tables in this theme...don't like it....i actually used the foundation theme to create something similar...big fan of the foundation theme... & firebug very easy to work with...

As far as all of those pics...do you have alll of those browsers on your computers? I was recently tring to test a site on mulitple browsers and I came across a free tool http://browsershots.org

great job

If you need help migrating it to a tableless theme let me know..

jamie

permalink #45 Wed, 05/28/2008 - 11:48
psynaptic

Posts: 339
 Joined: 08/28/2007
Early adopter... addicted to alphas.Not KulvikTheminator
Quote:

I am wondering how you managed to put so much time into this...

I didn't really spend any time at all doing this. It took about an hour or so to fix the theme and then another couple of hours to write it up and take the screenshots.

Quote:

...I may also be thinking of something else but I think the W3C stated that tables were no longer to be used for layout designs...

If you really want to get down to semantics, tables should really only be used for tabular data. There are distinct disadvantages of using tables and one of them is pointed out above. The biggest problem I see is using structural elements for presentation so you can't easily change the layout without altering the (X)HTML. With something like Drupal where you can't just edit the source without overriding a theme function this becomes even more of an important issue.

Quote:

I too use primarily Firefox for my browsing needs...

Well, I actually use Safari 3 for my general browsing (it's very fast and clean) and only break out Firefox 2 when I need Firebug or the Web Developer Toolbar (there seem to be memory leak issues with Firefox). A bonus of using Safari is that form elements look great!

--

Drupal Contrib API
Freestyle Systems

permalink #46 Wed, 05/28/2008 - 12:04
psynaptic

Posts: 339
 Joined: 08/28/2007
Early adopter... addicted to alphas.Not KulvikTheminator
Quote:

As far as all of those pics...do you have alll of those browsers on your computers? I was recently tring to test a site on mulitple browsers and I came across a free tool http://browsershots.org

I've tried browser shots but I when I tried it there was a delay between submitting and receiving the images. Also they only give an image of the page so you can't test if everything works as expected. Sometimes links stop working and other funky stuff happens that you can only test with a real browser. I do have all those browsers installed. Laughing out loud

--

Drupal Contrib API
Freestyle Systems

permalink #47 Wed, 05/28/2008 - 13:54
kaizen

Posts: 85
 Joined: 08/08/2007
Uber DonorEarly adopter... addicted to alphas.Not Kulvik
rich wrote:
kaizen wrote:

I too use primarily Firefox for my browsing needs...

Well, I actually use Safari 3 for my general browsing (it's very fast and clean) and only break out Firefox 2 when I need Firebug or the Web Developer Toolbar (there seem to be memory leak issues with Firefox). A bonus of using Safari is that form elements look great!

Yeah I didn't mean to assume you used Firefox primarily although the way I worded it definitely seemed that way. Safari is much faster and Firefox with extensions and the UI is friendly, sleek, lovable? Then again I like FF because of its extensions and certain ones I can not live without (thats a lie don't listen to him).

permalink #48 Tue, 08/19/2008 - 11:54
Francois

Posts: 31
 Joined: 08/19/2008

Please email me the vector at my gmail address fran.carstens and lets get this done today.

permalink #49 Tue, 08/19/2008 - 11:59
Ryan

Posts: 6997
 Joined: 08/07/2007
AdministratorHead Code Monkey - I eat bugs.

This thread's been kinda stale for a while.. get what done? Smiling

permalink #50 Tue, 08/19/2008 - 13:01
Francois

Posts: 31
 Joined: 08/19/2008

Well, it seems like the post comments are not directly below the original, but at the end of the post. I was commenting on #15 - @tom-d: I've got a vector logo, but it is kinda blurry... I'd love it if you could sharpen that up somehow. PM me your e-mail address, and I can send you the file.