Double Bug(?) in uc_order.ca invoice action definition

Project:Ubercart Contributions
Component:Code
Category:
Priority:normal
Assigned:Unassigned
Status:active
Description
Project: 
Ubercart

Hello,

The first bug is a simple one. The word 'from' is mistyped as 'form', line 1251:
$sent = drupal_mail('uc_order', 'action-mail', $email, uc_store_mail_recipient_language($email), $settings, empty($settings['from']) ? uc_store_email_from() : $settings['form']);

The second bug was more difficult to figure out. Once this bug was fixed, I required this field to contain the domain setting for the ubercart store. The token replacements are listed there on the form. I used one of them for the 'From', [order-store-email]. The result was the 'from' address was empty.

There is a third issue, more of a coding issue than a bug, namely, the From field in the invoice action form is set to required in the form definition. The code, however, is programmed to provide a default if the value is empty. In fact, my solution to our problem was to use the form alter hook to set this to not-required and enter an empty value, thereby letting uc_store_email_from() take over, which provided the correct domain-setting-specific email address.

cheers

Version: 
Ubercart 2.0-beta6
janette's picture
Offline
Joined: 06/22/2009
Juice: 22
Thank You

I'm running across the same issue as I would like the confirmation emails to be sent 'FROM' the corresponding store from which the order was placed.

I've made the 'sender' field not required and put [order-store-email] as the default value in uc-order.ca.inc
Now the notification emails are sent with the correct store email.

I hope this will be fixed in the next update. Thank you so much for posting this, I've been searching forever for a solution.

torgosPizza's picture
Offline
Bug FinderEarly adopter... addicted to alphas.Getting busy with the Ubercode.
Joined: 08/14/2007
Juice: 4110
Re: Thank You
Assigned to:janette» torgosPizza

Bugs should really be posted at the d.o. project page: http://drupal.org/project/ubercart

--
Help directly fund development: Donate via PayPal!

hinrichsislcocom's picture
Offline
Bug Finder
Joined: 05/28/2008
Juice: 92
posted on drupal.org
Assigned to:torgosPizza» hinrichsislcocom

Thanks...I checked and the first bug appears to be fixed now. The other issues have just been submitted to drupal.org as a feature request, as the code is functioning fine, but it would help us multi-domain people to make a couple easy adjustments.

Bob Hinrichs
ISL Consulting
http://www.islco.com