Payment method change should not be allowed when order has been paid

Project:Ubercart Contributions
Component:Code
Category:
Priority:normal
Assigned:Unassigned
Status:active
Description
Project: 
Ubercart

Order edit form allows store admins to change payment method. This is good as long as order hasn't been paid yet. When order has been paid and payment balance is zero, such changes should be disallowed.

Currently there is no way a payment module itself could prevent from changing payment type.

Version: 
Ubercart 2.0-beta6
Lyle's picture
Offline
AdministratoreLiTe!
Joined: 08/07/2007
Juice: 6855
Re: Payment method change should not be allowed when order has b

In reality, it's entirely possible for an order to have more than one payment, and they could come through different payment methods. That means that the payment method field on the order can be wrong no matter what is chosen. I would argue that this field doesn't really mean a whole lot, especially since the individual payments record the particular method that was used.

What would you do if you found out that one of the orders had the wrong payment method listed? If you're using it a report, I would want to fix it rather than just leave the report incorrect.

SiliconMind's picture
Offline
Joined: 08/31/2009
Juice: 24
Re: Re: Payment method change should not be allowed when order h
Assigned to:Lyle» SiliconMind

Ok. That's a good point. But then this leads us to the point when the payment method has just an informative meaning and can not be relied upon. In that case (In reality, it's entirely possible for an order to have more than one payment, and they could come through different payment methods) ubercart should provide an interface for payment modules to support such scenarios. I must admit that this is probably a better way to go.