Home » Contributions » Ubercart Contributed Modules » File product » Issues

Errors on checkout when delivary pane invisible

Submitted by yhager on Thu, 10/18/2007 - 05:59
Project:File product
Component:Code
Category:
Priority:critical
Assigned:Unassigned
Status:active
Description
Project: 
uc_file_product

When using checkout on a cart that contains only file products (uc_cart_is_shippable() returns FALSE), the delivery pane is invisible.

However, the 'Next' button on the 'Customer information' pane, has the following HTML:

<input type="submit" class="form-submit" onclick="return uc_cart_next_button_click(this, 'delivery', 'customer');" value="Next" id="edit-panes-customer-next" name="op"/>

Since the delivery pane is invisible, the form gets submitted which results in error messages.

There are other issues, like the payment pane, which is uncollapsed by default in this case, and more.

I marked the bug as critical since this happens with the default settings, i.e. will happen to anyone installing this module.

Workaround:
uncheck the following in the checkout settings page:
[ ] Use collapsing checkout panes with next buttons during checkout.
[ ] Collapse a pane when its next button is clicked.
Thu, 10/18/2007 - 08:58
#1 View page
Ryan
Ryan's picture
Offline
Joined: 08/07/2007
Juice: 15438
Re: Errors on checkout when delivary pane invisible

Hmm.. I did have to debug quite a few issues related to collapsing panes recently... what version of UC are you running? (With my luck I bet it's the latest. Sticking out tongue)

Top
Thu, 10/18/2007 - 11:01
#2 View page
yhager
yhager's picture
Offline
Joined: 10/01/2007
Juice: 59
Re: Re: Errors on checkout when delivary pane invisible
Assigned to:Ryan» yhager

Yes, the latest (7e). sorry..

Top
Thu, 10/18/2007 - 11:20
#3 View page
Ryan
Ryan's picture
Offline
Joined: 08/07/2007
Juice: 15438
Re: Re: Re: Errors on checkout when delivary pane invisible
Assigned to:yhager» Ryan

Looking through the Bazaar logs, revision 452 had the fixes - which was fortunately after Alpha 7e released. (Fortunately for me, since I may have fixed the problem, but not for folks running 7e.) If you can't upgrade to the latest Bazaar version, you can try diff-ing uc_cart.module and uc_cart_checkout_pane.inc to see what changed to fix it.

Of course, going to the latest version means you'll need the workflow-ng module, and we haven't fully tested updates from previous versions to this. You might just try the workaround until the Alpha 8.

Top
Thu, 10/18/2007 - 18:21
#4 View page
yhager
yhager's picture
Offline
Joined: 10/01/2007
Juice: 59
Thanks! I see the fix you
Assigned to:Ryan» yhager

Thanks!

I see the fix you put in rev 452 - nice and clean to mark each pane as shippable Smiling Maybe I'll backport it into my own 7e..

Do you think it also fixes the tax calculation issue (http://www.ubercart.org/issue/1406/when_cart_not_shippable_taxes_are_cal...)? My guess is no, but I'm checking just in case..

Top
Fri, 10/19/2007 - 13:16
#5 View page
Ryan
Ryan's picture
Offline
Joined: 08/07/2007
Juice: 15438
Re: Thanks! I see the fix you
Assigned to:yhager» Ryan

Nah, I don't know exactly where that bug is coming from, but I'll point it out to Lyle and see if he knows. Smiling

Top