Home » Projects » Ubercart Contributed Modules » Improved coupon discount » Issues

Invalid coupon results in disappearing shipping

Submitted by 2shortstories on Wed, 01/02/2008 - 14:20
Project:Improved coupon discount
Component:Code
Category:
Priority:normal
Assigned:Unassigned
Status:active
Description
Project: 
Discount coupon system

Whenever an invalid or expired coupon is entered, the SHIPPING line item gets mysteriously taken off the order. This results in orders without shipping fees calculated in, whenever someone tries to use an invalid coupon code.

Please see if this can be fixed. Thank you!
Wed, 01/02/2008 - 14:40
#1 View page
2shortstories
2shortstories's picture
Offline
Joined: 08/29/2007
Juice: 73
Re: Invalid coupon results in disappearing shipping

please see attachment for screencapture.

AttachmentSize
test.jpg 27.64 KB
Top
Mon, 01/07/2008 - 08:29
#2 View page
zmove
zmove's picture
Offline
Bug FinderEarly adopter... addicted to alphas.Getting busy with the Ubercode.Internationalizationizer
Joined: 08/13/2007
Juice: 1192
Re: Re: Invalid coupon results in disappearing shipping
Assigned to:2shortstories» zmove

What version of PHP you have and what is the coupon module you use ?

Top
Mon, 01/07/2008 - 17:31
#3 View page
2shortstories
2shortstories's picture
Offline
Joined: 08/29/2007
Juice: 73
Re: Re: Re: Invalid coupon results in disappearing shipping
Assigned to:zmove» 2shortstories

I'm using the latest "improved coupon module" (1.4), and we're running on PHP 5.1.6 here. Any ideas?

Top
Tue, 01/08/2008 - 06:56
#4 View page
zmove
zmove's picture
Offline
Bug FinderEarly adopter... addicted to alphas.Getting busy with the Ubercode.Internationalizationizer
Joined: 08/13/2007
Juice: 1192
Re: Re: Re: Re: Invalid coupon results in disappearing shipping
Assigned to:2shortstories» zmove

Did you completely uninstall the previous coupon module before installing the new one ? (by checking all coupon table created in the database were deleted before installing the improved coupon module).

In addition, try to change the weight of your coupon, maybe it's the same weight than the shipping quote.

Top
Wed, 01/09/2008 - 14:43
#5 View page
2shortstories
2shortstories's picture
Offline
Joined: 08/29/2007
Juice: 73
Re: Re: Re: Re: Re: Invalid coupon results in disappearing shipp
Assigned to:zmove» 2shortstories

it's a fresh install of the improved coupon module, 1.4 ver. Where can I change the weight of my coupon vs. shipping quote?

Top
Wed, 01/09/2008 - 15:44
#6 View page
Lyle
Lyle's picture
Offline
AdministratoreLiTe!
Joined: 08/07/2007
Juice: 6846
Hope it's a different problem
Assigned to:2shortstories» Lyle

The weight is generally hard-coded, but that wouldn't be the problem. If the coupon module was somehow using the same line_item_id, that would be different. I don't see how that would happen though.

Top
Fri, 01/11/2008 - 05:12
#7 View page
zmove
zmove's picture
Offline
Bug FinderEarly adopter... addicted to alphas.Getting busy with the Ubercode.Internationalizationizer
Joined: 08/13/2007
Juice: 1192
Hi, In the coupon module and
Assigned to:Lyle» zmove

Hi,

In the coupon module and in the quote module, weight are not hard-coded, you can change them in both module options I believe.

for shipping : admin/store/settings/quotes/methods

for coupon : http://fr.gastronomie.kalys.com/fr/admin/store/customers/coupon (and edit the coupon you want to change weight).

I already tried to change coupon weight, when I putted a weight under the shipping weight, the coupon was displayed before, and when I put a weight higher than the shipping weight, it is displayed after. So it should work.

Top
Fri, 01/11/2008 - 19:53
#8 View page
2shortstories
2shortstories's picture
Offline
Joined: 08/29/2007
Juice: 73
Re: Hi,In the coupon module and
Assigned to:zmove» 2shortstories

I've changed the coupon weight and shipping quote weight to be different, and I'm still getting the same disappearing shipping quote problem.

Have you been able to duplicate this issue? I have tried duplicating it on 2 different Drupal and Ubercart installations, and results are the same.

Any other ideas...?

Top
Tue, 01/22/2008 - 11:32
#9 View page
zmove
zmove's picture
Offline
Bug FinderEarly adopter... addicted to alphas.Getting busy with the Ubercode.Internationalizationizer
Joined: 08/13/2007
Juice: 1192
Re: Re: Hi,In the coupon module and
Assigned to:2shortstories» zmove

After lot of testing, I'm unable to duplicate the problem. Does the 1.5 version have the same problem ?

Top
Fri, 11/14/2008 - 01:05
#10 View page
sleepingmonk@dr...
sleepingmonk@drupal.org's picture
Offline
Joined: 01/20/2008
Juice: 81
Patch
Assigned to:zmove» sleepingmonk@drupal.org

I've created a patch for both the original and zmove's coupon module. You can find them here:

http://www.ubercart.org/forum/support/6239/customer_can_complete_checkou...
for the original

AND here:

http://www.ubercart.org/contrib/1991
for zmove's improved

Hope this helps.

"I've had this birthmark since I was born." --JB

Top