Submit order vs. Submit Order

Project:Ubercart Contributions
Component:Code
Category:
Priority:normal
Assigned:Unassigned
Status:active
Description
Project: 
Ubercart

Hi,

In setting up a fresh install to test a module I'm developing, I ran into the following problem:

Every time I tried to submit an order on the order review page, it would just take me back to my shopping cart and not process the order. I think I tracked it down to this:

Line 1608 of uc_cart.module:
case variable_get('uc_checkout_submit_button', t('Submit order')):

It's checking for "Submit order" by default, but the default is actually "Submit Order" on a fresh install. Just saving the settings on the page admin/store/settings/checkout/edit is enough to fix this problem, so most people probably never run into this, but it had me stumped for a little while!

I think just changing that line to "Submit Order" will solve this issue.

Best,
Chad

Ryan's picture
Offline
Joined: 08/07/2007
Juice: 15438
Re: Submit order vs. Submit Order

Thanks for the post, Chad. I was running into that on Monday evening myself but was under the impression I had patched all the inconsistencies. I'll check again and post up a beta 2 if I have to.

EDIT: Pretty sure revision 717 took care of it, and the changes appear in the CVS at d.o. Possible you grabbed the dev version before that revision?

chadcrew's picture
Offline
Bug FinderGetting busy with the Ubercode.
Joined: 12/28/2007
Juice: 195
Hi Ryan, Yes, I think I
Assigned to:Ryan» chadcrew

Hi Ryan,

Yes, I think I grabbed this version from Bazaar last Saturday. Of course, I should have just upgraded when I started seeing the problem...that would have been a lot quicker...but I assumed it was a bug in my code (usually is!) Smiling

Thanks,
Chad