I can't duplicate on my test site. I had some issues upgrading the coupon module, but it worked fine after uninstalling and reinstalling it. The taxes I have set up calculate the subtotal, shipping, and coupon amounts like they're set up to. They also work when the free shipping option is the only one returned or among others.

There have been some recent changes to the line items system, though, so that might be the difference. I'm on the latest code, so I haven't tested beta 4.

Edit: Just realized I hadn't actually committed those changes yet. That's now fixed.

in my beta5 shop tax calculation is wrong. The added tax of 19% to a price of 1,67 is 0.38 = 2,05 which is wrong! I don't use any shipping modules or coupons, just selling downloads.
When I edit an order adding a line item with 0,00 the tax ammount will increase to 0.39

Thx for any help how to fix this!
Jürgen

Hmm... should be .31, eh? I'd open a new issue up for this and be sure to explain what your settings are and what version of Ubercart you're on. Discrepancies between the order total preview and actual tax have been fixed in the last month or two.

should be .32 (math. correct rounded to 2 digits).

I've tested again and here are some details:

Everything is fine on the first checkout page where user chooses adress and payment:

Bestellungen insgesamt (Vorschau):
Zwischensumme: 1,67 €
19% MwSt: 0,32 €
Gesamtsumme: 1,99 €

Then when I continue to review page wrong tax is calculated. Review page shows:

Zwischensumme: 1,67 €
19% MwSt: 0,38 €
Gesamtsumme: 2,05 €

I'm using ubercard beta5 and drupal 5.6. 5.7
ubercard Modules installed:

Cart 5.x-1.0-beta5
Order 5.x-1.0-beta5
Product 5.x-1.0-beta5
Store 5.x-1.0-beta5
Catalog 5.x-1.0-beta5
File Downloads 5.x-1.0-beta5
General terms and conditions of trade 5.x-1.6-beta4
Notify 5.x-1.0-beta5
Payment 5.x-1.0-beta5
Reports 5.x-1.0-beta5
Taxes 5.x-1.0-beta5
Cart Links 5.x-1.0-beta5
Google Analytics for Ubercart 5.x-1.0-beta5
PayPal 5.x-1.0-beta5
Workflow-ng 5.x-2.0-beta1
Workflow-ng UI 5.x-2.0-beta1

thx & regards
Jürgen

Some more report: about that bug:

The error description before happens when I'm logged in as an admin. When I'm logged in as an authentificated-user the calculation is also at the review page ok!

Bute then when I logged in to paypal, the paypal screen shows that:

Artikelmenge: 1
€1,61

Zwischensumme: €1,61 EUR
Steuer: €0,38
Betrag: €1,99 EUR

The total amount is ok, but net price and tax are wrong ?!

This work may have been fixed recently while Lyle was addressing some other tax issues. Is there any chance you can update to the Bazaar code and check it out now? (Be sure to check update.php once you've updated to the Bazaar version... you can download it as a .tar.gz at http://bazaar.ubercart.org.)

Hi Ryan,

thanks for your help! I still have problems finding a solution how to display prices including vat (This Thread: http://www.ubercart.org/forum/support/3326/tax_problem_prices_are_inclus... ), so I can't update yet. I will try to put these different points together this week when no other is offering a solution for the core.

thanks and best regards
Jürgen

Hi Ryan,

I have tested the clean beta6 and last bugs are fixed now.
But there is still an general error in how these whole calculations of taxes works. This is very important!

It is required that the calculation of total amount is calculated with tax-including-prices. Currently ubercard is calculating taxes after calculating total amount of prices without tax. This is wrong. It is required, that the tax is calculated to every single price first and then the prices and the taxes of the prices should be added.
Why?

Let’s use www.Amazon.de as an example to show you what I’m talking about. All prices at www.amazon.de are including taxes. When you add products this prices will be added and at the checkout the amount of total taxes is shown. If you buy 2 of the same book in one shopping-process, you pay the same total amount as if you buy the book twice in separated shopping processes of course.

In ubercard this is wrong because calculation is only working like this: Total amount is the amount of net prices (excluding taxes) and Tax is added to the total. But because of this function there will be rounding errors.

Example: I'm going to sell products in my ubercard-Shop which will cost 1,99 Euro including 19% Tax.
Without Tax the price of 1,99 is 1,67 (rounded)
1,67 with 19% Tax added, is 1,9873 (rounded 1,99)
When I buy 1 Product, everything is fine. Total amount is 1,99.
When I buy 2 Products the total amount ubercard calculates is 3,97 instead of (2 * 1,99) = 3,98. This Problem will be multiplicated with every more added products.

So currently ubercard calculates different per-product-prices and taxes depend on the amount of products you buy. If you buy some products in one cart, you will pay total a different amount as if you pay the same products one after one separately. This is a wrong function because Tax must be calculated per product, not for the total amount.
The correct financial accounting calculation forular is [(Product + Tax) * Amount] and not [(Product * Amount) + Tax]

Can you please fix this.

Thanks and best regards
Jürgen

I certainly don't have an immediate fix on hand or any involvement in the tax module. Right now it's fairly well hardcoded to calculate taxes based on the order total. I imagine it can be switched to calculate per-product, but then I believe it would break for U.S. stores. Maybe not. In any event, if you have a patch or implementation suggestion, that would help us address this in core.