Home » Issue Tracker » Ubercart

When configured to not validate CC numbers, CC validation fails

Submitted by dharmatech on Mon, 04/07/2008 - 17:13.
Project: 
Ubercart
Category: 
bug report
Version: 
Ubercart 1.0 RC
Priority: 
normal
Status: 
active

In uc_credit.module function uc_payment_method_credit('cart-process', ...) if variable uc_credit_validate_numbers is false (as it probably would be if you were testing with payment method test_gateway), intval() of a non-existent argument is tested for zero which it of course is, since the argument doesn't exist. This causes CC validation to fail. The fix (in 1.0-rc2) is to change line 334 from:

if (variable_get('uc_credit_validate_numbers', TRUE) || intval($arg->payment_details['cc_number']) == 0) {

to

if (variable_get('uc_credit_validate_numbers', TRUE) || intval($arg1->payment_details['cc_number']) == 0) {

This bug was apparently added in 1.0-rc1
#1Submitted by Ryan on Wed, 04/09/2008 - 16:39.

Re: When configured to not validate CC numbers, CC validation fa

Thanks for the find. Will get this fixed as soon as I get back in the office.

It's kind of embarrassing. Shocked