Home » Issue Tracker » Ubercart

uc_store_email_from adresse format

Submitted by flebas on Thu, 04/10/2008 - 15:45.
Project: 
Ubercart
Category: 
bug report
Version: 
Ubercart 1.0 RC
Priority: 
normal
Assigned: 
Unassigned
Status: 
fixed

I had problems with not receiving notifications from UC.

It appears this is a problem with address returned by uc_store_email_from().

uc_store_email_from returns an address in the format :

Shop name<email@shop.com>

Thus, the mail is transmitted by PHP to mail server with

MAIL FROM:<Shop name<email@shop.com>

This format is not compliant with RFC 2821 and messages are rejected by some servers.

I suggest to modify uc_store_email_from to only return a raw email address :

  $email_from = variable_get('uc_store_email', '');
  if (empty($email_from)) {
    $email_from = variable_get('site_mail', ini_get('sendmail_from'));
  }

  return $email_from;

Frederic
#1Submitted by TR on Fri, 04/11/2008 - 19:55.

Re: uc_store_email_from adresse format

Nice catch - I know a few people have mentioned a similar problem, but that sort of thing is really hard to diagnose because, as you said, the messages are rejected only by "some servers". (Not mine apparently - I was unable to reproduce this!).

Bumping this so Ryan sees it... Smiling

#2Submitted by Ryan on Fri, 04/11/2008 - 20:39.

Wonderful. I'm glad I

Wonderful. Laughing out loud I'm glad I don't have to beat my head on the desk coming up with a solution. Thanks a lot for posting this up... will try to get it in on Monday.

#3Submitted by Ryan on Tue, 04/15/2008 - 10:31.

Re: Wonderful. I'm glad I

Ok, I committed a fix. I actually just commented out the code instead of removing it, as it would be great to revisit this in the future to figure out how to make it work for all servers (or at least give the option for folks to use it if possible).