Home » Issue Tracker » Ubercart

Taxes aren't properly calculated for non-shippable items

Submitted by David Strauss on Thu, 08/30/2007 - 19:15.
Project: 
Ubercart
Category: 
bug report
Priority: 
critical
Status: 
closed

The implementation in uc_taxes.module should be:

function uc_taxes_calculate($order){
  if (is_numeric($order)){
    $order = uc_order_load($order);
  }

  if (empty($order->delivery_postal_code)){
    $order->delivery_postal_code = $order->billing_postal_code;
  }
  if (empty($order->delivery_zone)){
    $order->delivery_zone = $order->billing_zone;
  }
  if (empty($order->delivery_country)){
    $order->delivery_country = $order->billing_country;
  }

Currently, if uc_taxes_calculate receives a non-shippable $order object, taxes won't apply.
#1Submitted by Lyle on Fri, 08/31/2007 - 09:04.

Re: Taxes aren't properly calculated for non-shippable items

Good find. It's getting harder and harder to test all the different use cases.

Fixed.