Home » Projects » Ubercart Contributed Modules » Ubercart Contributions » Issues

Uc_notify_order_update corrupts message body

Submitted by stewey on Wed, 07/30/2008 - 19:03
Project:Ubercart Contributions
Component:Code
Category:
Priority:minor
Assigned:Unassigned
Status:active
Description
Project: 
Ubercart

Uc_notify_order_update always pushes the message body through check_markup() with filter 3 - regardless of settings. This is because it checks for the value of a non-existent entry in the 'variable' table ('uc_checkout_status_format').

Version: 
Ubercart 1.0
Thu, 07/31/2008 - 15:33
#1 View page
Lyle
Lyle's picture
Offline
AdministratoreLiTe!
Joined: 08/07/2007
Juice: 6846
Re: Uc_notify_order_update corrupts message body

Thanks. The real variable is "uc_notify_order_update_format".

Top
Thu, 07/31/2008 - 17:44
#2 View page
stewey
stewey's picture
Offline
Bug Finder
Joined: 05/14/2008
Juice: 54
Re: Re: Uc_notify_order_update corrupts message body
Assigned to:Lyle» stewey

Cheers! Note that body is pushed through the correct filter a few lines up. So, this check_markup() call could possibly be removed?

Top
Fri, 08/01/2008 - 08:50
#3 View page
Lyle
Lyle's picture
Offline
AdministratoreLiTe!
Joined: 08/07/2007
Juice: 6846
Re: Re: Re: Uc_notify_order_update corrupts message body
Assigned to:stewey» Lyle

Heh, I didn't even see that.

I think I'm going to get rid of the first check_markup(). Right after that, the token values are replaced with actual order values. Since these generally come from the customer, they need to be filtered, too.

Top