Small fix for uc_catalog.css

Project: 
Ubercart
Category: 
bug report
Version: 
Ubercart 1.6
Priority: 
normal
Assigned: 
Unassigned
Status: 
postponed

Still haven't found the correct place to post this (hopefully getting it in the issue tracker helps you guys keep organized)... but uc_catalog.css needs a "clear: both;" in the .category-grid-products section for images to display correctly in the catalog module.

Please see:
http://www.ubercart.org/forum/bug_reports/5777/catalog_image_problem_uc_...
http://www.ubercart.org/forum/support/5425/catalog_image_problem_questio...

again, I'm sorry to be posting it in so many places, I just wasn't sure how to best bring it to someone who has CVS access to get it submitted.

Thanks!

Re: Small fix for uc_catalog.css

Sorry to bring this up again but the recent push of updates has got me realizing how much of a bummer this is to fix every time an update comes out (and gives me hope that it can get fixed!)... any chance of getting this committed before 1.7?

Thanks!

Re: Re: Small fix for uc_catalog.css

I checked it out on the Livetest, and things seemed to work fine. Adding the clear: both; didn't have any adverse effects, so I don't see why we shouldn't add it in... but are you sure it's not something in your theme conflicting with the grid CSS? And will this change screw up existing themes?

Re: Re: Re: Small fix for uc_catalog.css

Ahhh I think I may have found it: I noticed that on the livetest all of the thumbnails were, well, thumbnails created by ImageCache. My guess is that I started using Ubercart when it was using the wrong IC preset, then when I upgraded to IC 2.x Ubercart updates could never create the new preset. My images were showing up pretty much full-size. I recently uninstalled IC 2.x and went back to 1.7, and then Ubercart created the correct preset and now all of my thumbnails are tiny. Thus, the clear: both is not necessary because the thumbnail is always smaller than the accompanying label text. Although, one could argue that the clear: both; should be added in case the user wished to resize the image to make it bigger...

Thanks for taking the time to check this out!

Re: Re: Re: Re: Small fix for uc_catalog.css

No problem! If you can speak as to whether or not this would mess up existing themes, I would consider making the change. I just wouldn't want to ruin anyone's existing setup on an upgrade. I suppose folks needing this can always add the property in their theme's style.css.

Re: Re: Re: Re: Re: Small fix for uc_catalog.css

I didn't think about adding it to the style.css.

I don't think it would affect any existing theme, but I have no basis for that besides my own experience and hearing from one other person. Guess this should just be left alone barring anyone doing significant testing?

Thanks again

Re: Re: Re: Re: Re: Re: Small fix for uc_catalog.css

Alrighty. I'll leave it be. We always know where to find the fix if we need it. Smiling