Home » Projects » Ubercart Contributed Modules » Ubercart Contributions » Issues

Order review - nowrap

Submitted by svihel on Tue, 09/23/2008 - 11:12
Project:Ubercart Contributions
Component:Code
Category:
Priority:minor
Assigned:Unassigned
Status:active
Description
Project: 
Ubercart

In the table displayed in Order review we have few rows with parameter "nowrap". Is there a need for this?

I only asking because I have quite a long description in few columbs and it actually outside of my css layer because of this parameter.

In my instalation I actually fixed this be removing this parameter from the source, but I must do this after every patch ... you know what I mean.

So is there a good reason for this? If not, could someone please delete this parameter from next released code?

Version: 
Ubercart 1.3
Thu, 12/11/2008 - 09:42
#1 View page
svihel
svihel's picture
Offline
Joined: 05/29/2008
Juice: 140
Re: Order review - nowrap

BTW, its in file /sites/all/modules/ubercart/uc_cart/uc_cart.module, line 1622

.'nowrap>'. $row['title'] .':</td><td class="data-col">'

change to

.'>'. $row['title'] .':</td><td class="data-col">'

Top
Tue, 09/23/2008 - 13:04
#2 View page
Ryan
Ryan's picture
Offline
Joined: 08/07/2007
Juice: 15438
Re: Order review - nowrap

Yeah, the whole general CSS for that needs to be updated. If you can post a patch, that'd be great... otherwise changes may have to wait until D6.

Top
Tue, 09/23/2008 - 16:54
#3 View page
svihel
svihel's picture
Offline
Joined: 05/29/2008
Juice: 140
Re: Re: Order review - nowrap
Assigned to:Ryan» svihel

I have never give much of a thought to these patching issues until now, so I'm not sure if I'm doing it right, so don't be hard on me if not :]
Patch is created by WinMerge, one of recommended patching programs on drupal homesite so hopefully everything should be all right.

AttachmentSize
uc_cart.module.patch 435 bytes
Top