Ubercart

I had to make a change to lines 78, 84 and 346 of the .module file to get this to work without throwing errors. In each case you had:

"SELECT [field] {FROM [table]} WHERE aid = %d LIMIT 1;"

which I changed to:

"SELECT [field] FROM {[table]} WHERE aid = %d LIMIT 1;"

at which point it worked great. Nice addition. Very useful.

Hi Drupup, Well spotted, drawback of using phpeclipse as an IDE, I'm afraid! Will add the change to the module, although I think it should probably read "SELECT [field] FROM {table} WHERE aid = %d LIMIT 1;" the double curly braces was a mistake.

Even better!

Really nice to have this feature in the mix. Can't believe some of the torturous workarounds I was using before.

The "CREATE TABLE" statement in the .install file and several other SQL queries in the .module file are incompatible with PostgreSQL.

* The queries use backticks (`) around column names
* The column type is listed as INT(10), where an INT would suffice

I'd be happy to help supply patches to make this module work with both MySQL and PostgreSQL

Hi Joeredhat,

Thanks for getting in touch, to be honest I never wrote the SQL statements to work with Postgres only Mysql. When I get time I will replace the install sql with a proper hook_schema function.

Regards Luke

I found that it does not work when used creating orders (admin/store/orders/create).... the attribute quantity box appears, but does not calculate the appropriate total when it adds the product to the order =(

is that an easy fix?

Using this module, I get warnings when adding to cart. Latest versions of DP + views + ctools + panels + UC.

warning: Illegal offset type in /home/content/h/p/r/hprwebadmin/html/modules/uc_attribute_quantity/uc_attribute_quantity.module on line 281.

OK as nobody posted after me, I'm just going to edit this post from here on out. Above is the error I was getting, and I thought my original fix would do the trick, but it turns out it wasn't updating the total $$ based on the QTY posted. so here is my revised function uc_attribute_quantity_cart_item() (circa line 276 in uc_attribute_quantity.module). I also added support for 0 qty in attributes, although that requires slight tweaking elsewhere as well (hint: set default to 0 at line 57, and required to 0 at 59, and check if(QTY>0) inside the foreach that digs down to $qty circa line 323 before outputting " X " . $qty).

Howdy all,
Not a Drupal newb, but am an Ubercart newb so forgive me if I'm asking something that's obvious here.

I downloaded and installed this potentially-life-saving module. Can't seem to figure out how/where to get the quantity fields to show up with the attribute options. In the Attributes overview, I still only get the display options for "Text Field, Select Box, Radio Buttons, Checkboxes" for my attribute. Am I missing something? Seems that the option to use a quantity field would appear here.

Can anyone lend an assist on this???

I'm working on another attribute module and while testing that, I realized that neither this one nor mine appears on the invoice. The function hook_product_description_alter() doesn't get called at all when preparing the invoice. If this is so, this might be a serious core bug, actually. Any of you had experience with this?

I'm not sure if you are talking about showing the attribute quantity on the invoices, which are shown on a store admin's dashboard, however I can see the quantity being added to test orders I have created, see attached.

Then I don't understand at all. I'm on Drupal 6, UC 6.x-2.4, the latest stable.

/user/#/order/#: your X10 doesn't show, mine shows*
/admin/store/orders/#: both show
/admin/store/orders/#/invoice: neither shows

*mine is not yet completely finished but stores an array. Hook_product_description_alter() turns the array into a string representation. In cases where I noted 'doesn't show', I got the "Array" string instead of the string I would create myself.

Then off I go to try to find out the cause...

Mine shows on admin/store/orders/%/invoice It shows under the products on order! See attached.

You are correct about it not showing on user/%/orders/% must be a permissions thing, as it works when I am the SU admin user, will revisit it as and when I get chance.

I didn't have time to look into that in more detail because I have a more pressing thing to do with the module... Before I delve deep into the code, it might be easier for you to know: is there a way to specify the attr quantity programmatically? Passing the following array to uc_cart_add_item() gives warnings and doesn't actually calculate with the quantities (although it does appear in the cart in the product description):

If not yet solved, I'll have to modify the code to do so but I might have overlooked some simpler but obvious solution. I hope so...

Hi, to be honest to answer your question I would have to look back over the code myself and try to understand it again, the best thing would be to have a search around the API documentation and see if you can find anything useful.

Hi Xomby, thanks for this patch, I will roll it in when I get 5mins, off on holiday now so don't have chance right now.

Hold your horses, Luke!

I tried the code segment I quoted on a different site and much to my surprise, it worked flawlessly. Upon comparing the two sites, it turned out that the failing one is just the one where I did apply Xomby's patch. It's just that end() that makes the uc_cart_add_item() fail. In the setup I have the $item->data['attributes'][$key] seems to return a single string all the time. It might be cases where it is an array but that case should be checked in order to not use end() without distinction.

And then you can actually add that original code to the documentation, it not only looks logical, it is...

I am not sure if anyone else has had this problem, but when using Node Checkout along with this module, the quantity field disappears ... I am not sure how to fix it. Otherwise, it works fine when the attribute is not attached to a product via node checkout.

Hi,

I have a common setup UC 2.x, uc_aac and uc_aq. I use the attribute and I add the quantity to the attribute, but from time to time the node ID is missing some how that I get this error:

After some digging I locate the problem in the function uc_attribute_quantity_option() in the line:

If I hard code the node ID the problem goes away for good. I am running Drupal 6.22.

Any ideas?

Sorry to say, this patch has even more problems, it seems, than I previously thought. Just think about it, with a quantity of zero, this will not compensate for the original attribute module adding the attribute cost superfluously. Consequently, a quantity of zero will still add the cost once.

Luke, do you plan to go ahead to Drupal 7 and its UC? If you do, I'd like to discuss some issues. When I tried to integrate your module into my site, I found rather serious conceptual issue. As long as you use it as is, it works all right but when you need to interact with other modules and workflows (eg. populating the quantity fields programmatically), some of your approaches make it very painful. I'd be willing to contribute, not only to criticize...

I recently had this problem and found a relatively simple fix. It requires knowing how to set up a custom module, but the code is very simple:

http://www.gaslampmedia.com/blog/node-checkout-quantities

Hello everyone. I downloaded and installed the module.

In my ubercart site i have an ubercart product class named weddingcake.
For weddingcake class i have set up an attribute for the shape with some default price values.
I have enabled the quantity for that field in order to put the number of guests.

For the default values of the attribute, the calculation ShapeValue x guests is done correct.
If i change the Shape price attribute at weddingcake level, then the calculation ShapeValue x guests is not correct.

Can anybody verify this?

Hello again,

I think that the module does not make the correct calclulations if i change the price of an attribute in product/product-class level.

it works for the default price attributes, but not when you change it at product level. Is there anybody that can verify this?

Hello everyone,

I think i solved my problem for this module. My setup is ubercart-2.7 and drupal 6.22. The code in function uc_attribute_quantity_cart_item($op, &$item) {line 276 of ubercart quantiy module} makes a call to uc_attribute_load usiing only $key as a parameter.

The signature for this function at http://api.ubercart.org/api/function/uc_attribute_load says that $type parameter Determines whether $nid refers to a node or product class. $nid is ignored if $type is not 'product' or 'class'.

So if i call uc_attribute_load($key) i get the price value of the base attribute, not the the price value of the attribute that has been overrided at product/class level.

the function call should be $attr = uc_attribute_load($key,$item->nid,'product'); in order to take as price the correct value.

Can anybody confirm this? In my case solved the problem

Hi,

For some odd reason I can not figure out why the quantity is not been print on the invoice or order. The attribute name prints, but not the " x 123". Any ideas?

Is there a port or one in progress for UC 3?

I am also interested in a port of this to version 3.

Cheers.

Hello! I'm a newbie to developing modules but I've been trying to port this to Drupal 7. I kept on hitting a wall though. Let us know if someone had a success on porting this to 3.x. Thanks!

I change the line 78 on uc_attribute_quantity.module to
$res = db_query('SELECT id FROM {uc_attribute_quantity} where aid = :aid', array('aid' => $aid))->fetchField();
and seems to work but i guess there is a lot to be change...
if anyone is interested i have attached the files

Not quite ready for drupal 7/ubercart 3 yet: PHP Fatal error: Call to undefined function db_last_insert_id() in /var/www/sites/all/modules/uc_attribute_quantity/uc_attribute_quantity.module on line 355

duplicate

yeah...the problem is that db_last_insert_id() is not suported anymore in drupal 7 ....

Emilacosta, were you ever able to solve this problem. We have a situation where the x10 is showing on the admin view, but no on the invoice.

Frustrating.