Ubercart

On my sandbox installation (d16, uc_roles 6.x-2.2, Views 6.x-2.8, VBO 6.x-1.9) nothing happens when I attempt to change role expiration. I get the message:

Performed Set role expirations on user username

but the role is not added, nor is an expiration set if the role was already there.

I've tried it in bulk and one at a time. I've looked through the code and I'm afraid I don't see what might be wrong.

Let me know what I might do to help troubleshoot this.

The only thing I see so far is the line (146):

  uc_roles_user('update', $context, $object, 'account');

but looking at http://api.ubercart.org/api/function/uc_roles_user/2 I see that the first argument to uc_roles_user() doesn't have any action associated with "update".

I'm thinking that perhaps it should be

  uc_roles_user('submit', $context, $object, 'account');

instead?

The change from 'update' to 'submit' successfully forced the role/expiration addition! So that's progress. The downside is that for every user I've applied updated, every other role they had were removed entirely.

That's good enough for my purposes right now, but anyone looking for this functionality should be warned that simply changing 'update' to 'submit' on line 146 may have serious consequences.

Without looking at the code, I'd hazard a guess that the parameters need to include the current status for any existing roles. 'Submit' sounds like it's recording everything "anew", and if the incoming parameter is missing the other roles, they're not being saved.

Sorry it didn't work out of the box. I'm confused as to why...

Hmm, looking at uc_roles_user_submit(), this may be where the existing roles are being deleted:

The next user might try adding the existing roles to $edit['roles']

The original call to uc_roles_user_submit() with 'update' won't work simply because uc_roles_user_submit() won't act on that op (maybe that was removed in newer version of UC core?). So nothing happens.

Changing that to 'submit' runs the submit operation, which is really not a good idea as it's actually hook_user's submit handler for the user form. So it's doing all sorts of other stuff, such as checking whether you've made any roles permanent and so on. As kentr points out, to make this work you need to fake up what it's expecting, as if you were coming in from the user form. This is not a good approach.

Instead, use the API -- that is what it's there for. There is a function uc_roles_grant() which even does the user saving for you!

Working code on the way

It worked at one point on my local box...

Thanks for pointing out uc_roles_grant(). Didn't know that function existed.

Fixed version of the code.

This really belongs as a patch to the UC roles module IMO.

I've also:

- removed $polarity_widget form element as it's not used
- removed the 'Add role' -- as far as I can see this is just a kludge to get uc_roles_user_submit() to act.
- changed the form to allow changing / assigning more than one role at a time
- added help text and an explanatory note in the event that there are no available roles.